Acceptance criteria:
- feature has been checked and is working as expected
corresponding automated test is in place
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| REST: Add e2e-test for spam block list | mediawiki/extensions/Wikibase | master | +24 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T335067 Epic: Wikidata Query Service stabilization | |||
| Resolved | Lydia_Pintscher | T314503 rollout of the new Wikibase REST API to Wikidata | |||
| Resolved | Lydia_Pintscher | T316354 Ensure rate limiting and potentially other harm preventions are in place for the Wikibase REST API | |||
| Resolved | Silvan_WMDE | T326955 Ensure URLs on the spam block list can not be added as values |
Event Timeline
Comment Actions
Task Breakdown notes
- follow instructions on the SpamBlacklist wiki page and test locally
- write a test:
- ensure that SpamBlacklist is set up in CI
- find out about or modify config so that we have a disallowed URL value
- write at least one test that attempts to create a value with a URL that is known to be blocked
Comment Actions
Change 881480 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):
[mediawiki/extensions/Wikibase@master] REST: Add e2e-test for spam block list
Comment Actions
Change 881480 abandoned by Silvan Heintze:
[mediawiki/extensions/Wikibase@master] REST: Add e2e-test for spam block list
Reason:
not needed here and now
Comment Actions
This has been tested locally and works a s expected:
[SpamBlacklist] Match! [SpamBlacklistHit] 10.0.0.2 caught submitting spam: http://grusskarte http://grusskarte [Wikibase] Wikibase\Repo\RestApi\Domain\Services\ItemUpdateFailed: <Error, collected 1 message(s) on the way, array value set> +----------+---------------------------+--------------------------------------+ | error | spam-blacklisted-link | [ [ grusskarte ], text ] | +----------+---------------------------+--------------------------------------+ in /var/www/html/w/extensions/Wikibase/repo/rest-api/src/DataAccess/MediaWikiEditEntityFactoryItemUpdater.php:59
Team has agreed that no automated e2e test in CI is needed.