Page MenuHomePhabricator

Ensure URLs on the spam block list can not be added as values
Closed, ResolvedPublic3 Estimated Story Points


Acceptance criteria:

  • feature has been checked and is working as expected
  • corresponding automated test is in place

Event Timeline

Silvan_WMDE set the point value for this task to 3.

Task Breakdown notes

  • follow instructions on the SpamBlacklist wiki page and test locally
  • write a test:
    • ensure that SpamBlacklist is set up in CI
    • find out about or modify config so that we have a disallowed URL value
    • write at least one test that attempts to create a value with a URL that is known to be blocked

Change 881480 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] REST: Add e2e-test for spam block list

Change 881480 abandoned by Silvan Heintze:

[mediawiki/extensions/Wikibase@master] REST: Add e2e-test for spam block list


not needed here and now

This has been tested locally and works a s expected:

[SpamBlacklist] Match!
[SpamBlacklistHit] caught submitting spam: http://grusskarte http://grusskarte
[Wikibase] Wikibase\Repo\RestApi\Domain\Services\ItemUpdateFailed: <Error, collected 1 message(s) on the way, array value set>
| error    | spam-blacklisted-link     | [ [ grusskarte ], text ]             |
 in /var/www/html/w/extensions/Wikibase/repo/rest-api/src/DataAccess/MediaWikiEditEntityFactoryItemUpdater.php:59

Team has agreed that no automated e2e test in CI is needed.

Confirmed - works as expected. Thanks for checking