Page MenuHomePhabricator

Mobile quick view does not consistently have the over scroll bouncing effect
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Search for cat
  • Open the preview with only lead image and section cards
  • Try to over scroll

&quickView=Chinese+mountain+cat

overscroll.gif (666×387 px, 254 KB)

What happens?:

  • The preview remains fixed and does not move
  • It creates a perception that there is more content beyond the section card because the card seem to extend beyond the edge

What should have happened instead?:

  • If the user over scrolls there should be a bounce effect. It already exists for previews that have more content after the section card. If one were to scroll past the commons widget one would see that bounce effect in action.

Software version (skip for WMF-hosted wikis like Wikipedia):
Other information (browser name/version, screenshots, etc.):

Event Timeline

Please note that I have found more than one issue on safari while fixing this and they were all related issues:

  • When The result has just image and sections the image was getting truncated or removed
  • Changed the way we set the width of the search preview so that we can now see the right border of the section (before it really looked like there was more behind the screen)
  • Fixed it so that there is a bounce effect in all cases
  • Fixed the Main image when its aspect ratio was less than 0.75, safari was adding a grey border at the bottom
  • On mobile, if image is very large its width will be set to a max of the screen - 50px (like we do for commons images) otherwise the rest of the content is not visible

Change 883537 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] Mobile quick view doesn't consistently have bouncing effect

https://gerrit.wikimedia.org/r/883537

Change 883537 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Mobile quick view doesn't consistently have bouncing effect

https://gerrit.wikimedia.org/r/883537

Etonkovidova subscribed.

Checked in betalabs - need @Sneha feedback since there might be some subtle design points that I could miss. Sneha - take a look at https://en.m.wikipedia.beta.wmflabs.org/w/index.php?search=Chinese+mountain+cat&title=Special:Search&profile=advanced&fulltext=1&ns0=1&quickViewEnableMobile=1&quickView=Chinese+mountain+cat. I checked it in browsers emulators and on real devices (iPhone and Android) - the behavior is consistent.

(the animated gif):

chinese_cat.gif (692×363 px, 192 KB)

Note: There is an issue in iOS only (@SimoneThisDot mentioned it) - the article card displays some additional grey background. I'm not sure if it was filed, so I filed it as T328095

@Etonkovidova the bounce effect seems to be working fine. However because the card is still hugging the edge (no pixels between the card and the edge) it still creates the perception that there is more content beyond the card.

Ideally we should leave 8 px space between the last card and the edge to avoid creating that perception of more content and also for it to look proper. Tagging @SimoneThisDot as I see this ticket only specifies the bounce effect fix but the spacing is also creating the same problem.

I have created another ticket for spacing issues mentioned above: T328138
So this is good to go.

I have created another ticket for spacing issues mentioned above: T328138
So this is good to go.

Thx, @Sneha! Moving to Verify on Production.

Checked in wmf.21, e.g. search=yarra+charry. The fix is in place.