From Michael: probably not needed until we get closer to end of year.

Looked into this a little bit, seems like some bug going on. One of the ones did have the donor name on the donation but it's NULL in the civicrm_contact db (which causes the email to show up as the name). Working on trying to replicate it locally.

So the one I found just lately was a GPay recurring. It didn't get a token from the front end for some reason, so the initial donations message from payments-wiki was bumped to the damaged queue for being recurring with no token.
Then we got a RecurringContract IPN for it (which DID have the token) but that was discarded because we only use those for iDEAL.
Finally we got an entry for it in the audit, ran the TokenizeRecurringJob on it, and sent that to the donations queue. It was entered into the database with an email address but no name attached.

For GPay and Apple Pay, since we get a full name field from Google or Apple, we don't send any name info to Adyen. So their IPNs and their audit files don't have that data.

Possible fix:

• When a donation is recurring but we don't get the token on the front end, send it to the pending queue rather than donations.
• Expand the RecurringContractJob to handle non-iDEAL donations, as long as they have a pending message.

I was looking at CZK contribs for this month and 18 one-time donations got this error too. Samples:

Recent breadcrumbs:

177712621.1 cid=33533171 is a one-time ApplePay donation from Jul 13, with email address but no name and a Silverpop/RML contact source. Donor name is visible at Adyen console.

177711243.1 cid=55847508 is a one-time ApplePay donation from Jul 12, with email address but no name and a Silverpop/RML contact source. Donor name is visible at Adyen console.

cid=49363433 187546189.1 ApplePay Visa onetime Aug 3rd

cid=32204570 187547205.1 ApplePay Visa onetime Aug 3rd

Thanks for all the data @MBeat33 I think this something where the donor gets added to civi first through RML. When there is no name in civi the email address is shown. Then when the donor makes an actual donation we aren't updating the name in civi for some reason.

@MBeat33 just to confirm @Cstone's theory, I checked on 187546189.1 and found that we did actually collect names and send them to the queue from paymentswiki.

So I'll review how we update the donor info when adding a contribution to an existing donor, and change it to include adding a name when the existing record just has an email.

That's welcome news, thank you @Ejegg

Change 959334 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Test for adding missing name to matched contact

https://gerrit.wikimedia.org/r/959334

Change 959334 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Add missing name to matched contact

https://gerrit.wikimedia.org/r/959334