Page MenuHomePhabricator

Table of contents Collapse/Expand not working
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Open a page with table of contents and subsections
  • Click to collapse/expand

What happens?:

Nothing happens

What should have happened instead?:

The selected section should expand/collapse as a toggle of the current state

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

I tried to check the cause traced it down to function collapseSections, isSelected is always false and toggle state then becomes always undefined, so the elements do not change state.

Mabualruz changed the task status from Open to In Progress.Jan 16 2023, 5:06 PM
Mabualruz claimed this task.

Change 880510 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/skins/Vector@master] Table of contents Collapse/Expand not working

https://gerrit.wikimedia.org/r/880510

Change 880510 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Table of contents Collapse/Expand not working

https://gerrit.wikimedia.org/r/880510

Change 880913 had a related patch set uploaded (by Jdrewniak; author: Mabualruz):

[mediawiki/skins/Vector@wmf/1.40.0-wmf.18] Table of contents Collapse/Expand not working

https://gerrit.wikimedia.org/r/880913

Change 880913 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.40.0-wmf.18] Table of contents Collapse/Expand not working

https://gerrit.wikimedia.org/r/880913

Mentioned in SAL (#wikimedia-operations) [2023-01-17T21:34:50Z] <ebernhardson> scap also backporting [[gerrit:880913|Table of contents Collapse/Expand not working (T327064)]]

Mentioned in SAL (#wikimedia-operations) [2023-01-17T21:54:43Z] <ebernhardson> Finished scap: Backport for [[gerrit:880913|Table of contents Collapse/Expand not working (T327064)]]

ovasileva lowered the priority of this task from Unbreak Now! to Medium.Jan 18 2023, 9:28 PM
ovasileva subscribed.

Confirming that collapsing of the ToC works in production and on the beta cluster.