Incorrectly attributed as the author of a random commit I have nothing to do with in a repository I've never touched
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	ashley
	Jan 16 2023, 5:53 PM

Description

So just a while ago I got this notification here on Phab:

"@Lucas_Werkmeister_WMDE added a reverting change for rWDQG45258c8c3960: Bump bootstrap-table from 1.21.1 to 1.21.2: rWDQG8655ff6e22f1: Revert "Bump bootstrap-table from 1.21.1 to 1.21.2"."

The problem is simple enough: I did not commit rWDQG45258c8c39603d8a45ebfc2df7730567efccab9b or have anything to do with it, despite somehow being listed as the "author" of the commit in question (?!). Looking at the linked GitHub pull request, it was largely done by dependabot with very little to no human interaction.

The GitHub contributors page for the wikidata-query-gui repository lists all the people who've ever contributed to the repo and have a GitHub account; though I have a GitHub account, I'm not listed as I've never committed to this repo.

So, uh, not quite sure what's going on here but I'd appreciate if someone could take a look at this.

Related Objects

Mentioned Here: rWDQG45258c8c3960: Bump bootstrap-table from 1.21.1 to 1.21.2
rWDQG8655ff6e22f1: Revert "Bump bootstrap-table from 1.21.1 to 1.21.2"

Event Timeline

ashley created this task.Jan 16 2023, 5:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 16 2023, 5:53 PM

Indeed. Corresponding (mirrored) Gerrit patch: https://gerrit.wikimedia.org/r/c/wikidata/query/gui/+/866822

The commit has the metadata of:

Parent:     6ec26b23 (Remove outdated comment for download())
Author:     Addbot <addshorewiki+addbot-dependabot@gmail.com>
AuthorDate: 2022-12-13 10:01:32 +0000
Commit:     Addbot <addshorewiki+addbot-dependabot@gmail.com>
CommitDate: 2022-12-13 10:01:32 +0000

I suspect that, for whatever silly reason, Phabricator's fuzzy matching of names is attributing these commits to "ashley" rather than @Addbot or @Addshore. Looking at https://phabricator.wikimedia.org/diffusion/WDQG/history/master/ you can see that all the commits by Addbot are actually linked to ashley, this is probably the first one to be reverted, triggering a notification.

Possible solutions, short of fixing Phab: 1) create an Addbot account using that email so Phab will correctly attribute the patches, 2) stop mirroring this repository into Diffusion.

It was actually assigned to the correct account, but a spam user changed it here: https://phabricator.wikimedia.org/diffusion/identity/view/33242/ which wasn't reverted unfortunately, probably because it is pretty obscure and doesn't show up on the accounts activity.

Note you can use Phabricator's identities page: https://phabricator.wikimedia.org/diffusion/identity/, in order to fix these types of issues.

Thanks for the quick fix & explanation, @Dylsss, much appreciated! 👍 Never in a million years would I have thought the problem to be something like that, wow!

How bizarre, thanks a lot @Dylsss!

Incorrectly attributed as the author of a random commit I have nothing to do with in a repository I've never touchedClosed, ResolvedPublicBUG REPORTActions

Description

Related Objects

Event Timeline

Incorrectly attributed as the author of a random commit I have nothing to do with in a repository I've never touched
Closed, ResolvedPublicBUG REPORT
Actions