Page MenuHomePhabricator

[Regression] "Save" button in preferences should be always available
Closed, ResolvedPublic



In preferences the Save button used to be pinned to the bottom of the screen, so right after you made your preference change you could hit Save. Currently you have to scroll down to the bottom of the page in order to get to Save.

CurrentlyWhat it should be
Screen Shot 2023-01-16 at 9.09.31 AM.png (891×1 px, 401 KB)
Screen Shot 2023-01-16 at 9.10.37 AM.png (846×1 px, 387 KB)

Event Timeline

I managed to chase down T324227 in December 2022 which removed the sticky positioning and tagging the moderator tools teams to weigh in. @Samwalton9 @jsn.sherman was this intentional?

We didn't intend to change anything about the desktop experience here, so I think this was a mistake.

Definitely not intentional; I can see where I dropped the style in a way that impacted the core experience; It should be a straightforward fix, so I'll get a patch up tomorrow.

jsn.sherman changed the task status from Open to In Progress.Jan 27 2023, 3:37 PM
jsn.sherman claimed this task.
jsn.sherman moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.

Change 884346 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/core@master] Special:Preferences: fix "Save" button regression

Test wiki created on Patch demo by JSherman (WMF) using patch(es) linked to this task:

I'm not sure why this css was dropped, as its presence does not seem to impact the mobile view in any way. You can check the change in the patchdemo here:

Thanks @Jdlrobson for identifying the cause and @matmarex for the review; apologies for introducing the regression!

Change 884346 merged by jenkins-bot:

[mediawiki/core@master] Special:Preferences: fix "Save" button regression

Looks to be resolved.