| • alexhollender_WMF | |
| Jan 16 2023, 6:55 PM |
| F36264602: Screen Shot 2023-01-16 at 9.10.37 AM.png | |
| Jan 16 2023, 6:55 PM |
| F36264601: Screen Shot 2023-01-16 at 9.09.31 AM.png | |
| Jan 16 2023, 6:55 PM |
In preferences the Save button used to be pinned to the bottom of the screen, so right after you made your preference change you could hit Save. Currently you have to scroll down to the bottom of the page in order to get to Save.
| Currently | What it should be |
|---|---|
 |  |
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/core | master | +14 -0 | Special:Preferences: fix "Save" button regression |
I managed to chase down T324227 in December 2022 which removed the sticky positioning and tagging the moderator tools teams to weigh in. @Samwalton9 @jsn.sherman was this intentional?
We didn't intend to change anything about the desktop experience here, so I think this was a mistake.
Definitely not intentional; I can see where I dropped the style in a way that impacted the core experience; It should be a straightforward fix, so I'll get a patch up tomorrow.
Change 884346 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):
[mediawiki/core@master] Special:Preferences: fix "Save" button regression
Test wiki created on Patch demo by JSherman (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/715a50d92d/w
I'm not sure why this css was dropped, as its presence does not seem to impact the mobile view in any way. You can check the change in the patchdemo here:
https://patchdemo.wmflabs.org/wikis/715a50d92d/w/index.php?title=Special:Preferences
Thanks @Jdlrobson for identifying the cause and @matmarex for the review; apologies for introducing the regression!
Change 884346 merged by jenkins-bot:
[mediawiki/core@master] Special:Preferences: fix "Save" button regression