Page MenuHomePhabricator
Create Task
Maniphest T327275

Create and use an error type for timeouts
Closed, ResolvedPublic
Actions

Description

Description

We need a Z5XX for timeouts!

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • timeout ZID will be defined in function-schemata
  • this ZID will be used to generate errors in function-evaluator and function-orchestrator

Remove all the non-applicable tags from the "Tags" field, leave only the tags of the projects/repositories related to this task

Completion checklist

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update function-schemata sub-module to HEAD (905e95a)mediawiki/extensions/WikiLambdamaster+1 -1
wikifunctions: Switch Python evaluator to 2023-11-29-143341 (try 3)operations/deployment-chartsmaster+1 -1
wikifunctions: Switch JavaScript evaluator to 2023-11-29-143341operations/deployment-chartsmaster+1 -1
wikifunctions: Switch Python evaluator to 2023-11-29-143341operations/deployment-chartsmaster+1 -1
wikifunctions: Switch orchestrator to 2023-11-29-152839operations/deployment-chartsmaster+1 -1
Update function-schemata sub-module to HEAD (d2ea9bf)mediawiki/extensions/WikiLambdamaster+1 -1
Customize query in gerrit
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Update function-schemata sub-module to HEAD (905e95a)repos/abstract-wiki/wikifunctions/wikilambda-cli!21dmartinsync-function-schematamain
Update function-schemata sub-module to HEAD (905e95a)repos/abstract-wiki/wikifunctions/function-orchestrator!100dmartinsync-function-schematamain
Update an error to use Z574/Orchestrator time limitrepos/abstract-wiki/wikifunctions/function-orchestrator!99dmartinT327275main
Update an error to use Z575/Evaluator time limitrepos/abstract-wiki/wikifunctions/function-evaluator!119dmartinT327275main
definitions: Correct ZID and key names in Z574 and Z575repos/abstract-wiki/wikifunctions/function-schemata!58dmartinT327275-2main
Update function-schemata sub-module to HEAD (d2ea9bf)repos/abstract-wiki/wikifunctions/function-orchestrator!96jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (d2ea9bf)repos/abstract-wiki/wikifunctions/function-evaluator!118jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (d2ea9bf)repos/abstract-wiki/wikifunctions/wikilambda-cli!20jforrestersync-function-schematamain
Add error types: orchestrator_time_limit and evaluator_time_limitrepos/abstract-wiki/wikifunctions/function-schemata!56dmartinT327275main
Customize query in GitLab

Related Objects
Search...

Event Timeline

cmassaro created this task.Jan 18 2023, 12:55 PM
Jdforrester-WMF added a parent task: T321114: Don't create generic errors in the orchestrator, but specific custom ones.Jan 23 2023, 8:09 PM
DVrandecic moved this task from To Triage to Phase θ – Throttling on the Abstract Wikipedia team board.Jan 24 2023, 7:34 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Ready: Errors on the Abstract Wikipedia team (Phase θ – Throttling) board.Jan 24 2023, 7:40 PM
Jdforrester-WMF moved this task from Phase θ – Throttling to To triage: Nice-to-haves on the Abstract Wikipedia team board.Jun 16 2023, 8:59 AM
Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase θ – Throttling).
Jdforrester-WMF triaged this task as Medium priority.Oct 23 2023, 6:25 PM
Jdforrester-WMF mentioned this in T349557: Clean up the evaluator/executor interfaces once we've simplified into WASM everywhere.Oct 23 2023, 8:33 PM
Jdforrester-WMF changed the task status from Open to In Progress.Nov 20 2023, 7:18 PM
Jdforrester-WMF assigned this task to DMartin-WMF.
Jdforrester-WMF moved this task from To triage: Nice-to-haves to In Progress on the Abstract Wikipedia team board.
CodeReviewBot added a project: Patch-For-Review.Nov 22 2023, 5:10 PM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/56

Add error types: orchestrator_time_limit and evaluator_time_limit

CodeReviewBot added a comment.Nov 27 2023, 3:17 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/56

Add error types: orchestrator_time_limit and evaluator_time_limit

Maintenance_bot removed a project: Patch-For-Review.Nov 27 2023, 3:30 PM
CodeReviewBot added a project: Patch-For-Review.Nov 27 2023, 7:11 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/20

Update function-schemata sub-module to HEAD (d2ea9bf)

CodeReviewBot added a comment.Nov 27 2023, 7:11 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/118

Update function-schemata sub-module to HEAD (d2ea9bf)

gerritbot added a comment.Nov 27 2023, 7:12 PM

Change 977776 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (d2ea9bf)

https://gerrit.wikimedia.org/r/977776

CodeReviewBot added a comment.Nov 27 2023, 7:12 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/96

Update function-schemata sub-module to HEAD (d2ea9bf)

CodeReviewBot added a comment.Nov 27 2023, 7:30 PM

dmartin merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/96

Update function-schemata sub-module to HEAD (d2ea9bf)

CodeReviewBot added a comment.Nov 27 2023, 7:30 PM

dmartin merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/118

Update function-schemata sub-module to HEAD (d2ea9bf)

CodeReviewBot added a comment.Nov 27 2023, 7:31 PM

dmartin merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/20

Update function-schemata sub-module to HEAD (d2ea9bf)

CodeReviewBot added a comment.Nov 28 2023, 3:12 AM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/58

Correct ZID and key names in Z574.json and Z575.json

CodeReviewBot added a comment.Nov 28 2023, 3:21 AM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/119

Update an error to use Z575/Evaluator time limit

CodeReviewBot added a comment.Nov 28 2023, 3:41 AM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/99

Update an error to use Z574/Orchestrator time limit

CodeReviewBot added a comment.Nov 28 2023, 2:22 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/58

definitions: Correct ZID and key names in Z574 and Z575

CodeReviewBot added a comment.Nov 28 2023, 5:05 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/99

Update an error to use Z574/Orchestrator time limit

CodeReviewBot added a comment.Nov 28 2023, 5:05 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/119

Update an error to use Z575/Evaluator time limit

gerritbot added a comment.Nov 28 2023, 7:45 PM

Change 978130 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (905e95a)

https://gerrit.wikimedia.org/r/978130

CodeReviewBot added a comment.Nov 28 2023, 7:46 PM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/120

Update function-schemata sub-module to HEAD (905e95a)

CodeReviewBot added a comment.Nov 28 2023, 7:46 PM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/100

Update function-schemata sub-module to HEAD (905e95a)

CodeReviewBot added a comment.Nov 28 2023, 7:47 PM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/21

Update function-schemata sub-module to HEAD (905e95a)

CodeReviewBot added a comment.Nov 28 2023, 8:14 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/21

Update function-schemata sub-module to HEAD (905e95a)

CodeReviewBot added a comment.Nov 28 2023, 8:15 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/120

Update function-schemata sub-module to HEAD (905e95a)

CodeReviewBot added a comment.Nov 28 2023, 8:28 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/100

Update function-schemata sub-module to HEAD (905e95a)

gerritbot added a comment.Nov 28 2023, 8:29 PM

Change 977776 abandoned by Jforrester:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (d2ea9bf)

Reason:

https://gerrit.wikimedia.org/r/977776

gerritbot added a comment.Nov 29 2023, 1:29 PM

Change 978536 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (a67fdcb)

https://gerrit.wikimedia.org/r/978536

Jdforrester-WMF moved this task from In Progress to To deploy on the Abstract Wikipedia team board.Nov 29 2023, 5:43 PM
gerritbot added a comment.Nov 29 2023, 6:52 PM

Change 978671 had a related patch set uploaded (by Jforrester; author: Cory Massaro):

[operations/deployment-charts@master] wikifunctions: Switch orchestrator to 2023-11-29-152839

https://gerrit.wikimedia.org/r/978671

gerritbot added a comment.Nov 29 2023, 6:55 PM

Change 978671 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Switch orchestrator to 2023-11-29-152839

https://gerrit.wikimedia.org/r/978671

gerritbot added a comment.Nov 29 2023, 7:03 PM

Change 976847 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Switch Python evaluator to 2023-11-29-143341

https://gerrit.wikimedia.org/r/976847

gerritbot added a comment.Nov 29 2023, 7:05 PM

Change 976847 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Switch Python evaluator to 2023-11-29-143341

https://gerrit.wikimedia.org/r/976847

gerritbot added a comment.Nov 29 2023, 7:18 PM

Change 978678 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Switch JavaScript evaluator to 2023-11-29-143341

https://gerrit.wikimedia.org/r/978678

gerritbot added a comment.Nov 29 2023, 7:20 PM

Change 978678 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Switch JavaScript evaluator to 2023-11-29-143341

https://gerrit.wikimedia.org/r/978678

gerritbot added a comment.Nov 29 2023, 8:44 PM

Change 978130 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (905e95a)

https://gerrit.wikimedia.org/r/978130

gerritbot added a comment.Nov 29 2023, 8:54 PM

Change 978514 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Switch Python evaluator to 2023-11-29-143341 (try 3)

https://gerrit.wikimedia.org/r/978514

gerritbot added a comment.Nov 29 2023, 8:57 PM

Change 978514 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Switch Python evaluator to 2023-11-29-143341 (try 3)

https://gerrit.wikimedia.org/r/978514

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.9; 2023-12-12).Nov 29 2023, 9:00 PM
Jdforrester-WMF closed this task as Resolved.Dec 11 2023, 4:29 PM
Jdforrester-WMF moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.
DMartin-WMF mentioned this in rMSFE0c0f6dc11b7e: Update function-schemata sub-module to HEAD (d2ea9bf).Oct 3 2025, 9:39 AM
cmassaro mentioned this in rMSFE98152d2d06bf: Update an error to use Z575/Evaluator time limit.Oct 3 2025, 9:39 AM
Jdforrester-WMF mentioned this in rMSFEc7ae92ffb377: Update function-schemata sub-module to HEAD (905e95a).Oct 3 2025, 9:39 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits