Page MenuHomePhabricator

Edits made to articles where the title is only a number return wrong results in the new impact module.
Closed, ResolvedPublicBUG REPORT

Description

A newcomer who edited https://es.wikipedia.org/wiki/1600 gets in their impact module:

Capture d’écran_2023-01-18_15-08-59.png (218×380 px, 25 KB)

I edited the same article, using my volunteer account, with the same result:

Capture d’écran_2023-01-18_15-24-33.png (417×521 px, 53 KB)

"0" redirects to https://es.wikipedia.org/wiki/0, and "1" to the article "1".

It does happen for random numbers (tested with https://fr.wikipedia.org/wiki/1574).
It doesn't happen when the title is numbers followed by text (tested here with https://fr.wikipedia.org/wiki/1500 and https://fr.wikipedia.org/wiki/1500_en_science):

Capture d’écran_2023-01-18_15-32-51.png (540×603 px, 73 KB)

This problem is not on the old impact module (tested with a new test account, on https://fr.wikipedia.org/wiki/1700):

20220427_193946-0506f.jpg (299×603 px, 58 KB)

Event Timeline

kostajh triaged this task as Medium priority.Jan 18 2023, 6:17 PM
kostajh changed the subtype of this task from "Task" to "Bug Report".

Thanks, @Trizek-WMF - the issue is confirmed in betalabs.

  1. Import an article, e.g. 1600 (was imported from cawikito enwiki betalabs)
  2. A new user (with zero number of edits ET18oct01) edits 1600. The user made only one edit.
  3. The Impact module will go from zero edits to 1 edit.
Screen Shot 2023-01-18 at 12.28.34 PM.png (866×1 px, 150 KB)
Screen Shot 2023-01-18 at 12.29.40 PM.png (1×1 px, 113 KB)

The bug:

  • the pageview count displays two edits attributed to the wrong articles
  • the page links go to the articles that a user never edited. In my example, 0 -> to non-existing article; 1 -> 1 with no edits from a test user.

Checked other types of titles with numerals - look ok:

Screen Shot 2023-01-18 at 12.44.44 PM.png (1×1 px, 101 KB)

Change 881494 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] User impact: avoid removing keys in article associative arrays

https://gerrit.wikimedia.org/r/881494

Change 881494 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] User impact: avoid removing keys in article associative arrays

https://gerrit.wikimedia.org/r/881494

Checked testwiki wmf.22 and eswiki wmf.21 - the issue is fixed:

Screen Shot 2023-02-07 at 4.08.22 PM.png (512×331 px, 39 KB)
Screen Shot 2023-02-07 at 4.04.43 PM.png (393×1 px, 42 KB)