Page MenuHomePhabricator
Create Task
Maniphest T327291

Edits made to articles where the title is only a number return wrong results in the new impact module.
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
Sgs
Authored By
Trizek-WMF
Jan 18 2023, 2:46 PM
Tags
Referenced Files
F36802123: Screen Shot 2023-02-07 at 4.04.43 PM.png
Feb 8 2023, 12:10 AM
F36802121: Screen Shot 2023-02-07 at 4.08.22 PM.png
Feb 8 2023, 12:10 AM
F36318171: Screen Shot 2023-01-18 at 12.44.44 PM.png
Jan 18 2023, 8:47 PM
F36318129: Screen Shot 2023-01-18 at 12.29.40 PM.png
Jan 18 2023, 8:39 PM
F36318127: Screen Shot 2023-01-18 at 12.28.34 PM.png
Jan 18 2023, 8:39 PM
F36293567: 20220427_193946-0506f.jpg
Jan 18 2023, 2:46 PM
F36293548: Capture d’écran_2023-01-18_15-32-51.png
Jan 18 2023, 2:46 PM
F36293537: Capture d’écran_2023-01-18_15-24-33.png
Jan 18 2023, 2:46 PM
View All 9 Files
Subscribers
Aklapper
Etonkovidova
IZapico-WMF
Trizek-WMF

Description

A newcomer who edited https://es.wikipedia.org/wiki/1600 gets in their impact module:

Capture d’écran_2023-01-18_15-08-59.png (218×380 px, 25 KB)

I edited the same article, using my volunteer account, with the same result:

Capture d’écran_2023-01-18_15-24-33.png (417×521 px, 53 KB)

"0" redirects to https://es.wikipedia.org/wiki/0, and "1" to the article "1".

It does happen for random numbers (tested with https://fr.wikipedia.org/wiki/1574).
It doesn't happen when the title is numbers followed by text (tested here with https://fr.wikipedia.org/wiki/1500 and https://fr.wikipedia.org/wiki/1500_en_science):

Capture d’écran_2023-01-18_15-32-51.png (540×603 px, 73 KB)

This problem is not on the old impact module (tested with a new test account, on https://fr.wikipedia.org/wiki/1700):

20220427_193946-0506f.jpg (299×603 px, 58 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
User impact: avoid removing keys in article associative arraysmediawiki/extensions/GrowthExperimentsmaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Trizek-WMF created this task.Jan 18 2023, 2:46 PM
Trizek-WMF attached a referenced file: F36293522: Capture d’écran_2023-01-18_15-08-59.png. (Show Details)Jan 18 2023, 6:11 PM
kostajh triaged this task as Medium priority.Jan 18 2023, 6:17 PM
kostajh changed the subtype of this task from "Task" to "Bug Report".
kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
MShilova_WMF moved this task from Ready for Development to Top Product Priorities on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 18 2023, 6:20 PM
MShilova_WMF added a parent task: T222310: [EPIC] Positive reinforcement: New Impact Module.
Trizek-WMF added a comment.Jan 18 2023, 6:32 PM

Sergio says it might be related to T324741: NewImpact: Some titles do not display correctly (or be a duplicate).

Etonkovidova subscribed.Jan 18 2023, 8:39 PM

Thanks, @Trizek-WMF - the issue is confirmed in betalabs.

  1. Import an article, e.g. 1600 (was imported from cawikito enwiki betalabs)
  2. A new user (with zero number of edits ET18oct01) edits 1600. The user made only one edit.
  3. The Impact module will go from zero edits to 1 edit.
Screen Shot 2023-01-18 at 12.28.34 PM.png (866×1 px, 150 KB)
Screen Shot 2023-01-18 at 12.29.40 PM.png (1×1 px, 113 KB)

The bug:

  • the pageview count displays two edits attributed to the wrong articles
  • the page links go to the articles that a user never edited. In my example, 0 -> to non-existing article; 1 -> 1 with no edits from a test user.
Etonkovidova added a comment.Jan 18 2023, 8:47 PM

Checked other types of titles with numerals - look ok:

Screen Shot 2023-01-18 at 12.44.44 PM.png (1×1 px, 101 KB)

Etonkovidova mentioned this in T324741: NewImpact: Some titles do not display correctly.Jan 18 2023, 9:22 PM
gerritbot added a comment.Jan 19 2023, 3:23 AM

Change 881494 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] User impact: avoid removing keys in article associative arrays

https://gerrit.wikimedia.org/r/881494

gerritbot added a project: Patch-For-Review.Jan 19 2023, 3:23 AM
Sgs claimed this task.Jan 19 2023, 3:31 AM
Sgs moved this task from Top Product Priorities to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
• Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 19 2023, 8:09 AM
gerritbot added a comment.Jan 19 2023, 8:29 AM

Change 881494 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] User impact: avoid removing keys in article associative arrays

https://gerrit.wikimedia.org/r/881494

Maintenance_bot removed a project: Patch-For-Review.Jan 19 2023, 8:30 AM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.20; 2023-01-23).Jan 19 2023, 9:00 AM
Etonkovidova closed this task as Resolved.Feb 8 2023, 12:10 AM

Checked testwiki wmf.22 and eswiki wmf.21 - the issue is fixed:

Screen Shot 2023-02-07 at 4.08.22 PM.png (512×331 px, 39 KB)
Screen Shot 2023-02-07 at 4.04.43 PM.png (393×1 px, 42 KB)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits