Page MenuHomePhabricator

Ensure that evaluator metadata elements are checked in testing
Closed, ResolvedPublic

Description

Description

In mswTestRunner.js, we check for the presence of metadata elements inserted by orchestrator code. We should similarly check for metadata elements inserted by evaluator code.

Most (but not necessarily all) of the required checks can be provided in integrationTest.js by

  • Declaring standardMetaData
  • Adding arguments expectedExtraMetadata and expectedMissingMetadata to evaluatorIntegrationTest
  • Adding code to evaluatorIntegrationTest to check for the presence of metadata elements, probably in the code block starting with if ( expectedOutput !== null )
  • Updating calls to evaluatorIntegrationTest as needed.

The above can mimic what's present in orchestrator code mswTestRunner.js.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • See above

Completion checklist

Details

ReferenceSource BranchDest BranchAuthorTitle
repos/abstract-wiki/wikifunctions/function-evaluator!20T327326maindmartinAdd metadata checks to evaluatorIntegrationTest()
Customize query in GitLab

Event Timeline