Page MenuHomePhabricator
Create Task
Maniphest T327328

Highlight skips the topic container for new topics, which looks odd
Closed, ResolvedPublic
Actions

Description

When you add a new topic in DiscussionTools, it shouldn't look like this:

Screen shot 2023-01-18 topic container highlight.png (764×2 px, 178 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Tweaks for new heading HTML structuremediawiki/extensions/DiscussionToolswmf/1.40.0-wmf.19+28 -2
Tweaks for new heading HTML structuremediawiki/extensions/DiscussionToolsmaster+28 -2
Customize query in gerrit

Related Objects

Event Timeline

• Whatamidoing-WMF created this task.Jan 18 2023, 6:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 18 2023, 6:53 PM
ppelberg added a project: Editing-team (Kanban Board).Jan 18 2023, 11:04 PM
ppelberg moved this task from Inbox to Ready to Be Worked On on the Editing-team (Kanban Board) board.
Tacsipacsi subscribed.Jan 19 2023, 2:30 AM

A regression from T314714: Metadata and buttons should be inserted after a heading, not inside of it?

ppelberg renamed this task from Highlight skips the topic container for new topics, which looks od to Highlight skips the topic container for new topics, which looks odd.Jan 19 2023, 6:09 PM
matmarex claimed this task.Jan 20 2023, 4:23 AM
matmarex subscribed.

Likely.

gerritbot added a comment.Jan 20 2023, 5:24 AM

Change 881747 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Tweaks for new heading HTML structure

https://gerrit.wikimedia.org/r/881747

gerritbot added a project: Patch-For-Review.Jan 20 2023, 5:24 AM
matmarex moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.Jan 20 2023, 5:27 AM

I realized that the heading HTML structure changes also affected the styling of the first-time subscription notification popup, which became bold (like the heading). This is also fixed.

Before
2023-01-20 06_01_30-Talk_Scratch - Testwiki - Opera.png (2×3 px, 1 MB)
After
2023-01-20 06_19_46-Talk_Scratch - Testwiki - Opera.png (2×3 px, 1 MB)
gerritbot added a comment.Jan 20 2023, 12:50 PM

Change 881747 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Tweaks for new heading HTML structure

https://gerrit.wikimedia.org/r/881747

Maintenance_bot removed a project: Patch-For-Review.Jan 20 2023, 1:31 PM
gerritbot added a comment.Jan 22 2023, 6:52 PM

Change 882174 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.19] Tweaks for new heading HTML structure

https://gerrit.wikimedia.org/r/882174

gerritbot added a project: Patch-For-Review.Jan 22 2023, 6:52 PM
gerritbot added a comment.Jan 23 2023, 8:12 AM

Change 882174 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.19] Tweaks for new heading HTML structure

https://gerrit.wikimedia.org/r/882174

Stashbot mentioned this in T327469: Subscribe buttons/links are displayed out of place due to new heading HTML structure.Jan 23 2023, 8:12 AM

Mentioned in SAL (#wikimedia-operations) [2023-01-23T08:12:47Z] <ladsgroup@deploy1002> Started scap: Backport for [[gerrit:882174|Tweaks for new heading HTML structure (T327328 T327469)]]

Stashbot added a comment.Jan 23 2023, 8:22 AM

Mentioned in SAL (#wikimedia-operations) [2023-01-23T08:22:33Z] <ladsgroup@deploy1002> ladsgroup and matmarex: Backport for [[gerrit:882174|Tweaks for new heading HTML structure (T327328 T327469)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet

Stashbot added a comment.Jan 23 2023, 8:30 AM

Mentioned in SAL (#wikimedia-operations) [2023-01-23T08:30:00Z] <ladsgroup@deploy1002> Finished scap: Backport for [[gerrit:882174|Tweaks for new heading HTML structure (T327328 T327469)]] (duration: 17m 12s)

Maintenance_bot removed a project: Patch-For-Review.Jan 23 2023, 8:30 AM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Jan 23 2023, 9:10 AM
matmarex added a project: Editing QA.
ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Jan 26 2023, 4:27 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Feb 7 2023, 9:27 PM
Ryasmeen edited projects, added Verified; removed Editing QA.
ppelberg closed this task as Resolved.Feb 13 2023, 4:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits