Page MenuHomePhabricator

Horizontal scrolling when content contains extra wide elements when limited width is disabled and page tools is enabled
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

Context: https://wikimedia.slack.com/archives/G8QAPHCTT/p1674146318793809

What happens?:
{F36338040}

What should have happened instead?:
The content should be full width like other pages

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Additional QA steps (previously T327886)

  • edit a random article on English Wikipedia adding a long string of characters/letters without spaces e.g.
longwordongwordongwordongwordongwordongwordongwordlongwordongwordongwordongwordongwordongwordongwordlongwordongwordongwordongwordongwordongwordongwordlongwordongwordongwordongwordongwordongwordongwordlongwordongwordongwordongwordongwordongwordongword
  • then preview

Expected: Should not break display.

QA Results - Prod

ACStatusDetails
1T327423#8586909

Event Timeline

Change 881671 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Fix grid blowout with limited width turned off

https://gerrit.wikimedia.org/r/881671

Change 881612 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/skins/Vector@wmf/1.40.0-wmf.19] Fix grid blowout with limited width turned off

https://gerrit.wikimedia.org/r/881612

Change 881612 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.40.0-wmf.19] Fix grid blowout with limited width turned off

https://gerrit.wikimedia.org/r/881612

Mentioned in SAL (#wikimedia-operations) [2023-01-19T21:18:51Z] <jdrewniak@deploy1002> Started scap: Backport for [[gerrit:881612|Fix grid blowout with limited width turned off (T327423)]]

Mentioned in SAL (#wikimedia-operations) [2023-01-19T21:20:39Z] <jdrewniak@deploy1002> jdlrobson and jdrewniak: Backport for [[gerrit:881612|Fix grid blowout with limited width turned off (T327423)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-01-19T21:27:17Z] <jdrewniak@deploy1002> Finished scap: Backport for [[gerrit:881612|Fix grid blowout with limited width turned off (T327423)]] (duration: 08m 26s)

Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Go to https://en.wikipedia.org/wiki/Venice?vectorpagetools=1
click the limited width toggle button
✅ AC1: The content should be full width like other pages

Screenshot 2023-01-22 at 7.06.49 PM.png (930×1 px, 588 KB)

Screenshot 2023-01-22 at 7.07.25 PM.png (929×1 px, 535 KB)

Screenshot 2023-01-22 at 7.07.12 PM.png (927×1 px, 630 KB)

Screenshot 2023-01-22 at 7.06.38 PM.png (892×1 px, 594 KB)

Screenshot 2023-01-22 at 7.06.13 PM.png (934×1 px, 635 KB)

Looks good, resolving

Change 881671 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fix grid blowout with limited width turned off

https://gerrit.wikimedia.org/r/881671

Change 884930 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/skins/Vector@wmf/1.40.0-wmf.20] Fix grid blowout with limited width turned off

https://gerrit.wikimedia.org/r/884930

Jdlrobson subscribed.

This wasn't backported to wmf20.

ovasileva triaged this task as High priority.
ovasileva set the point value for this task to 2.
ovasileva moved this task from Incoming to Doing on the Web-Team FY2022-23 Q3 Sprint 2 board.
ovasileva subscribed.

Change 884930 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.40.0-wmf.20] Fix grid blowout with limited width turned off

https://gerrit.wikimedia.org/r/884930

Mentioned in SAL (#wikimedia-operations) [2023-01-30T21:21:48Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:883301|Enable WelcomeSurvey at viwiki (T325376)]], [[gerrit:884930|Fix grid blowout with limited width turned off (T327423)]], [[gerrit:884929|Support new style of table of contents (T327942)]]

Mentioned in SAL (#wikimedia-operations) [2023-01-30T21:23:27Z] <urbanecm@deploy1002> tgr and urbanecm and jdlrobson and legoktm: Backport for [[gerrit:883301|Enable WelcomeSurvey at viwiki (T325376)]], [[gerrit:884930|Fix grid blowout with limited width turned off (T327423)]], [[gerrit:884929|Support new style of table of contents (T327942)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-01-30T21:31:41Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:883301|Enable WelcomeSurvey at viwiki (T325376)]], [[gerrit:884930|Fix grid blowout with limited width turned off (T327423)]], [[gerrit:884929|Support new style of table of contents (T327942)]] (duration: 09m 52s)

Edtadros moved this task from QA to Ready for Signoff on the Web-Team FY2022-23 Q3 Sprint 2 board.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Go to https://en.wikipedia.org/wiki/Venice?vectorpagetools=1
click the limited width toggle button
✅ AC1: The content should be full width like other pages

Screenshot 2023-02-03 at 6.54.10 PM.png (967×2 px, 700 KB)

Screenshot 2023-02-03 at 6.50.41 PM.png (965×2 px, 841 KB)

Screenshot 2023-02-03 at 6.53.56 PM.png (968×2 px, 687 KB)

Screenshot 2023-02-03 at 6.53.34 PM.png (970×2 px, 1 MB)

Looks good, resolving