Firefox print shows the Contents floating panel
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	TheDJ
	Jan 19 2023, 9:10 PM

Description

Steps to replicate the issue (include links if applicable):

Use Firefox
Go to a narrow window
The ToC get collapsed
Choose print preview

What happens?:

Screenshot 2023-01-19 at 22.07.20.png (1×1 px, 325 KB)

This is actually the floating vector menu of the ToC, which is showing.

Screenshot 2023-01-19 at 22.07.47.png (1×1 px, 301 KB)

What should have happened instead?:
The ToC should have been hidden, like it is in wider settings. Especially FF seems to print in a very narrow viewport somehow.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

QA Results - Beta

AC	Status	Details
1	✅	T327448#8567003

QA Results - Prod

AC	Status	Details
1	✅	T327448#8576640

Details

	Subject	Repo	Branch	Lines +/-
	Print: Hide table of contents and nav menus in print	mediawiki/skins/Vector	master	+6 -1

Customize query in gerrit

Event Timeline

TheDJ created this task.Jan 19 2023, 9:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 19 2023, 9:10 PM

Phuzion subscribed.Jan 19 2023, 9:10 PM

Change 884031 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Print: Hide table of contents and nav menus in print

https://gerrit.wikimedia.org/r/884031

gerritbot added a project: Patch-For-Review.Jan 26 2023, 4:37 PM

Jdlrobson moved this task from Incoming to Sprint 1 (non-milestone) on the Web-Team-Backlog-Archived board.Jan 26 2023, 6:03 PM

Jdlrobson added a project: Web-Team FY2022-23 Q3 Sprint 1.

LGoto triaged this task as Medium priority.Jan 26 2023, 6:31 PM

LGoto set the point value for this task to 2.

LGoto moved this task from Incoming to Ready for Development on the Web-Team FY2022-23 Q3 Sprint 1 board.

Jdlrobson moved this task from Ready for Development to Code Review on the Web-Team FY2022-23 Q3 Sprint 1 board.Jan 26 2023, 6:49 PM

Jdlrobson moved this task from Incoming to Table of Contents on the Desktop Improvements (Vector 2022) board.Jan 26 2023, 8:21 PM

• nray claimed this task.Jan 26 2023, 10:01 PM

Change 884031 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Print: Hide table of contents and nav menus in print

https://gerrit.wikimedia.org/r/884031

Maintenance_bot removed a project: Patch-For-Review.Jan 26 2023, 11:30 PM

• nray removed • nray as the assignee of this task.Jan 26 2023, 11:56 PM

• nray moved this task from Code Review to QA on the Web-Team FY2022-23 Q3 Sprint 1 board.

• nray subscribed.

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.21; 2023-01-30).Jan 27 2023, 12:00 AM

TheDJ awarded a token.Jan 27 2023, 12:11 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Use Firefox
Go to a narrow window
The ToC get collapsed
Choose print preview
✅ AC1: The ToC should have been hidden, like it is in wider settings.

Screenshot 2023-01-28 at 4.51.21 PM.png (1×863 px, 334 KB)

Edtadros claimed this task.Jan 29 2023, 12:53 AM

Test Result - Prod

Status: ✅ PASS
Environment: testwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Use Firefox
Go to a narrow window
The ToC get collapsed
Choose print preview
✅ AC1: The ToC should have been hidden, like it is in wider settings.

Screenshot 2023-01-31 at 3.10.53 PM.png (760×879 px, 301 KB)

Edtadros updated the task description. (Show Details)Jan 31 2023, 11:13 PM

ovasileva closed this task as Resolved.Feb 3 2023, 3:52 PM

	F36571454: Screenshot 2023-01-31 at 3.10.53 PM.png
	Jan 31 2023, 11:11 PM

	F36544382: Screenshot 2023-01-28 at 4.51.21 PM.png
	Jan 29 2023, 12:53 AM

	F36339592: Screenshot 2023-01-19 at 22.07.47.png
	Jan 19 2023, 9:10 PM

	F36339589: Screenshot 2023-01-19 at 22.07.20.png
	Jan 19 2023, 9:10 PM

Firefox print shows the Contents floating panelClosed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions

Description

QA Results - Beta

QA Results - Prod

Details

Event Timeline

Test Result - Beta

QA Steps

Test Result - Prod

QA Steps

Firefox print shows the Contents floating panel
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions