Page MenuHomePhabricator

Standardize info icon size and RTL alternative graphic
Open, MediumPublic

Description

Per discussion in T310665: Impact module: summary panel, specifically brought by @Etonkovidova in T310665#8426469 the information icons shown across GrowthExperiments extension have discrepancies in size and behavior for arwiki and other languages where a light bulb graphic is shown instead of a latin character (i). This problem can be seen in both newcomers homepage and the mentor dashboard.

Homepage ArabicMentor dashboard Arabic
Screen Shot 2022-11-28 at 12.47.13 PM.png (1×2 px, 291 KB)
Screenshot 2023-01-19 at 17.15.27.png (2×2 px, 406 KB)

This is due to the use of two different source icons, ìnfo-unpadded and CdxInfo.

Proposed solution
Use OOUI's ìnfo and adjust styles if needed

Acceptance criteria

  • All information icons use the light bulb graphic in Arabic
  • Icons with the same semantics use the same color palette and sizing
    • Clickable icons have a defined size for its clickable area (eg: Button type=quiet)
    • Enabled icon-only buttons have a defined color
    • Disabled icon-only buttons have a defined color
  • DRAFT: Icons size adapt to the platform desktop/mobile
  • Create a CSS utility or LESS mixin to make it easy to match icons from both libraries on the same page

Notes
Since it seems we mostly use "icon only" buttons as inline help for a particular line or lines of text I wonder if the size should be defined relative to the font-size. That wouldn't solve the size discrepancies still but would align them with the font-size discrepancies we have, eg: T312245: Adjust small font size on the Homepage and Mentor dashboard.
Since we are mixing OOUI and Codex icons it would be convenient to create some styles that help us display both types of icons in a consistent way.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 877167 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] WIP use standard info icon instead of info-unpadded

https://gerrit.wikimedia.org/r/877167

Sgs added a subscriber: RHo.

@RHo could you help clarify the icon sizes and color specification? Would it make any sense to have some rule for sizing icons relative to fonts size?

@RHo could you help clarify the icon sizes and color specification? Would it make any sense to have some rule for sizing icons relative to fonts size?

Thanks for filing this @Sgs. Agree we should use the standard 20x20px size info icon from OOUI, given the recent update to the icon for Codex and OOUI done on T311382.

A bit of background is that we created our own 'i' icon and had it scaled down to the smaller 16x16px size because the old info icon for tooltips was too tiny and thin, but the standard 20x20px info icon was too big.

That Arabic uses the lightbulb icon instead of info is an interesting one though, because the 20x20px icon is larger than the resized "i" in the info icon. This is an issue everywhere the "i" appears on Arabic which should be looked at DS team to resize the ar version of info to be smaller. I filed this in T327509.

Codex icons
image.png (368×1 px, 44 KB)
Example of ar "info" icon
image.png (408×792 px, 34 KB)
vs enwiki
image.png (362×840 px, 34 KB)

@Sgs - Given that a follow up task was created for DST (T327509: Arabic version of info icons should be resized to be smaller like the other language version of info icon), should we mark this task as resolved? Or move it out of the current sprint?

@Dyolf77_WMF, can you confirm that this lightbulb icon is specific to Arabic?

@Dyolf77_WMF, can you confirm that this lightbulb icon is specific to Arabic?

Yes, I confirm that.

Aklapper renamed this task from Standarise info icon size and RTL alternative graphic to Standardize info icon size and RTL alternative graphic.Aug 3 2023, 9:45 AM
Aklapper added a project: RTL.

I'm bolding moving this out of the sprint since it's been idle for so long.
If you disagree with that move, please just add next steps and we can consider moving back into Growth's current sprint.