Page MenuHomePhabricator
Create Task
Maniphest T327515

Remove Realtime Preview's Beta Feature and Onboarding UI
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

To be worked on from March 2023.

Once the new feature has sat inside of production and in front of users outside of Beta for over 6 weeks from 13 January 2023 - this ticket entails cleaning up the Beta code and removing the onboarding UI.

This will involve removing the Beta Feature config variable and related code from WikiEditor. Changes will be needed in three places:

  • WikiEditor
  • integration/config
  • mediawiki-config

The LocalStorage key WikiEditor-RealtimePreview-onboarding-dismissed should be removed (and code left in place to do this, because we didn't implement it with an expiry date).

Details

SubjectRepoBranchLines +/-
Remove WikiEditor's Realtime Preview config varsoperations/mediawiki-configmaster+0 -14
Realtime Preview: enable by defaultmediawiki/extensions/WikiEditormaster+1 -1
Realtime Preview: remove Beta Feature and onboarding popupmediawiki/extensions/WikiEditormaster+10 -262
Customize query in gerrit

Related Objects
Search...

Event Timeline

• NRodriguez created this task.Jan 20 2023, 3:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 20 2023, 3:42 PM
• NRodriguez added a project: Community-Tech (CommTech-Sprint-42).Jan 20 2023, 3:42 PM
Samwilson added a subtask: T326602: Remove Realtime Preview Beta Feature code.Jan 21 2023, 12:00 AM
Samwilson mentioned this in T327116: Realtime preview onboarding popup shouldn't have scrollbars.Jan 21 2023, 12:09 AM
Samwilson mentioned this in T327115: z-index issue when clicking "realtime preview" using vector skin.
Xaosflux subscribed.Feb 7 2023, 2:56 PM

Will this get rid of the continually reoccurring blue dot classed as ext-WikiEditor-realtimepreview-onboarding-dot ?

Samwilson mentioned this in T326602: Remove Realtime Preview Beta Feature code.Feb 7 2023, 11:23 PM
Samwilson merged a task: T326602: Remove Realtime Preview Beta Feature code.Feb 7 2023, 11:43 PM
Samwilson subscribed.
Samwilson renamed this task from Clean up Beta Code and Remove Onboarding UI to Remove Beta Feature and Onboarding UI.Feb 7 2023, 11:47 PM
Samwilson renamed this task from Remove Beta Feature and Onboarding UI to Remove Realtime Preview's Beta Feature and Onboarding UI.
Samwilson updated the task description. (Show Details)
Samwilson set the point value for this task to 2.

Will this get rid of the continually reoccurring blue dot classed as ext-WikiEditor-realtimepreview-onboarding-dot ?

Yes it will.

Samwilson mentioned this in T329118: Pulsing blue ball in preview button on title bar of edit area does not respect "disable animations".Feb 7 2023, 11:59 PM
Samwilson changed the task status from Open to Stalled.Feb 8 2023, 2:25 AM
Samwilson updated the task description. (Show Details)
• JMcLeod_WMF moved this task from Backlog to 🌟Top Priority on the Realtime Preview board.Feb 14 2023, 4:37 PM
gerritbot added a comment.Mar 17 2023, 7:24 AM

Change 900534 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/WikiEditor@master] Realtime Preview: remove Beta Feature and onboarding popup

https://gerrit.wikimedia.org/r/900534

gerritbot added a project: Patch-For-Review.Mar 17 2023, 7:24 AM
Samwilson claimed this task.Mar 17 2023, 7:24 AM
Samwilson moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-42) board.
gerritbot added a comment.Mar 17 2023, 1:52 PM

Change 900534 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Realtime Preview: remove Beta Feature and onboarding popup

https://gerrit.wikimedia.org/r/900534

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.1; 2023-03-20).Mar 17 2023, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 17 2023, 2:10 PM
gerritbot added a comment.Mar 21 2023, 7:43 AM

Change 901505 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/WikiEditor@master] Realtime Preview: enable by default

https://gerrit.wikimedia.org/r/901505

gerritbot added a project: Patch-For-Review.Mar 21 2023, 7:43 AM
Samwilson changed the task status from Stalled to In Progress.Mar 21 2023, 7:43 AM
gerritbot added a comment.Mar 21 2023, 10:20 AM

Change 901505 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Realtime Preview: enable by default

https://gerrit.wikimedia.org/r/901505

Maintenance_bot removed a project: Patch-For-Review.Mar 21 2023, 10:31 AM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.2; 2023-03-27); removed MW-1.41-notes (1.41.0-wmf.1; 2023-03-20).Mar 21 2023, 11:00 AM
gerritbot added a comment.Mar 21 2023, 11:08 AM

Change 901553 had a related patch set uploaded (by Samwilson; author: Samwilson):

[operations/mediawiki-config@master] Remove WikiEditor's Realtime Preview config vars

https://gerrit.wikimedia.org/r/901553

gerritbot added a project: Patch-For-Review.Mar 21 2023, 11:08 AM
• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Kanban); removed Patch-For-Review, MW-1.41-notes (1.41.0-wmf.2; 2023-03-27), Community-Tech (CommTech-Sprint-42), Realtime Preview.Mar 27 2023, 3:46 PM
• JMcLeod_WMF moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Kanban) board.Mar 27 2023, 3:54 PM
• JMcLeod_WMF added projects: Realtime Preview, MW-1.41-notes (1.41.0-wmf.2; 2023-03-27), Patch-For-Review.Mar 27 2023, 4:21 PM
TheresNoTime subscribed.Apr 5 2023, 11:54 AM
gerritbot added a comment.Apr 5 2023, 12:12 PM

Change 901553 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove WikiEditor's Realtime Preview config vars

https://gerrit.wikimedia.org/r/901553

Stashbot added a comment.Apr 5 2023, 12:12 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-05T12:12:26Z] <samtar@deploy2002> Started scap: Backport for [[gerrit:901553|Remove WikiEditor's Realtime Preview config vars (T327515)]]

Stashbot added a comment.Apr 5 2023, 12:13 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-05T12:13:51Z] <samtar@deploy2002> samwilson and samtar: Backport for [[gerrit:901553|Remove WikiEditor's Realtime Preview config vars (T327515)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet

TheresNoTime moved this task from In Development 💻 to QA 🐛 on the Community-Tech (CommTech-Kanban) board.Apr 5 2023, 12:17 PM

(unsure if this needs QA)

Stashbot added a comment.Apr 5 2023, 12:20 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-05T12:20:08Z] <samtar@deploy2002> Finished scap: Backport for [[gerrit:901553|Remove WikiEditor's Realtime Preview config vars (T327515)]] (duration: 07m 41s)

GMikesell-WMF added subscribers: MusikAnimal, GMikesell-WMF.Apr 10 2023, 5:23 PM
In T327515#8758847, @TheresNoTime wrote:

(unsure if this needs QA)

Agreed. After talking with @MusikAnimal, currently, there is nothing broken after the merge since everything has been deployed already and we would have known by now if there was something. I will move this to Done. Thanks!

GMikesell-WMF closed this task as Resolved.Apr 10 2023, 5:23 PM
GMikesell-WMF moved this task from QA 🐛 to Done 🏁 on the Community-Tech (CommTech-Kanban) board.

As mentioned from the last comment.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL