Page MenuHomePhabricator

Watchlist button overlaps when "99+" notifications
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Open an account with "99+" unread blue notifications
  • Click the watchlist icon

What happens?:

The outline that appears on click overlaps the notifications icon. See gif below.

Vector_button_overlap.gif (270×530 px, 127 KB)

Other information (browser name/version, screenshots, etc.):

Chrome 109.0.5414.87 on a MacBook Pro

Note: I will not notice replies to this Phabricator task. Please contact me via Slack if more information is needed.

Event Timeline

In the screen shot, the icon is not being overlapped. There appears to be one pixel of white space between the edge of the blue box and the Watchlist icon.

I saw a similar report somewhere else, and the design looked intentional to me. Someone with 99+ notifications is a true edge case; they can easily handle the notifications, either by marking them read or changing their preferences to reduce the number of notifications they receive.

Power users are asking for more items in the header and sticky header, so it would be counterproductive to spread out these icons even more than they are already separated.

Change 888048 had a related patch set uploaded (by Jdlrobson; author: Esanders):

[mediawiki/skins/Vector@master] Copy over Echo CSS classes required for special case styling

https://gerrit.wikimedia.org/r/888048

ovasileva triaged this task as Medium priority.Mar 15 2023, 4:45 PM
ovasileva moved this task from Not ready to estimate to Current Quarter on the Web-Team-Backlog board.

Change #888048 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] Copy over Echo CSS classes required for special case styling

Reason:

Hello this is an automated message.
I am abandoning this patch as it over a year old, and is not currently in a mergeable state. This has nothing to do with the quality of the patch.

If you still care about this patch, please feel free to restore it and rebase it, and we can happily continue the conversation to help you get it merged.

https://gerrit.wikimedia.org/r/888048

KSarabia-WMF claimed this task.
KSarabia-WMF subscribed.

This seems to have been resolved.

Screenshot 2024-05-22 at 5.20.45 PM.png (188×746 px, 15 KB)

If this is a mistake, please reopen. Thank you.