Toggling collapsible talk page banners on DT-enhanced mobile talk pages causes scrolling
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Tacsipacsi
	Jan 22 2023, 12:32 PM

Description

Steps to reproduce

Open https://en.m.wikipedia.org/wiki/Talk:Doctor_Who?dtenable=1&safemode=1 in a desktop browser.
Click the Learn more about this page link.
Scroll down to the article history template.
Click the [show] link next to Article milestones.

Actual result

The collapsible section is toggled, and it scrolls out of view (you’re taken to the top of the popup).

Expected result

The collapsible section is toggled. No scrolling happens.

Other information

Tested with various browsers on Debian 11 “bullseye”:
- Firefox 102.7.0esr: broken
- Firefox 110.0b3 (Developer Edition): broken
- Chromium 109.0.5414.74: broken
- GNOME Web 3.38.2 (WebKit-based, like Safari): not broken
Cross-reference: collapsible boxes were enabled in T323639: Talk page banners are not collapsible in mobile DiscussionTools.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+99 -46	Update OOUI to v0.46.3
	oojs/ui	master	+11 -9	Preserve scroll position when resizing windows

Customize query in gerrit

Related Objects

Mentioned Here: T323639: Talk page banners are not collapsible in mobile DiscussionTools

Event Timeline

Tacsipacsi created this task.Jan 22 2023, 12:32 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2023, 12:32 PM

It's actually an OOUI issue, all dialogs scroll to top whenever you resize them. I guess we're not resizing that many scrollable dialogs.

You can see this bug in VE's save dialog, when the copyright message is long enough to require scrolling, and you press Enter while in the dialog (which shows a message advising you to use Ctrl+Enter instead and resizes to show it).

matmarex added projects: Editing-team (Kanban Board), DiscussionTools.Jan 24 2023, 6:55 PM

matmarex moved this task from Backlog to Triaged on the DiscussionTools board.

matmarex moved this task from Incoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.Jan 24 2023, 7:00 PM

matmarex claimed this task.Jan 25 2023, 10:00 PM

Change 883666 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[oojs/ui@master] Preserve scroll position when resizing windows

https://gerrit.wikimedia.org/r/883666

gerritbot added a project: Patch-For-Review.Jan 25 2023, 10:03 PM

matmarex moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.Jan 25 2023, 10:09 PM

Change 883666 merged by jenkins-bot:

[oojs/ui@master] Preserve scroll position when resizing windows

https://gerrit.wikimedia.org/r/883666