Page MenuHomePhabricator

Incorrect question mark icon in Hebrew emails about Growth mentor change
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Log in to the Hebrew Wikipedia using an account who is in the mentors list.
  • Find a user who has another mentor. (Make sure that that user's user interface language is Hebrew.)
  • Claim that user as a mentee.
  • That user receives an email notification about mentor change.

What happens?:

The question mark icon in the email is wrong. Screenshot:

צילום מסך מ־2023-01-23 10-13-05.png (282×651 px, 19 KB)

What should have happened instead?:

The question mark icon is supposed to be the same as for English. The reversed question mark icon is used for Arabic and for some other right to left languages, but not for Hebrew (he) and Yiddish (yi).

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
KMorgan-WMF changed the task status from Open to In Progress.Mar 16 2023, 4:35 PM
KMorgan-WMF claimed this task.

Since we have hewiki in Beta, maybe it could be useful to enable Mentorship there to test this kind of issues which require e2e/manual testing.

Hi @Etonkovidova would you be willing and able to re-QA this? It may have been resolved by another patch recently and debugging it on my local environment requires some workarounds

Hi @Etonkovidova would you be willing and able to re-QA this? It may have been resolved by another patch recently and debugging it on my local environment requires some workarounds

Overall, I think it's a good idea to have variety of beta wikis with fully enabled Growth features. So, yes, it'd be great to have hewiki betalabs with enabled Mentorship module. @Sgs. @Urbanecm_WMF - is it easy to do?

Hi @Etonkovidova would you be willing and able to re-QA this? It may have been resolved by another patch recently and debugging it on my local environment requires some workarounds

Overall, I think it's a good idea to have variety of beta wikis with fully enabled Growth features. So, yes, it'd be great to have hewiki betalabs with enabled Mentorship module. @Sgs. @Urbanecm_WMF - is it easy to do?

Mentorship is enabled, there's just no one enrolled as a mentor yet: https://he.wikipedia.beta.wmflabs.org/wiki/%D7%9E%D7%99%D7%95%D7%97%D7%93:%D7%9C%D7%95%D7%97_%D7%91%D7%A7%D7%A8%D7%94_%D7%A9%D7%9C_%D7%97%D7%95%D7%A0%D7%9B%D7%99%D7%9D?uselang=en

As @kostajh says. I enrolled myself as a hewiki beta mentor and the mentorship module should now appear in that wiki.

Thx, @kostajh and @Urbanecm_WMF - I checked email change mentor notification on`hewiki betalabs` - the icon is displayed correctly.

Screen Shot 2023-05-15 at 2.31.23 PM.png (730×1 px, 90 KB)