Page MenuHomePhabricator

Incorrect styling on Special:CreateAccount
Closed, ResolvedPublicBUG REPORT

Description

On mobile (on some wikis), Special:CreateAccount has too much margin on the right.

Noticed on meta and wikitech. Seems it doesn't happen (or looks more tolerable) on English Wikipedia.

https://meta.m.wikimedia.org/w/index.php?title=Special:CreateAccount

MetaWikitechEnWikiSpecial:Login (for comparison)
Screenshot_20230123-115758_1.png (1×604 px, 155 KB)
Screenshot_20230123-160355_1.png (1×599 px, 161 KB)
Screenshot_20230123-160441_1.png (1×604 px, 149 KB)
Screenshot_20230125-180851_1.png (1×604 px, 136 KB)

On mediawiki.org, it seems the margin is corrected by a script on load.

Event Timeline

Did this start happening recently? It seems to be caused by the core signup styles but those haven't change for a long time.

I think I see what's happened here (looks like this was previously being removed by the targets system rather than explicitly by Minerva). I think this needs to be fixed in Minerva. Patch on the way as soon as Ive had my coffee...

Change 883633 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Blank skin styles for login and create account

https://gerrit.wikimedia.org/r/883633

Did this start happening recently? It seems to be caused by the core signup styles but those haven't change for a long time.

No idea. I was about to say I used to see the form centered, but maybe all I was seeing was Special:Login and not Special:CreateAccount. The latter is of course very rarely-used page (by existing editors).

Most likely caused by me in 2049c81e776f. Above patch will fix it.

Related: T286842#7406936 as that could make this regress again.

Tgr assigned this task to Jdlrobson.

Thanks!

Change 883633 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Blank skin styles for login and create account

https://gerrit.wikimedia.org/r/883633