Page MenuHomePhabricator
Create Task
Maniphest T327714

Unexpected whitespace at the top of stub (short) articles in Vector 2022
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
ovasileva
Authored By
Mike_Peel
Jan 23 2023, 9:34 PM
Tags
Referenced Files
F36511086: Screenshot 2023-01-25 at 5.50.50 PM.png
Jan 26 2023, 2:04 AM
F36511085: Screenshot 2023-01-25 at 5.56.20 PM.png
Jan 26 2023, 2:04 AM
F36511080: Screenshot 2023-01-25 at 5.48.17 PM.png
Jan 26 2023, 1:49 AM
F36487136: Screenshot 2023-01-24 at 3.43.03 PM.png
Jan 24 2023, 11:43 PM
F36455912: Screenshot 2023-01-23 at 21.31.42.png
Jan 23 2023, 9:34 PM
F36455911: Screenshot 2023-01-23 at 21.31.57.png
Jan 23 2023, 9:34 PM
Subscribers
Aklapper
bwang
Chipmunkdavis
Edtadros
HideonRosie
Izno
Jdlrobson
View All 13 Subscribers

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • There is a lot of whitespace at the top of an article before you get to 'From Wikipedia, the free encyclopedia'

What should have happened instead?:

  • Less vertical whitespace
  • This persists when replacing article content with 'Test', so doesn't seem to be wikitext-specific

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
Firefox 109.0, MacOS 13.0

Screenshot 2023-01-23 at 21.31.57.png (2×3 px, 1 MB)

Screenshot 2023-01-23 at 21.31.42.png (2×3 px, 1 MB)

QA Results - Prod

ACStatusDetails
1✅T327714#8559568

Details

SubjectRepoBranchLines +/-
Account for temporary row in grid template rowmediawiki/skins/Vectorwmf/1.40.0-wmf.20+1 -2
Account for temporary row in grid template rowmediawiki/skins/Vectorwmf/1.40.0-wmf.19+1 -2
Define grid template row for .mw-body grid container to ensure the grid cell containing the content will expand in height when neededmediawiki/skins/Vectorwmf/1.40.0-wmf.20+1 -2
Define grid template row for .mw-body grid container to ensure the grid cell containing the content will expand in height when neededmediawiki/skins/Vectorwmf/1.40.0-wmf.19+1 -2
Account for temporary row in grid template rowmediawiki/skins/Vectormaster+1 -1
Define grid template row for .mw-body grid container to ensure the grid cell containing the content will expand in height when neededmediawiki/skins/Vectormaster+1 -2
Customize query in gerrit

Related Objects

Event Timeline

Mike_Peel created this task.Jan 23 2023, 9:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 23 2023, 9:34 PM
Mike_Peel updated the task description. (Show Details)Jan 23 2023, 9:35 PM
Mike_Peel added a comment.Jan 23 2023, 9:41 PM

I think this happens when the article is shorter than the sidebars, going from a random selection of articles.

Jonesey95 subscribed.EditedJan 24 2023, 1:21 AM

This is replicable when the new page tools sidebar is visible, but not when the Tools items are hidden in the Tools menu. It looks like a change to the grid may have caused this. This one should be an urgent fix (or maybe rollback the page tools temporarily, given the other problems that have been reported).

Another example page: https://en.wikipedia.org/wiki/%C2%BFD%C3%B3nde_est%C3%A1_Elisa%3F

Izno subscribed.Jan 24 2023, 7:59 AM
Chipmunkdavis subscribed.Jan 24 2023, 9:59 AM
gerritbot added a comment.Jan 24 2023, 5:14 PM

Change 883241 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Define grid template area for .mw-body grid container to ensure the grid cell containing the content will expand in height when needed

https://gerrit.wikimedia.org/r/883241

gerritbot added a project: Patch-For-Review.Jan 24 2023, 5:14 PM
ovasileva triaged this task as High priority.Jan 24 2023, 5:23 PM
ovasileva added a project: Web-Team FY2022-23 Q3 Sprint 1.
Jonesey95 mentioned this in T327797: Extra white space below article's name.Jan 24 2023, 5:36 PM
ovasileva moved this task from Incoming to Code Review on the Web-Team FY2022-23 Q3 Sprint 1 board.Jan 24 2023, 6:01 PM
ovasileva subscribed.Jan 24 2023, 8:06 PM
gerritbot added a comment.Jan 24 2023, 8:54 PM

Change 883241 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Define grid template row for .mw-body grid container to ensure the grid cell containing the content will expand in height when needed

https://gerrit.wikimedia.org/r/883241

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.21; 2023-01-30).Jan 24 2023, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 24 2023, 9:32 PM
Jdlrobson renamed this task from Unexpected whitespace at the top of an article in Vector 2022 to Unexpected whitespace at the top of stub (short article in Vector 2022.Jan 24 2023, 10:38 PM
Jdlrobson renamed this task from Unexpected whitespace at the top of stub (short article in Vector 2022 to Unexpected whitespace at the top of stub (short) articles in Vector 2022.
Jdlrobson merged a task: T327797: Extra white space below article's name.
Jdlrobson added subscribers: PPham, jhsoby.
Jdlrobson moved this task from Code Review to QA on the Web-Team FY2022-23 Q3 Sprint 1 board.Jan 24 2023, 11:05 PM
Edtadros claimed this task.Jan 24 2023, 11:40 PM
Edtadros reassigned this task from Edtadros to Jdlrobson.EditedJan 24 2023, 11:43 PM
Edtadros moved this task from QA to Needs More Work on the Web-Team FY2022-23 Q3 Sprint 1 board.
Edtadros subscribed.

Test Result - Beta

Status: ❌
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

❌ AC1: There should not be a lot of whitespace at the top of an article before you get to 'From Wikipedia, the free encyclopedia'
https://en.wikipedia.beta.wmflabs.org/wiki/Conflict-title-0.05316586908130838-I%C3%B1t%C3%ABrn%C3%A2ti%C3%B4n%C3%A0liz%C3%A6ti%C3%B8n

Screenshot 2023-01-24 at 3.43.03 PM.png (1×1 px, 220 KB)

Jdlrobson reassigned this task from Jdlrobson to bwang.Jan 25 2023, 12:20 AM
Jdlrobson subscribed.
gerritbot added a comment.Jan 25 2023, 12:38 AM

Change 883290 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Account for temporary row in grid template row

https://gerrit.wikimedia.org/r/883290

gerritbot added a project: Patch-For-Review.Jan 25 2023, 12:38 AM
gerritbot added a comment.Jan 25 2023, 1:08 AM

Change 883290 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Account for temporary row in grid template row

https://gerrit.wikimedia.org/r/883290

Maintenance_bot removed a project: Patch-For-Review.Jan 25 2023, 1:30 AM
bwang removed bwang as the assignee of this task.Jan 25 2023, 3:53 PM
bwang moved this task from Needs More Work to QA on the Web-Team FY2022-23 Q3 Sprint 1 board.
bwang subscribed.
Edtadros claimed this task.Jan 25 2023, 5:20 PM
TheresNoTime subscribed.Jan 25 2023, 7:16 PM
TheresNoTime added a comment.Jan 25 2023, 7:21 PM

Do we want to backport this? If so, gentle nudge that there's a free window in ~2 hours 🤗

gerritbot added a comment.Jan 25 2023, 7:34 PM

Change 883616 had a related patch set uploaded (by Jdrewniak; author: Bernard Wang):

[mediawiki/skins/Vector@wmf/1.40.0-wmf.19] Define grid template row for .mw-body grid container to ensure the grid cell containing the content will expand in height when needed

https://gerrit.wikimedia.org/r/883616

gerritbot added a project: Patch-For-Review.Jan 25 2023, 7:34 PM

Change 883617 had a related patch set uploaded (by Jdrewniak; author: Bernard Wang):

[mediawiki/skins/Vector@wmf/1.40.0-wmf.20] Define grid template row for .mw-body grid container to ensure the grid cell containing the content will expand in height when needed

https://gerrit.wikimedia.org/r/883617

gerritbot added a comment.Jan 25 2023, 7:40 PM

Change 883618 had a related patch set uploaded (by Jdrewniak; author: Bernard Wang):

[mediawiki/skins/Vector@wmf/1.40.0-wmf.19] Account for temporary row in grid template row

https://gerrit.wikimedia.org/r/883618

gerritbot added a comment.Jan 25 2023, 7:43 PM

Change 883619 had a related patch set uploaded (by Jdrewniak; author: Bernard Wang):

[mediawiki/skins/Vector@wmf/1.40.0-wmf.20] Account for temporary row in grid template row

https://gerrit.wikimedia.org/r/883619

ovasileva added a comment.Jan 25 2023, 8:01 PM
In T327714#8558706, @TheresNoTime wrote:

Do we want to backport this? If so, gentle nudge that there's a free window in ~2 hours 🤗

@TheresNoTime Yes, we're backporting it today :) should appear on the schedule now.

Novem_Linguae updated the task description. (Show Details)Jan 25 2023, 8:07 PM
gerritbot added a comment.Jan 25 2023, 9:23 PM

Change 883616 merged by Samtar:

[mediawiki/skins/Vector@wmf/1.40.0-wmf.19] Define grid template row for .mw-body grid container to ensure the grid cell containing the content will expand in height when needed

https://gerrit.wikimedia.org/r/883616

gerritbot added a comment.Jan 25 2023, 9:24 PM

Change 883617 merged by Samtar:

[mediawiki/skins/Vector@wmf/1.40.0-wmf.20] Define grid template row for .mw-body grid container to ensure the grid cell containing the content will expand in height when needed

https://gerrit.wikimedia.org/r/883617

Stashbot added a comment.Jan 25 2023, 9:24 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-25T21:24:43Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:883617|Define grid template row for .mw-body grid container to ensure the grid cell containing the content will expand in height when needed (T327714)]], [[gerrit:883616|Define grid template row for .mw-body grid container to ensure the grid cell containing the content will expand in height when needed (T327714)]]

Stashbot added a comment.Jan 25 2023, 9:26 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-25T21:26:27Z] <samtar@deploy1002> jdrewniak and samtar: Backport for [[gerrit:883617|Define grid template row for .mw-body grid container to ensure the grid cell containing the content will expand in height when needed (T327714)]], [[gerrit:883616|Define grid template row for .mw-body grid container to ensure the grid cell containing the content will expand in height when needed (T327714)]] synced to the testservers: mwdebug2002.cod

Stashbot added a comment.Jan 25 2023, 9:34 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-25T21:34:10Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:883617|Define grid template row for .mw-body grid container to ensure the grid cell containing the content will expand in height when needed (T327714)]], [[gerrit:883616|Define grid template row for .mw-body grid container to ensure the grid cell containing the content will expand in height when needed (T327714)]] (duration: 09m 27s)

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.20; 2023-01-23); removed MW-1.40-notes (1.40.0-wmf.21; 2023-01-30).Jan 25 2023, 10:00 PM
Mike_Peel added a comment.Jan 25 2023, 10:25 PM

It looks much better now, thank you for working on this!

Jdlrobson added a comment.Jan 26 2023, 12:33 AM

Thanks for reporting it @Mike_Peel !

Jdlrobson moved this task from QA to QA in Production on the Web-Team FY2022-23 Q3 Sprint 1 board.Jan 26 2023, 12:33 AM
Edtadros added a comment.Jan 26 2023, 1:49 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: There should not be a lot of whitespace at the top of an article before you get to 'From Wikipedia, the free encyclopedia'
https://en.wikipedia.beta.wmflabs.org/wiki/Conflict-title-0.05316586908130838-I%C3%B1t%C3%ABrn%C3%A2ti%C3%B4n%C3%A0liz%C3%A6ti%C3%B8n

Screenshot 2023-01-25 at 5.48.17 PM.png (563×1 px, 127 KB)

Edtadros reassigned this task from Edtadros to Jdlrobson.EditedJan 26 2023, 2:04 AM

Test Result - Prod

Status: ❓ ✅
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ ❓ AC1: There should not be a lot of whitespace at the top of an article before you get to 'From Wikipedia, the free encyclopedia'
@Jdlrobson, Using the URL in the description https://en.wikipedia.org/wiki/Cristina_Pi%C3%B1a?safemode=1 the 'From Wikipedia, the free encyclopedia' does not appear on the page.

Screenshot 2023-01-25 at 5.56.20 PM.png (561×1 px, 194 KB)

Without the safemode param this appears correctly.

Screenshot 2023-01-25 at 5.50.50 PM.png (561×1 px, 193 KB)

Is this expected?
This is a pass per T327714#8559696

HideonRosie subscribed.Jan 26 2023, 3:40 AM

It looks much better now, thanks for working on this.

Izno added a comment.Jan 26 2023, 4:09 AM
In T327714#8559568, @Edtadros wrote:

Test Artifact(s):

QA Steps

❓ AC1: There should not be a lot of whitespace at the top of an article before you get to 'From Wikipedia, the free encyclopedia'
@Jdlrobson, Using the URL in the description https://en.wikipedia.org/wiki/Cristina_Pi%C3%B1a?safemode=1 the 'From Wikipedia, the free encyclopedia' does not appear on the page.

Screenshot 2023-01-25 at 5.56.20 PM.png (561×1 px, 194 KB)

Without the safemode param this appears correctly.

Screenshot 2023-01-25 at 5.50.50 PM.png (561×1 px, 193 KB)

Is this expected?

Yes. The tagline is hidden by default and caused to be displayed only in the local stylesheets (e.g. https://en.wikipedia.org/wiki/MediaWiki:Common.css#L-236 ), which are disabled in safe mode.

Jdlrobson moved this task from Incoming to Visual Enhancements / Layout on the Desktop Improvements (Vector 2022) board.Jan 26 2023, 8:20 PM
Edtadros reassigned this task from Jdlrobson to ovasileva.Jan 29 2023, 1:14 AM
Edtadros moved this task from QA in Production to Ready for Signoff on the Web-Team FY2022-23 Q3 Sprint 1 board.

This is a pass per T327714#8559696

Edtadros updated the task description. (Show Details)Jan 29 2023, 1:16 AM
ovasileva closed this task as Resolved.Jan 30 2023, 4:20 PM
gerritbot added a comment.Feb 7 2023, 3:28 PM

Change 883618 abandoned by Jdrewniak:

[mediawiki/skins/Vector@wmf/1.40.0-wmf.19] Account for temporary row in grid template row

Reason:

https://gerrit.wikimedia.org/r/883618

gerritbot added a comment.Feb 7 2023, 3:29 PM

Change 883619 abandoned by Jdrewniak:

[mediawiki/skins/Vector@wmf/1.40.0-wmf.20] Account for temporary row in grid template row

Reason:

https://gerrit.wikimedia.org/r/883619

Maintenance_bot removed a project: Patch-For-Review.Feb 7 2023, 3:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL