Page MenuHomePhabricator
Create Task
Maniphest T327802

Language selector label is shown with character numbers in Vector 2022
Closed, ResolvedPublic0 Estimated Story PointsBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:

The label on the language selector is "79 yetɔgum zo'e zo'e".

What should have happened instead?:

The label on the language selector is supposed to be "79 yetɔgum zo'e zo'e".

QA Results - Beta

ACStatusDetails
1✅T327802#8926227

QA Results - Prod

ACStatusDetails
1✅T327802#8939891

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
SkinVector22: Avoid double-escaping on language selector labelFuncmediawiki/skins/Vectormaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

Amire80 created this task.Jan 24 2023, 4:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 24 2023, 4:43 PM
Amire80 added a project: I18n.Jan 24 2023, 4:43 PM
Jdlrobson added a project: Web-Team-Backlog-Archived.Jan 24 2023, 11:32 PM
Jdlrobson moved this task from Incoming to Search on the Vector 2022 board.Jan 26 2023, 8:19 PM
Jdlrobson moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog-Archived board.Jan 26 2023, 8:26 PM
ovasileva triaged this task as Medium priority.Mar 15 2023, 4:51 PM
ovasileva moved this task from Not ready to estimate to Current Fiscal Year on the Web-Team-Backlog-Archived board.
Amire80 merged a task: T338207: vector-language-button-label shows an escaped HTML entity instead of a single quote.Jun 6 2023, 8:03 AM
Amire80 mentioned this in T338206: In Special:Recentchanges, single quote gets escaped in a message.

The reason for this may be the same as for T338206.

gerritbot added a comment.Jun 6 2023, 5:16 PM

Change 926565 had a related patch set uploaded (by Func; author: Func):

[mediawiki/skins/Vector@master] SkinVector22: Avoid double-escaping on language selector label

https://gerrit.wikimedia.org/r/926565

gerritbot added a project: Patch-For-Review.Jun 6 2023, 5:16 PM
Jdlrobson edited projects, added: Web-Team-Backlog-Archived ( Web Team FY2022-23 Q4 Sprint 5), Unplanned-Sprint-Work; removed: Web-Team-Backlog-Archived.Jun 8 2023, 8:09 PM
Jdlrobson subscribed.

There is a patch from a volunteer that we should review.

Jdlrobson moved this task from Incoming to Code Review on the Web-Team-Backlog-Archived ( Web Team FY2022-23 Q4 Sprint 5) board.Jun 8 2023, 8:09 PM
PatchDemoBot added a comment.Jun 9 2023, 7:46 PM

Test wiki created on Patch demo by Bwvbnm using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/f9f47a86c5/w

gerritbot added a comment.Jun 9 2023, 8:14 PM

Change 926565 merged by jenkins-bot:

[mediawiki/skins/Vector@master] SkinVector22: Avoid double-escaping on language selector label

https://gerrit.wikimedia.org/r/926565

Maintenance_bot removed a project: Patch-For-Review.Jun 9 2023, 8:30 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog-Archived ( Web Team FY2022-23 Q4 Sprint 5) board.Jun 9 2023, 8:38 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.13; 2023-06-13).Jun 9 2023, 9:00 PM
Jdlrobson set the point value for this task to 0.Jun 12 2023, 5:19 PM
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog-Archived ( Web Team FY2022-23 Q4 Sprint 5) board.Jun 13 2023, 2:42 AM
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Go to a page on beta (or for prod use https://en.wikipedia.org/wiki/ASCII?uselang=gur&useskin=vector-2022) on the desktop (The article "ASCII" in the English Wikipedia, with interface language "gur", and Vector 2022 skin.)

✅ AC1: The label on the language selector is supposed to be "79 yetɔgum zo'e zo'e". where the number shown is the number of languages.

Screenshot 2023-06-12 at 7.41.38 PM.png (1,446×437 px, 95 KB)

Edtadros updated the task description. (Show Details)Jun 13 2023, 2:43 AM
Jdlrobson assigned this task to Edtadros.Jun 13 2023, 4:37 PM
Jdlrobson moved this task from Ready for Signoff to QA in Production on the Web-Team-Backlog-Archived ( Web Team FY2022-23 Q4 Sprint 5) board.

Should be available to test on Thursday in production.

Edtadros added a comment.Jun 16 2023, 10:46 PM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Go to a page on beta (or for prod use https://en.wikipedia.org/wiki/ASCII?uselang=gur&useskin=vector-2022) on the desktop (The article "ASCII" in the English Wikipedia, with interface language "gur", and Vector 2022 skin.)

✅ AC1: The label on the language selector is supposed to be "79 yetɔgum zo'e zo'e". where the number shown is the number of languages.

Screenshot 2023-06-16 at 3.46.19 PM.png (1,475×595 px, 243 KB)

Edtadros closed this task as Resolved.Jun 16 2023, 10:46 PM
Edtadros removed Edtadros as the assignee of this task.
Edtadros updated the task description. (Show Details)
PatchDemoBot added a comment.Oct 21 2023, 1:34 PM

Test wiki on Patch demo by Bwvbnm using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/f9f47a86c5/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits