Page MenuHomePhabricator
Create Task
Maniphest T327834

SPIKE: Empty ToC space in Vector 2022 special pages layout
Open, MediumPublicBUG REPORT
Actions

Description

Discovered today on Vector 2022 master branch, there appears to be a blank space where the ToC would be on Vector 2022 special pages.

Screen Shot 2023-01-24 at 6.47.25 PM.png (1×3 px, 905 KB)

By checking out git commits in Vector one-by-one, a related change was introduced in on January 13, with Table of contents elements should not be rendered where none available (which sounds like it should prevent this very problem).

Somehow this has only appeared recently and does not affect production. Potentially could be a core change that changes the value of the data-toc array from null to an empty array (guessing).

The following patch explicitly sets null on the ToC array and fixes this issue:

https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/883289

Developer notes

The CSS issue is due to a missing class "vector-sidebar-container-no-toc", which is set when data-toc evaluates to false in mustache.

Details

ProjectBranchLines +/-Subject
mediawiki/skins/Vectormaster+2 -0Override parent template data if component is null
Customize query in gerrit

Event Timeline

Jdrewniak created this task.Wed, Jan 25, 12:47 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Jan 25, 12:47 AM
gerritbot added a comment.Wed, Jan 25, 12:48 AM

Change 883289 had a related patch set uploaded (by Jdrewniak; author: Bernard Wang):

[mediawiki/skins/Vector@master] Override parent template data if component is null

https://gerrit.wikimedia.org/r/883289

gerritbot added a project: Patch-For-Review.Wed, Jan 25, 12:48 AM
Jdrewniak updated the task description. (Show Details)Wed, Jan 25, 12:51 AM
Jdlrobson moved this task from Incoming to Table of Contents on the Desktop Improvements (Vector 2022) board.Thu, Jan 26, 8:19 PM
Jdlrobson added a project: Web-Team FY2022-23 Q3 Sprint 1.Thu, Jan 26, 8:27 PM
Jdlrobson moved this task from Incoming to Sprint 1 (non-milestone) on the Readers-Web-Backlog board.
Jdlrobson moved this task from Incoming to Code Review on the Web-Team FY2022-23 Q3 Sprint 1 board.Thu, Jan 26, 9:02 PM
Jdlrobson added a comment.Fri, Jan 27, 8:40 PM

(for now) I can't replicate this in production or locally, so I think we should spend some more time understanding this bug.

Setting it explicitly to null should not be necessary and could indicate some kind of breaking change in the TemplateParser or associated library.

Jdlrobson added a comment.Fri, Jan 27, 8:41 PM

@Jdrewniak when you see this locally, what value is being set for data-toc without this patch for you?

bwang updated the task description. (Show Details)Fri, Jan 27, 8:48 PM
ovasileva triaged this task as Medium priority.Mon, Jan 30, 4:06 PM
Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team FY2022-23 Q3 Sprint 1 board.Mon, Jan 30, 6:05 PM
ovasileva renamed this task from Empty ToC space in Vector 2022 special pages layout to SPIKE: Empty ToC space in Vector 2022 special pages layout.Mon, Jan 30, 6:43 PM
Jdlrobson removed a project: Web-Team FY2022-23 Q3 Sprint 1.Tue, Jan 31, 5:23 PM
Jdlrobson edited projects, added Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 3); removed Readers-Web-Backlog.
Jdlrobson edited projects, added Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 4); removed Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 3).Mon, Feb 6, 11:46 PM

@Jdrewniak I still can't replicate this. Suggesting we punt this to sprint 4 for now. Please update before Thursday estimation meeting if you think we should be getting this ready for sprint 3.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL