Page MenuHomePhabricator

Postgres CI failures for CheckUser extension
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Run experimental CI (that includes running tests using a postgres DB)

What happens?:
CI fails because.

What should have happened instead?:
CI should pass as these test failures indicate that there would be problems when running CheckUser using a postgres DB.

Other information (browser name/version, screenshots, etc.):
Test failures:

13:25:57 There were 9 errors:
13:25:57 
13:25:57 1) MediaWiki\CheckUser\Tests\Integration\Api\Rest\Handler\TemporaryAccountHandlerTest::testExecute
13:25:57 Wikimedia\Rdbms\DBQueryError: Error 42P10: ERROR:  for SELECT DISTINCT, ORDER BY expressions must appear in select list
13:25:57 LINE 1: ...t_cu_changes"    WHERE cuc_actor = 1234  ORDER BY cuc_actor ...
13:25:57                                                              ^
13:25:57 
13:25:57 Function: MediaWiki\CheckUser\Api\Rest\Handler\TemporaryAccountHandler::getData
13:25:57 Query: SELECT DISTINCT cuc_ip AS "value"  FROM "unittest_cu_changes"    WHERE cuc_actor = 1234  ORDER BY cuc_actor DESC,cuc_ip DESC,cuc_timestamp DESC LIMIT 5000  
13:25:57 
13:25:57 
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1534
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1518
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1492
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:865
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1629
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1605
13:25:57 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:119
13:25:57 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:332
13:25:57 /workspace/src/includes/libs/rdbms/querybuilder/SelectQueryBuilder.php:686
13:25:57 /workspace/src/extensions/CheckUser/src/Api/Rest/Handler/TemporaryAccountHandler.php:38
13:25:57 /workspace/src/extensions/CheckUser/src/Api/Rest/Handler/AbstractTemporaryAccountHandler.php:104
13:25:57 /workspace/src/includes/Rest/SimpleHandler.php:38
13:25:57 /workspace/src/tests/phpunit/unit/includes/Rest/Handler/HandlerTestTrait.php:164
13:25:57 /workspace/src/tests/phpunit/unit/includes/Rest/Handler/HandlerTestTrait.php:199
13:25:57 /workspace/src/extensions/CheckUser/tests/phpunit/integration/Api/Rest/Handler/TemporaryAccountHandlerTest.php:107
13:25:57 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:519
13:25:57 === Logs generated by test case
13:25:57 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:25:57 ===
13:25:57 
13:25:57 2) MediaWiki\CheckUser\Tests\Integration\Api\Rest\Handler\TemporaryAccountHandlerTest::testExecuteLimit
13:25:57 Wikimedia\Rdbms\DBQueryError: Error 42P10: ERROR:  for SELECT DISTINCT, ORDER BY expressions must appear in select list
13:25:57 LINE 1: ...t_cu_changes"    WHERE cuc_actor = 1234  ORDER BY cuc_actor ...
13:25:57                                                              ^
13:25:57 
13:25:57 Function: MediaWiki\CheckUser\Api\Rest\Handler\TemporaryAccountHandler::getData
13:25:57 Query: SELECT DISTINCT cuc_ip AS "value"  FROM "unittest_cu_changes"    WHERE cuc_actor = 1234  ORDER BY cuc_actor DESC,cuc_ip DESC,cuc_timestamp DESC LIMIT 1  
13:25:57 
13:25:57 
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1534
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1518
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1492
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:865
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1629
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1605
13:25:57 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:119
13:25:57 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:332
13:25:57 /workspace/src/includes/libs/rdbms/querybuilder/SelectQueryBuilder.php:686
13:25:57 /workspace/src/extensions/CheckUser/src/Api/Rest/Handler/TemporaryAccountHandler.php:38
13:25:57 /workspace/src/extensions/CheckUser/src/Api/Rest/Handler/AbstractTemporaryAccountHandler.php:104
13:25:57 /workspace/src/includes/Rest/SimpleHandler.php:38
13:25:57 /workspace/src/tests/phpunit/unit/includes/Rest/Handler/HandlerTestTrait.php:164
13:25:57 /workspace/src/tests/phpunit/unit/includes/Rest/Handler/HandlerTestTrait.php:199
13:25:57 /workspace/src/extensions/CheckUser/tests/phpunit/integration/Api/Rest/Handler/TemporaryAccountHandlerTest.php:128
13:25:57 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:519
13:25:57 === Logs generated by test case
13:25:57 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:25:57 ===
13:25:57 
13:25:57 3) MediaWiki\CheckUser\Tests\Integration\Api\Rest\Handler\TemporaryAccountHandlerTest::testExecuteLimitConfig
13:25:57 Wikimedia\Rdbms\DBQueryError: Error 42P10: ERROR:  for SELECT DISTINCT, ORDER BY expressions must appear in select list
13:25:57 LINE 1: ...t_cu_changes"    WHERE cuc_actor = 1234  ORDER BY cuc_actor ...
13:25:57                                                              ^
13:25:57 
13:25:57 Function: MediaWiki\CheckUser\Api\Rest\Handler\TemporaryAccountHandler::getData
13:25:57 Query: SELECT DISTINCT cuc_ip AS "value"  FROM "unittest_cu_changes"    WHERE cuc_actor = 1234  ORDER BY cuc_actor DESC,cuc_ip DESC,cuc_timestamp DESC LIMIT 1  
13:25:57 
13:25:57 
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1534
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1518
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1492
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:865
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1629
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1605
13:25:57 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:119
13:25:57 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:332
13:25:57 /workspace/src/includes/libs/rdbms/querybuilder/SelectQueryBuilder.php:686
13:25:57 /workspace/src/extensions/CheckUser/src/Api/Rest/Handler/TemporaryAccountHandler.php:38
13:25:57 /workspace/src/extensions/CheckUser/src/Api/Rest/Handler/AbstractTemporaryAccountHandler.php:104
13:25:57 /workspace/src/includes/Rest/SimpleHandler.php:38
13:25:57 /workspace/src/tests/phpunit/unit/includes/Rest/Handler/HandlerTestTrait.php:164
13:25:57 /workspace/src/tests/phpunit/unit/includes/Rest/Handler/HandlerTestTrait.php:199
13:25:57 /workspace/src/extensions/CheckUser/tests/phpunit/integration/Api/Rest/Handler/TemporaryAccountHandlerTest.php:145
13:25:57 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:519
13:25:57 === Logs generated by test case
13:25:57 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:25:57 ===
13:25:57 
13:25:57 4) MediaWiki\CheckUser\Tests\Integration\HooksTest::testPruneIPDataData with data set "No entries to prune" (1674653105, 7776000, array(1674653103, 1666877205, 1674653105, 1674653115), 4)
13:25:57 Wikimedia\Rdbms\DBQueryError: Error 42883: ERROR:  operator does not exist: timestamp with time zone < integer
13:25:57 LINE 1: ...ROM "unittest_cu_changes"    WHERE (cuc_timestamp < 16668771...
13:25:57                                                              ^
13:25:57 HINT:  No operator matches the given name and argument types. You might need to add explicit type casts.
13:25:57 
13:25:57 Function: Wikimedia\Rdbms\SelectQueryBuilder
13:25:57 Query: SELECT  COUNT(*) AS "rowcount"  FROM (SELECT  1  FROM "unittest_cu_changes"    WHERE (cuc_timestamp < 1666877105) AND (cuc_id IS NOT NULL)  ) "tmp_count"     
13:25:57 
13:25:57 
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1534
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1518
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1492
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:865
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1629
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1682
13:25:57 /workspace/src/includes/libs/rdbms/querybuilder/SelectQueryBuilder.php:709
13:25:57 /workspace/src/extensions/CheckUser/tests/phpunit/integration/CheckUserCommonTraitTest.php:96
13:25:57 /workspace/src/extensions/CheckUser/tests/phpunit/integration/HooksTest.php:1391
13:25:57 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:519
13:25:57 === Logs generated by test case
13:25:57 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:25:57 [localisation] [debug] LocalisationCache using store LCStoreNull []
13:25:57 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:25:57 [CentralAuth] [debug] Loading state for global user {user} from DB {"user":"TestUser fad1a3.1af"}
13:25:57 [CentralAuth] [debug] Loading attached wiki list for global user TestUser fad1a3.1af from DB []
13:25:57 [CentralAuth] [debug] Loading groups for global user {user} {"user":"TestUser fad1a3.1af"}
13:25:57 [objectcache] [debug] fetchOrRegenerate(global:centralauth-user:fb557fe72ca9af5ed38468a30dca99ef): miss, new value computed []
13:25:57 [CentralAuth] [debug] Loading CentralAuthUser for user {user} from cache object {"user":"TestUser fad1a3.1af"}
13:25:57 [DeferredUpdates] [debug] DeferredUpdates::run: started AutoCommitUpdate_MediaWiki\CheckUser\Hooks::pruneIPData #36997 []
13:25:57 [DeferredUpdates] [debug] DeferredUpdates::run: ended AutoCommitUpdate_MediaWiki\CheckUser\Hooks::pruneIPData #36997, processing time: 0.0025260448455811 []
13:25:57 ===
13:25:57 
13:25:57 5) MediaWiki\CheckUser\Tests\Integration\HooksTest::testPruneIPDataData with data set "Two entries to prune with two to be left" (1674653105, 7776000, array(1666857105, 1666877005, 1674653105, 1674653115), 2)
13:25:57 Wikimedia\Rdbms\DBQueryError: Error 42883: ERROR:  operator does not exist: timestamp with time zone < integer
13:25:57 LINE 1: ...ROM "unittest_cu_changes"    WHERE (cuc_timestamp < 16668771...
13:25:57                                                              ^
13:25:57 HINT:  No operator matches the given name and argument types. You might need to add explicit type casts.
13:25:57 
13:25:57 Function: Wikimedia\Rdbms\SelectQueryBuilder
13:25:57 Query: SELECT  COUNT(*) AS "rowcount"  FROM (SELECT  1  FROM "unittest_cu_changes"    WHERE (cuc_timestamp < 1666877105) AND (cuc_id IS NOT NULL)  ) "tmp_count"     
13:25:57 
13:25:57 
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1534
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1518
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1492
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:865
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1629
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1682
13:25:57 /workspace/src/includes/libs/rdbms/querybuilder/SelectQueryBuilder.php:709
13:25:57 /workspace/src/extensions/CheckUser/tests/phpunit/integration/CheckUserCommonTraitTest.php:96
13:25:57 /workspace/src/extensions/CheckUser/tests/phpunit/integration/HooksTest.php:1391
13:25:57 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:519
13:25:57 === Logs generated by test case
13:25:57 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:25:57 [localisation] [debug] LocalisationCache using store LCStoreNull []
13:25:57 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:25:57 [CentralAuth] [debug] Loading state for global user {user} from DB {"user":"TestUser fad1a3.1b1"}
13:25:57 [CentralAuth] [debug] Loading attached wiki list for global user TestUser fad1a3.1b1 from DB []
13:25:57 [CentralAuth] [debug] Loading groups for global user {user} {"user":"TestUser fad1a3.1b1"}
13:25:57 [objectcache] [debug] fetchOrRegenerate(global:centralauth-user:fd28b55ae692f49cd0c09dd8c83fd304): miss, new value computed []
13:25:57 [CentralAuth] [debug] Loading CentralAuthUser for user {user} from cache object {"user":"TestUser fad1a3.1b1"}
13:25:57 [DeferredUpdates] [debug] DeferredUpdates::run: started AutoCommitUpdate_MediaWiki\CheckUser\Hooks::pruneIPData #41266 []
13:25:57 [DeferredUpdates] [debug] DeferredUpdates::run: ended AutoCommitUpdate_MediaWiki\CheckUser\Hooks::pruneIPData #41266, processing time: 0.0046610832214355 []
13:25:57 ===
13:25:57 
13:25:57 6) MediaWiki\CheckUser\Tests\Integration\HooksTest::testPruneIPDataData with data set "Four entries to prune with no left" (1674653105, 7776000, array(1666857105, 1666877005, 1666877104, 1666777105), 0)
13:25:57 Wikimedia\Rdbms\DBQueryError: Error 42883: ERROR:  operator does not exist: timestamp with time zone < integer
13:25:57 LINE 1: ...ROM "unittest_cu_changes"    WHERE (cuc_timestamp < 16668771...
13:25:57                                                              ^
13:25:57 HINT:  No operator matches the given name and argument types. You might need to add explicit type casts.
13:25:57 
13:25:57 Function: Wikimedia\Rdbms\SelectQueryBuilder
13:25:57 Query: SELECT  COUNT(*) AS "rowcount"  FROM (SELECT  1  FROM "unittest_cu_changes"    WHERE (cuc_timestamp < 1666877105) AND (cuc_id IS NOT NULL)  ) "tmp_count"     
13:25:57 
13:25:57 
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1534
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1518
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1492
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:865
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1629
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1682
13:25:57 /workspace/src/includes/libs/rdbms/querybuilder/SelectQueryBuilder.php:709
13:25:57 /workspace/src/extensions/CheckUser/tests/phpunit/integration/CheckUserCommonTraitTest.php:96
13:25:57 /workspace/src/extensions/CheckUser/tests/phpunit/integration/HooksTest.php:1391
13:25:57 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:519
13:25:57 === Logs generated by test case
13:25:57 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:25:57 [localisation] [debug] LocalisationCache using store LCStoreNull []
13:25:57 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:25:57 [CentralAuth] [debug] Loading state for global user {user} from DB {"user":"TestUser fad1a3.1b3"}
13:25:57 [CentralAuth] [debug] Loading attached wiki list for global user TestUser fad1a3.1b3 from DB []
13:25:57 [CentralAuth] [debug] Loading groups for global user {user} {"user":"TestUser fad1a3.1b3"}
13:25:57 [objectcache] [debug] fetchOrRegenerate(global:centralauth-user:c657038abf023f8656317dd2857a7d19): miss, new value computed []
13:25:57 [CentralAuth] [debug] Loading CentralAuthUser for user {user} from cache object {"user":"TestUser fad1a3.1b3"}
13:25:57 [DeferredUpdates] [debug] DeferredUpdates::run: started AutoCommitUpdate_MediaWiki\CheckUser\Hooks::pruneIPData #35217 []
13:25:57 [DeferredUpdates] [debug] DeferredUpdates::run: ended AutoCommitUpdate_MediaWiki\CheckUser\Hooks::pruneIPData #35217, processing time: 0.0044348239898682 []
13:25:57 ===
13:25:57 
13:25:57 7) MediaWiki\CheckUser\Tests\Integration\Maintenance\PurgeOldDataTest::testExecute with data set "No entries to prune" (1674653105, 7776000, array(1674653103, 1666877205, 1674653105, 1674653115), 4)
13:25:57 Wikimedia\Rdbms\DBQueryError: Error 42883: ERROR:  operator does not exist: timestamp with time zone < integer
13:25:57 LINE 1: ...ROM "unittest_cu_changes"    WHERE (cuc_timestamp < 16668771...
13:25:57                                                              ^
13:25:57 HINT:  No operator matches the given name and argument types. You might need to add explicit type casts.
13:25:57 
13:25:57 Function: Wikimedia\Rdbms\SelectQueryBuilder
13:25:57 Query: SELECT  COUNT(*) AS "rowcount"  FROM (SELECT  1  FROM "unittest_cu_changes"    WHERE (cuc_timestamp < 1666877105) AND (cuc_id IS NOT NULL)  ) "tmp_count"     
13:25:57 
13:25:57 
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1534
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1518
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1492
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:865
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1629
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1682
13:25:57 /workspace/src/includes/libs/rdbms/querybuilder/SelectQueryBuilder.php:709
13:25:57 /workspace/src/extensions/CheckUser/tests/phpunit/integration/CheckUserCommonTraitTest.php:96
13:25:57 /workspace/src/extensions/CheckUser/tests/phpunit/integration/maintenance/PurgeOldDataTest.php:80
13:25:57 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:519
13:25:57 === Logs generated by test case
13:25:57 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:25:57 [localisation] [debug] LocalisationCache using store LCStoreNull []
13:25:57 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:25:57 [CentralAuth] [debug] Loading state for global user {user} from DB {"user":"TestUser fad1a3.1cd"}
13:25:57 [CentralAuth] [debug] Loading attached wiki list for global user TestUser fad1a3.1cd from DB []
13:25:57 [CentralAuth] [debug] Loading groups for global user {user} {"user":"TestUser fad1a3.1cd"}
13:25:57 [objectcache] [debug] fetchOrRegenerate(global:centralauth-user:a14654074f04185eb2e092e343fe6d18): miss, new value computed []
13:25:57 [CentralAuth] [debug] Loading CentralAuthUser for user {user} from cache object {"user":"TestUser fad1a3.1cd"}
13:25:57 ===
13:25:57 
13:25:57 8) MediaWiki\CheckUser\Tests\Integration\Maintenance\PurgeOldDataTest::testExecute with data set "Two entries to prune with two to be left" (1674653105, 7776000, array(1666857105, 1666877005, 1674653105, 1674653115), 2)
13:25:57 Wikimedia\Rdbms\DBQueryError: Error 42883: ERROR:  operator does not exist: timestamp with time zone < integer
13:25:57 LINE 1: ...ROM "unittest_cu_changes"    WHERE (cuc_timestamp < 16668771...
13:25:57                                                              ^
13:25:57 HINT:  No operator matches the given name and argument types. You might need to add explicit type casts.
13:25:57 
13:25:57 Function: Wikimedia\Rdbms\SelectQueryBuilder
13:25:57 Query: SELECT  COUNT(*) AS "rowcount"  FROM (SELECT  1  FROM "unittest_cu_changes"    WHERE (cuc_timestamp < 1666877105) AND (cuc_id IS NOT NULL)  ) "tmp_count"     
13:25:57 
13:25:57 
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1534
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1518
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1492
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:865
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1629
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1682
13:25:57 /workspace/src/includes/libs/rdbms/querybuilder/SelectQueryBuilder.php:709
13:25:57 /workspace/src/extensions/CheckUser/tests/phpunit/integration/CheckUserCommonTraitTest.php:96
13:25:57 /workspace/src/extensions/CheckUser/tests/phpunit/integration/maintenance/PurgeOldDataTest.php:80
13:25:57 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:519
13:25:57 === Logs generated by test case
13:25:57 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:25:57 [localisation] [debug] LocalisationCache using store LCStoreNull []
13:25:57 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:25:57 [CentralAuth] [debug] Loading state for global user {user} from DB {"user":"TestUser fad1a3.1ce"}
13:25:57 [CentralAuth] [debug] Loading attached wiki list for global user TestUser fad1a3.1ce from DB []
13:25:57 [CentralAuth] [debug] Loading groups for global user {user} {"user":"TestUser fad1a3.1ce"}
13:25:57 [objectcache] [debug] fetchOrRegenerate(global:centralauth-user:23686dd0df2780afb429cc5ea94a4812): miss, new value computed []
13:25:57 [CentralAuth] [debug] Loading CentralAuthUser for user {user} from cache object {"user":"TestUser fad1a3.1ce"}
13:25:57 ===
13:25:57 
13:25:57 9) MediaWiki\CheckUser\Tests\Integration\Maintenance\PurgeOldDataTest::testExecute with data set "Four entries to prune with no left" (1674653105, 7776000, array(1666857105, 1666877005, 1666877104, 1666777105), 0)
13:25:57 Wikimedia\Rdbms\DBQueryError: Error 42883: ERROR:  operator does not exist: timestamp with time zone < integer
13:25:57 LINE 1: ...ROM "unittest_cu_changes"    WHERE (cuc_timestamp < 16668771...
13:25:57                                                              ^
13:25:57 HINT:  No operator matches the given name and argument types. You might need to add explicit type casts.
13:25:57 
13:25:57 Function: Wikimedia\Rdbms\SelectQueryBuilder
13:25:57 Query: SELECT  COUNT(*) AS "rowcount"  FROM (SELECT  1  FROM "unittest_cu_changes"    WHERE (cuc_timestamp < 1666877105) AND (cuc_id IS NOT NULL)  ) "tmp_count"     
13:25:57 
13:25:57 
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1534
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1518
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1492
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:865
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1629
13:25:57 /workspace/src/includes/libs/rdbms/database/Database.php:1682
13:25:57 /workspace/src/includes/libs/rdbms/querybuilder/SelectQueryBuilder.php:709
13:25:57 /workspace/src/extensions/CheckUser/tests/phpunit/integration/CheckUserCommonTraitTest.php:96
13:25:57 /workspace/src/extensions/CheckUser/tests/phpunit/integration/maintenance/PurgeOldDataTest.php:80
13:25:57 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:519
13:25:57 === Logs generated by test case
13:25:57 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:25:57 [localisation] [debug] LocalisationCache using store LCStoreNull []
13:25:57 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:25:57 [CentralAuth] [debug] Loading state for global user {user} from DB {"user":"TestUser fad1a3.1cf"}
13:25:57 [CentralAuth] [debug] Loading attached wiki list for global user TestUser fad1a3.1cf from DB []
13:25:57 [CentralAuth] [debug] Loading groups for global user {user} {"user":"TestUser fad1a3.1cf"}
13:25:57 [objectcache] [debug] fetchOrRegenerate(global:centralauth-user:7a20283e63051cbc6956a728274fa7fe): miss, new value computed []
13:25:57 [CentralAuth] [debug] Loading CentralAuthUser for user {user} from cache object {"user":"TestUser fad1a3.1cf"}
13:25:57 ===
13:25:57 
13:25:57 --
13:25:57 
13:25:57 There were 4 failures:
13:25:57 
13:25:57 1) MediaWiki\CheckUser\Tests\Integration\HooksTest::testUpdateCheckUserData with data set "Log for special title with no log ID for write old" (array('20230125132505', -1, 'Log', 3, 'mw.edit', 0, 77, 858173476, 'Tony', '', '', null, 70, 71, 0, '', 0, 0, 80, 88, 0, 0, '', '', ''), 3, 'cu_changes', array('cuc_title', 'cuc_timestamp', 'cuc_namespace'), array('Log', '20230125132505', -1))
13:25:57 row #1 mismatches
13:25:57 Failed asserting that two arrays are equal.
13:25:57 --- Expected
13:25:57 +++ Actual
13:25:57 @@ @@
13:25:57  Array (
13:25:57      0 => 'Log'
13:25:57 -    1 => '20230125132505'
13:25:57 -    2 => -1
13:25:57 +    1 => '2023-01-25 13:25:05+00'
13:25:57 +    2 => '-1'
13:25:57  )
13:25:57 
13:25:57 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:2289
13:25:57 /workspace/src/extensions/CheckUser/tests/phpunit/integration/HooksTest.php:521
13:25:57 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:519
13:25:57 === Logs generated by test case
13:25:57 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:25:57 [localisation] [debug] LocalisationCache using store LCStoreNull []
13:25:57 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:25:57 [localisation] [debug] LocalisationCache::isExpired(en): cache missing, need to make one []
13:25:57 [wfDebug] [debug] LogPage::actionText - unknown action / {"private":false}
13:25:57 [MessageCache] [debug] MessageCache using store {class} {"class":"HashBagOStuff"}
13:25:57 ===
13:25:57 
13:25:57 2) MediaWiki\CheckUser\Tests\Integration\HooksTest::testUpdateCheckUserDataLogEvent with data set "Log with log ID with write old" (array('20230125132505', -1, 'Log', 3, 'mw.edit', 0, 77, 858173476, 'Tony', '', '', null, 70, 71, 0, '', 0, 0, 80, 88, 0, 0, '', '', ''), 3, 'cu_changes', array('cuc_timestamp'), array('20230125132505'))
13:25:57 row #1 mismatches
13:25:57 Failed asserting that two arrays are equal.
13:25:57 --- Expected
13:25:57 +++ Actual
13:25:57 @@ @@
13:25:57  Array (
13:25:57 -    0 => '20230125132505'
13:25:57 +    0 => '2023-01-25 13:25:05+00'
13:25:57  )
13:25:57 
13:25:57 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:2289
13:25:57 /workspace/src/extensions/CheckUser/tests/phpunit/integration/HooksTest.php:521
13:25:57 /workspace/src/extensions/CheckUser/tests/phpunit/integration/HooksTest.php:608
13:25:57 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:519
13:25:57 === Logs generated by test case
13:25:57 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:25:57 [localisation] [debug] LocalisationCache using store LCStoreNull []
13:25:57 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:25:57 [CentralAuth] [debug] Loading state for global user {user} from DB {"user":"TestUser fad1a3.164"}
13:25:57 [CentralAuth] [debug] Loading attached wiki list for global user TestUser fad1a3.164 from DB []
13:25:57 [CentralAuth] [debug] Loading groups for global user {user} {"user":"TestUser fad1a3.164"}
13:25:57 [objectcache] [debug] fetchOrRegenerate(global:centralauth-user:5c2d9ea5a25d935ef6c46719840d9d82): miss, new value computed []
13:25:57 [CentralAuth] [debug] Loading CentralAuthUser for user {user} from cache object {"user":"TestUser fad1a3.164"}
13:25:57 [localisation] [debug] LocalisationCache using store LCStoreNull []
13:25:57 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:25:57 [localisation] [debug] LocalisationCache::isExpired(en): cache missing, need to make one []
13:25:57 [wfDebug] [debug] LogPage::actionText - unknown action / {"private":false}
13:25:57 [MessageCache] [debug] MessageCache using store {class} {"class":"HashBagOStuff"}
13:25:57 ===
13:25:57 
13:25:57 3) MediaWiki\CheckUser\Tests\Integration\HooksTest::testUpdateCheckUserDataLogEvent with data set "Log with log ID with write new" (array('20230125132505', -1, 'Log', 3, 'mw.edit', 0, 77, 858173476, 'Tony', '', '', null, 70, 71, 0, '', 0, 0, 80, 88, 0, 0, '', '', ''), 768, 'cu_log_event', array('cule_timestamp'), array('20230125132505'))
13:25:57 row #1 mismatches
13:25:57 Failed asserting that two arrays are equal.
13:25:57 --- Expected
13:25:57 +++ Actual
13:25:57 @@ @@
13:25:57  Array (
13:25:57 -    0 => '20230125132505'
13:25:57 -    1 => 1
13:25:57 +    0 => '2023-01-25 13:25:05+00'
13:25:57 +    1 => '1'
13:25:57  )
13:25:57 
13:25:57 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:2289
13:25:57 /workspace/src/extensions/CheckUser/tests/phpunit/integration/HooksTest.php:521
13:25:57 /workspace/src/extensions/CheckUser/tests/phpunit/integration/HooksTest.php:608
13:25:57 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:519
13:25:57 === Logs generated by test case
13:25:57 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:25:57 [localisation] [debug] LocalisationCache using store LCStoreNull []
13:25:57 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:25:57 [CentralAuth] [debug] Loading state for global user {user} from DB {"user":"TestUser fad1a3.166"}
13:25:57 [CentralAuth] [debug] Loading attached wiki list for global user TestUser fad1a3.166 from DB []
13:25:57 [CentralAuth] [debug] Loading groups for global user {user} {"user":"TestUser fad1a3.166"}
13:25:57 [objectcache] [debug] fetchOrRegenerate(global:centralauth-user:f07fc9670a74beb7f3ad549eed5ead0f): miss, new value computed []
13:25:57 [CentralAuth] [debug] Loading CentralAuthUser for user {user} from cache object {"user":"TestUser fad1a3.166"}
13:25:57 [localisation] [debug] LocalisationCache using store LCStoreNull []
13:25:57 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:25:57 ===
13:25:57 
13:25:57 4) MediaWiki\CheckUser\Tests\Integration\HooksTest::testonRecentChange_save with data set "Log for special title with no log ID for write old" (array('20230125132505', -1, 'Log', 3, 'mw.edit', 0, 77, 858173476, 'Tony', '', '', null, 70, 71, 0, '', 0, 0, 80, 88, 0, 0, '', '', ''), 3, 'cu_changes', array('cuc_title', 'cuc_timestamp', 'cuc_namespace'), array('Log', '20230125132505', -1))
13:25:57 row #1 mismatches
13:25:57 Failed asserting that two arrays are equal.
13:25:57 --- Expected
13:25:57 +++ Actual
13:25:57 @@ @@
13:25:57  Array (
13:25:57      0 => 'Log'
13:25:57 -    1 => '20230125132505'
13:25:57 -    2 => -1
13:25:57 +    1 => '2023-01-25 13:25:05+00'
13:25:57 +    2 => '-1'
13:25:57  )
13:25:57 
13:25:57 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:2289
13:25:57 /workspace/src/extensions/CheckUser/tests/phpunit/integration/HooksTest.php:915
13:25:57 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:519
13:25:57 === Logs generated by test case
13:25:57 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:25:57 [localisation] [debug] LocalisationCache using store LCStoreNull []
13:25:57 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:25:57 [localisation] [debug] LocalisationCache::isExpired(en): cache missing, need to make one []
13:25:57 [wfDebug] [debug] LogPage::actionText - unknown action / {"private":false}
13:25:57 [MessageCache] [debug] MessageCache using store {class} {"class":"HashBagOStuff"}
13:25:57 ===
13:25:57 
13:25:57 ERRORS!
13:25:57 Tests: 979, Assertions: 2493, Errors: 9, Failures: 4, Skipped: 1.

Event Timeline

Adding Anti-Harassment as some of these are from code recently added for temporary account IP reveal.

Dreamy_Jazz renamed this task from Postgres CI failures to Postgres CI failures for CheckUser extension.Wed, Jan 25, 1:35 PM
Dreamy_Jazz moved this task from Untriaged to CheckUser on the Anti-Harassment board.

Change 883573 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Address some test failures when using a postgres database

https://gerrit.wikimedia.org/r/883573

Change 883573 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Address some test failures when using a postgres database

https://gerrit.wikimedia.org/r/883573

Ran experimental tests on a change with no DB changes and the tests passed for postgres so this is now resolved.