Cleanup Vector Skin components
Closed, DuplicatePublic
Actions

Assigned To

Authored By

	• Mabualruz
	Jan 25 2023, 2:38 PM

Project Tags

Referenced Files

None

Subscribers

Aklapper

Jdlrobson

• Mabualruz

Description

As a followup to https://phabricator.wikimedia.org/T320927

Acceptance criteria:

The new menu and dropdown component classes should handle icon/button styles (currently handled by Hooks::updateDropdownMenuData)
Hooks::updateDropdownMenuData should be removed

QA steps

No visual regressions on menus

Developer notes

Related Objects

Mentioned In: T320927: Create Dropdown and Menu Skin component classes
Mentioned Here: T320927: Create Dropdown and Menu Skin component classes

Event Timeline

• Mabualruz created this task.Jan 25 2023, 2:38 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 25 2023, 2:38 PM

• Mabualruz claimed this task.Jan 25 2023, 2:46 PM

• Mabualruz mentioned this in T320927: Create Dropdown and Menu Skin component classes.Jan 25 2023, 2:49 PM

Jdlrobson edited projects, added: Web-Team-Backlog-Archived (Web Team FY2022-23 Q3 Sprint 3); removed: Web-Team FY2022-23 Q3 Sprint 2.Jan 26 2023, 6:53 PM

Jdlrobson triaged this task as Low priority.Feb 2 2023, 6:41 PM

Jdlrobson edited projects, added: Web-Team-Backlog-Archived (Web Team FY2022-23 Q3 Sprint 4); removed: Web-Team-Backlog-Archived (Web Team FY2022-23 Q3 Sprint 3).Feb 6 2023, 11:17 PM

Jdlrobson edited projects, added: Web-Team-Backlog-Archived; removed: Web-Team-Backlog-Archived (Web Team FY2022-23 Q3 Sprint 4).Feb 23 2023, 6:37 PM

Jdlrobson moved this task from Incoming to Needs Prioritization (Tech) on the Web-Team-Backlog-Archived board.Mar 29 2023, 5:51 PM

Jdlrobson edited projects, added: Web-Team-Backlog-Archived (Needs Prioritization (Tech)); removed: Web-Team-Backlog-Archived.

Jdlrobson moved this task from Backlog to Vector code cleanup on the Web-Team-Backlog-Archived (Needs Prioritization (Tech)) board.Jun 23 2023, 9:03 PM

@Mabualruz this task is outdated (there is no updateDropdownMenuData method). Can it be declined or can you update it?

In T327914#9184465, @Jdlrobson wrote:

@Mabualruz this task is outdated (there is no updateDropdownMenuData method). Can it be declined or can you update it?

https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/876262 addressed this on parent task.

I think this should be resolved.
General cleanup and refactoring should be studied per file later if we need to move functions outside of any place.

• Mabualruz closed this task as Resolved.Sep 29 2023, 7:17 AM

• Mabualruz updated the task description. (Show Details)

Jdlrobson closed this task as a duplicate of T320927: Create Dropdown and Menu Skin component classes.Sep 29 2023, 5:15 PM

Cleanup Vector Skin componentsClosed, DuplicatePublicActions