samwilson opened https://gitlab.wikimedia.org/repos/commtech/autosuggest-sitelink/-/merge_requests/23

Avoid nesting div in span in radio button label

I'm not able to reproduce this in Firefox or Chromium, in new or old Vector. All show the full description text, e.g.:

I don't think this is likely, but it might've been because of the block level element within an inline one. I've made a MR to fix that: https://gitlab.wikimedia.org/repos/commtech/autosuggest-sitelink/-/merge_requests/23

hmonroy closed https://gitlab.wikimedia.org/repos/commtech/autosuggest-sitelink/-/merge_requests/23

Avoid nesting div in span in radio button label

hmonroy reopened https://gitlab.wikimedia.org/repos/commtech/autosuggest-sitelink/-/merge_requests/23

Avoid nesting div in span in radio button label

hmonroy merged https://gitlab.wikimedia.org/repos/commtech/autosuggest-sitelink/-/merge_requests/23

Avoid nesting div in span in radio button label

It sounds like the above changes haven't done anything to this bug. I'm still not able to reproduce it.

I did wonder if it was similar to T330221, but that's been closed as a dupe of T328069 which seems fairly different.

Could we not put some padding on that <div>? (10px probably being a bit much here..)

<span class="oo-ui-labelElement-label">
   <div>
      <a href="https://test.wikidata.org/wiki/Q229230" target="_blank">Q229230</a><span> (Crocodile)</span>
      <div style="padding-right: 10px; font-style: italic">reptile with a pointier, V-shaped snout, olive green or brown colour</div>
   </div>
</span>

https://gitlab.wikimedia.org/repos/commtech/autosuggest-sitelink/-/merge_requests/27

In T327951#8721441, @S_Mukuti wrote:

https://gitlab.wikimedia.org/repos/commtech/autosuggest-sitelink/-/merge_requests/27

I can't figure out why this test is failing — is it an issue with the test itself? I can't imagine the change caused it :-)

It looks like maybe the build script has to be run, i.e. npm run build, to also add those changes to the dist/ files.

In T327951#8723516, @Samwilson wrote:

It looks like maybe the build script has to be run, i.e. npm run build, to also add those changes to the dist/ files.

That'll do it :D

samtar updated https://gitlab.wikimedia.org/repos/commtech/autosuggest-sitelink/-/merge_requests/27

T327951

samtar merged https://gitlab.wikimedia.org/repos/commtech/autosuggest-sitelink/-/merge_requests/27

T327951

@Samwilson @TheresNoTime . Looks like we are good to go now as seen in the screenshots below! I did come across a minor issue with the Minerva skin though. It's the only skin that has a side scroller in the AutoSuggest box. Let me know if you want me to create a new ticket and close this one since the actual issue on this ticket has been resolved.

OS: macOS 13.2
Browser: Chrome 111, Firefox 111, Safari 16.3
Skins: Vector 2022, 2010, Minerva, MonoBook, Timeless
Test sites: https://test.wikipedia.org/wiki/Killer_Croc
https://test.wikipedia.org/wiki/Mandrill

Before Patch

After Patch

Minerva side scroll bar

@GMikesell-WMF Thanks! It looks like the Minerva scroll bar is a separate issue; can you create a new task for it?

@Samwilson Sounds good, I created T333598: AutoSuggest: side scroll bar in the pop up under the Minerva skin and will move this ticket to Done. Thanks again!