Change 887381 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Refine styles for linterlanguage links button.

https://gerrit.wikimedia.org/r/887381

Looks like I did miss a use-case with patches above (as Jon identified in code review)

@ovasileva this was removed from the sprint as we felt we were oversubscribed in sprint 3 and weren't show how priority for this aligned with existing priorities. This task if important can be swapped in for another task in next team standup if needed.

With the activation in all wikis last night it is shown in the German Wikipedia with German as user language this way:

With English as user language it looks better:

Yes, for Russian we have the same problem:

Today on itwiki the link is styled incorrectly but in a different way, see
élément, @media screen, display: flex;

In T328069#8620884, @Patafisik wrote:

Today on itwiki the link is styled incorrectly but in a different way, see
élément, @media screen, display: flex;

This seems due to the padding left, see @media screen .vector-pinned-container .vector-pinnable-element .vector-pinnable-header, .vector-pinned-container .vector-pinnable-element .vector-menu-heading, .vector-pinned-container .vector-pinnable-element .mw-list-item
with and without padding-left: 0; selected on frwiki:

On es.wp and pt.wp we seem to have the same problem:

While you are changing that could you add a span element to the link? That would make things more uniform. Thanks :)

Also note that due to gadgets the tools list can be rather long. And as the font is bigger then it was on the left sidebar, then the list is quite high, too high in fact.

left sidebar, small font, underline	big font, overline	small font, overline

Notice how on the old sidebar (left screen) the menu is the same height as the same menu items split in two (middle screen). So the menu is almost double in height.

Also not sure why are going with overlines. I think you will be opening another front of controversial changes. Headers are prominently underlined on Wikipedia from like... always. I think changing that is a mistake. Also note that the page is now very inconsistent.

• page title - underlined
• left actions - underlined
• right actions - underlined
• left sidebar title - underlined
• left sidebar header items - overlined
• right sidebar title - underlined?
• right sidebar header items - overlined

You have over and underlined headers right next to each other. For me it looks bad (and not only because I'm editing Wikipedia for 17 years).

But if you are going to force overlined headers please at least make those headers in the menu more distinct and make the font for items smaller. Which will also be beneficial because the page tools will have a smaller height.

This is how it looks on 15,6" notebook (cs.wikipedia.org).

1. Overlapped text.
2. I don't like also the second sliding bar but it is probably necessary for smaller displays.
3. Cat-a-lot overlaps V22 button.

Per chat with @Urbanecm.

In T328069#8641264, @Patriccck wrote:

This is how it looks on 15,6" notebook (cs.wikipedia.org).

1. Overlapped text.
2. I don't like also the second sliding bar but it is probably necessary for smaller displays.
3. Cat-a-lot overlaps V22 button.

Per chat with @Urbanecm.

I filled T330068: Incorrect padding and lack of design in the scrollbar for tools.

@alexhollender_WMF (and other's listening who have opinions) I want to play devils advocate here since this is not proving as trivial as first expected. If we want to keep iterating on this fine, but I am curious about what the long term solution is here. If we are expecting the language button to indefinitely appear in the sidebar, I'd rather spend time with the Wikidata developers working on a proper fix and removing our workarounds.

As I understand it, the existing code was meant to be a temporary workaround while the language team incorporated the feature in the language selector (that's what the code documentation says).

The language team already incorporated this feature into the language button for pages with language.

Despite this, for some reason we still have this duplicate link and we're trying to add an icon to a menu that doesn't currently support icons on a solution that is already a workaround (e.g. we're adding workarounds to our existing workarounds). This is adding technical debt and IMO a weird inconsistency with other menu items that we'll have to revisit at some later date. The edit icon is also a little confusing as it suggests that you are going to open the editor, which is not what happens - an overlay is opened.

(FWIW Jan's current patch iteration looks like this):

I think you are right and we need to remove this link from the menu and move it to the first level of ULS. Smth like that:

The link to the element in the wikidata is still in the menu and in general nothing will change.

@Iniquity I completely agree.

Note that the same link is also for connecting to an existing WD item when there is no WD connected yet.

link-button	dialog

From: https://test.wikipedia.org/wiki/Test

Ok just a note here, given the conversation above, we know that currently:

1. The ULS doesn't yet support the use-case where pages have no languages
2. The Tools menu doesn't support icons yet (given the layout issues & multiple language bugs)

So temporarily, I'll remove the icon from this link and leave it in the tools menu.

Longer-term, we hope to move this link to the ULS entirely and remove it from the menu.

Change 887381 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove skinStyles for wikibase.client module

https://gerrit.wikimedia.org/r/887381

In T328069#8631022, @Nux wrote:

Also not sure why are going with overlines. I think you will be opening another front of controversial changes. Headers are prominently underlined on Wikipedia from like... always. I think changing that is a mistake. Also note that the page is now very inconsistent.

• page title - underlined
• left actions - underlined
• right actions - underlined
• left sidebar title - underlined
• left sidebar header items - overlined
• right sidebar title - underlined?
• right sidebar header items - overlined

You have over and underlined headers right next to each other. For me it looks bad (and not only because I'm editing Wikipedia for 17 years).

But if you are going to force overlined headers please at least make those headers in the menu more distinct and make the font for items smaller. Which will also be beneficial because the page tools will have a smaller height.

@Nux thanks so much for pointing this out. There is clearly more work to be done to achieve consistency here (and thank you for noting the established patterns that have existed for quite some time). Since the Main menu and Tools menu have titles, and I put an underline under those titles, I wanted to avoid a sort of double underline situation where the section headings of the menus also had underlines. In any case there's definitely room for improvement. @KieranMcCann, as well as the Design-Systems-Team, will be working on a variety of improvements to menus, and will be sure to include this in that work.

Message from a German user on MediaWiki, March 13th:

The entry "Edit interlanguage links" in the tools navigation is cut off at the front due to an invisible edit-icon.

In T328069#8692152, @Patafisik_WMF wrote:

Message from a German user on MediaWiki, March 13th:

The entry "Edit interlanguage links" in the tools navigation is cut off at the front due to an invisible edit-icon.

@Edtadros - can you double-check this in production?

I can replicate the issue on German Wikipedia (https://de.wikipedia.org/wiki/Chris_Hipkins?useskin=vector-2022&uselang=de). A fix was merged March 7th so this should be fixed on March 16th when the fix hits production.

Hi, the cropped text of "Edit interlanguage links" I noticed in T328069#8620884 is resolved for me on itwiki, frwiki and enwiki.
But now I'm experiencing that the link "Edit interlanguage links" ("Modifier les liens interlangues" on frwiki in the video) is displayed a few fractions of a second later then other links in the menu, at the same time of other elements of the page, when purging the cache or opening a new page.

But now I'm experiencing that the link "Edit interlanguage links" ("Modifier les liens interlangues" on frwiki in the video) is displayed a few fractions of a second later then other links in the menu, at the same time of other elements of the page, when purging the cache or opening a new page.

This is expected as this is a temporary workaround while ULS is updated where we use JavaScript to inject the link which would otherwise be missing. I'll create a ticket when this is signed off to capture the remaining work.

Test Result - Prod

Status: ❌
Environment: enwiki, mediawiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: While logged in check
https://en.wikipedia.org/wiki/Chris_Hipkins

https://en.wikipedia.org/wiki/Chris_Hipkins?vectorpagetools=0

https://de.wikipedia.org/wiki/Chris_Hipkins?useskin=vector-2022&uselang=de

❌ AC2: Check sidebar of https://www.mediawiki.org/wiki/Reading/Web
Add links is a larger font size. This occurs when logged in. And similarly when the link is "Edit links"

AC2 is T315036