Page MenuHomePhabricator
Create Task
Maniphest T328089

Production error: TypeError: null is not an object (evaluating 'activeTopSection.classList')
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Seen on French and Korean wikis, at a rate of 500 in last 7 days

at activateSection https://ko.wikipedia.org/w/load.php?lang=ko&modules=ext.centralNotice.choiceData%2Cdisplay%2CgeoIP%2CimpressionDiet%2CkvStore%2CstartUp%7Cext.centralauth.ForeignApi%2Ccentralautologin%7Cext.cite.ux-enhancements%7Cext.cx.eventlogging.campaigns%7Cext.cx.model%7Cext.cx.uls.quick.actions%7Cext.eventLogging%2CnavigationTiming%2Cpopups%2CwikimediaEvents%7Cext.growthExperiments.SuggestedEditSession%7Cext.uls.common%2Ccompactlinks%2Cinterface%2Cpreferences%2Cwebfonts%7Cjquery%2Coojs%2Coojs-router%2Csite%7Cjquery.client%2Ccookie%2CmakeCollapsible%2Ctablesorter%2CtextSelection%7Cjquery.uls.data%7Cmediawiki.ForeignApi%2CString%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2Ccookie%2Cexperiments%2CjqueryMsg%2Clanguage%2Cstorage%2Ctoc%2Cuser%2Cutil%2CvisibleTimeout%7Cmediawiki.ForeignApi.core%7Cmediawiki.editfont.styles%7Cmediawiki.language.months%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Cmmv.bootstrap%2Chead%7Cmmv.bootstrap.autostart%7Cmw.cx.SiteMapper%7Coojs-ui.styles.icons-interactions%7Cskins.vector.es6%2Cjs%7Cskins.vector.icons.js&skin=vector-2022&version=bav1h:604:580
at changeActiveSection https://ko.wikipedia.org/w/load.php?lang=ko&modules=ext.centralNotice.choiceData%2Cdisplay%2CgeoIP%2CimpressionDiet%2CkvStore%2CstartUp%7Cext.centralauth.ForeignApi%2Ccentralautologin%7Cext.cite.ux-enhancements%7Cext.cx.eventlogging.campaigns%7Cext.cx.model%7Cext.cx.uls.quick.actions%7Cext.eventLogging%2CnavigationTiming%2Cpopups%2CwikimediaEvents%7Cext.growthExperiments.SuggestedEditSession%7Cext.uls.common%2Ccompactlinks%2Cinterface%2Cpreferences%2Cwebfonts%7Cjquery%2Coojs%2Coojs-router%2Csite%7Cjquery.client%2Ccookie%2CmakeCollapsible%2Ctablesorter%2CtextSelection%7Cjquery.uls.data%7Cmediawiki.ForeignApi%2CString%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2Ccookie%2Cexperiments%2CjqueryMsg%2Clanguage%2Cstorage%2Ctoc%2Cuser%2Cutil%2CvisibleTimeout%7Cmediawiki.ForeignApi.core%7Cmediawiki.editfont.styles%7Cmediawiki.language.months%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Cmmv.bootstrap%2Chead%7Cmmv.bootstrap.autostart%7Cmw.cx.SiteMapper%7Coojs-ui.styles.icons-interactions%7Cskins.vector.es6%2Cjs%7Cskins.vector.icons.js&skin=vector-2022&version=bav1h:606:780
at https://ko.wikipedia.org/w/load.php?lang=ko&modules=ext.centralNotice.choiceData%2Cdisplay%2CgeoIP%2CimpressionDiet%2CkvStore%2CstartUp%7Cext.centralauth.ForeignApi%2Ccentralautologin%7Cext.cite.ux-enhancements%7Cext.cx.eventlogging.campaigns%7Cext.cx.model%7Cext.cx.uls.quick.actions%7Cext.eventLogging%2CnavigationTiming%2Cpopups%2CwikimediaEvents%7Cext.growthExperiments.SuggestedEditSession%7Cext.uls.common%2Ccompactlinks%2Cinterface%2Cpreferences%2Cwebfonts%7Cjquery%2Coojs%2Coojs-router%2Csite%7Cjquery.client%2Ccookie%2CmakeCollapsible%2Ctablesorter%2CtextSelection%7Cjquery.uls.data%7Cmediawiki.ForeignApi%2CString%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2Ccookie%2Cexperiments%2CjqueryMsg%2Clanguage%2Cstorage%2Ctoc%2Cuser%2Cutil%2CvisibleTimeout%7Cmediawiki.ForeignApi.core%7Cmediawiki.editfont.styles%7Cmediawiki.language.months%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Cmmv.bootstrap%2Chead%7Cmmv.bootstrap.autostart%7Cmw.cx.SiteMapper%7Coojs-ui.styles.icons-interactions%7Cskins.vector.es6%2Cjs%7Cskins.vector.icons.js&skin=vector-2022&version=bav1h:582:449
at https://ko.wikipedia.org/w/load.php?lang=ko&modules=ext.centralNotice.choiceData%2Cdisplay%2CgeoIP%2CimpressionDiet%2CkvStore%2CstartUp%7Cext.centralauth.ForeignApi%2Ccentralautologin%7Cext.cite.ux-enhancements%7Cext.cx.eventlogging.campaigns%7Cext.cx.model%7Cext.cx.uls.quick.actions%7Cext.eventLogging%2CnavigationTiming%2Cpopups%2CwikimediaEvents%7Cext.growthExperiments.SuggestedEditSession%7Cext.uls.common%2Ccompactlinks%2Cinterface%2Cpreferences%2Cwebfonts%7Cjquery%2Coojs%2Coojs-router%2Csite%7Cjquery.client%2Ccookie%2CmakeCollapsible%2Ctablesorter%2CtextSelection%7Cjquery.uls.data%7Cmediawiki.ForeignApi%2CString%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2Ccookie%2Cexperiments%2CjqueryMsg%2Clanguage%2Cstorage%2Ctoc%2Cuser%2Cutil%2CvisibleTimeout%7Cmediawiki.ForeignApi.core%7Cmediawiki.editfont.styles%7Cmediawiki.language.months%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Cmmv.bootstrap%2Chead%7Cmmv.bootstrap.autostart%7Cmw.cx.SiteMapper%7Coojs-ui.styles.icons-interactions%7Cskins.vector.es6%2Cjs%7Cskins.vector.icons.js&skin=vector-2022&version=bav1h:612:275

Example page: https://fr.wikipedia.org/wiki/Province_de_Luxembourg#/media/Fichier:Province_of_Luxembourg_composite_(9_in_1)-fr.png

Details

SubjectRepoBranchLines +/-
Add check for activeTopSection in activateSectionmediawiki/skins/Vectormaster+5 -2
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Jan 26 2023, 10:59 PM
Restricted Application added subscribers: revi, Aklapper. · View Herald TranscriptJan 26 2023, 10:59 PM
Jdlrobson triaged this task as High priority.Jan 26 2023, 10:59 PM
Jdlrobson moved this task from Incoming to Table of Contents on the Desktop Improvements (Vector 2022) board.Jan 27 2023, 5:14 PM
Umherirrender added a project: JavaScript.Jan 27 2023, 7:09 PM
Jdlrobson updated the task description. (Show Details)Jan 30 2023, 6:17 PM
ovasileva set the point value for this task to 3.Jan 30 2023, 6:54 PM
ovasileva moved this task from Incoming to Ready for Development on the Web-Team FY2022-23 Q3 Sprint 2 board.
bwang moved this task from Ready for Development to Doing on the Web-Team FY2022-23 Q3 Sprint 2 board.Jan 30 2023, 7:17 PM
Jdlrobson assigned this task to bwang.Jan 30 2023, 9:24 PM
bwang moved this task from Doing to Code Review on the Web-Team FY2022-23 Q3 Sprint 2 board.Jan 30 2023, 10:03 PM
gerritbot added a comment.Jan 30 2023, 10:03 PM

Change 884997 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Add check for activeTopSection in activateSection

https://gerrit.wikimedia.org/r/884997

gerritbot added a project: Patch-For-Review.Jan 30 2023, 10:03 PM
bwang removed bwang as the assignee of this task.Jan 30 2023, 10:03 PM
bwang subscribed.
Jdlrobson claimed this task.Jan 30 2023, 10:19 PM
Jdlrobson moved this task from Code Review to Blocked on Others on the Web-Team FY2022-23 Q3 Sprint 2 board.Jan 30 2023, 11:18 PM

@bwang should we QA this in logstash (by verifying the fix) or were you able to find a way to reliably replicate this issue?

gerritbot added a comment.Jan 30 2023, 11:36 PM

Change 884997 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Add check for activeTopSection in activateSection

https://gerrit.wikimedia.org/r/884997

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.21; 2023-01-30).Jan 31 2023, 12:01 AM
Maintenance_bot removed a project: Patch-For-Review.Jan 31 2023, 12:30 AM
bwang added a comment.Jan 31 2023, 5:33 PM

@Jdlrobson Logstash I believe, I couldnt replicate locally due to it being a browser issue, and i couldnt get browser stack local tunneling to work, so after a while I just opted to go for the simple fix

bwang moved this task from Blocked on Others to QA on the Web-Team FY2022-23 Q3 Sprint 2 board.Jan 31 2023, 5:33 PM
Jdlrobson closed this task as Resolved.Feb 6 2023, 6:37 PM
Jdlrobson moved this task from QA to Ready for Signoff on the Web-Team FY2022-23 Q3 Sprint 2 board.

I'm not seeing any errors for the latest deploy branch. All remaining issues seem to be coming from older deploy branches (which I've filtered out using error_context_version
{F36762597}

Jdlrobson reopened this task as Open.Mar 10 2023, 12:58 AM
Jdlrobson added a project: Web-Team-Backlog.

This seems to be occurring again? Did something change?

Jdlrobson closed this task as Resolved.Mar 10 2023, 6:21 PM

My mistake. I looked a bit closer and it seems the errors are for older MediaWiki versions (1.40.0-wmf.8, 1.40.0-wmf.5) so presumably tabs that have been open a long time!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL