Page MenuHomePhabricator

SearchVue messages Tutorial-popup-text2 and Tutorial-popup-preferences must be combined
Closed, DuplicatePublicBUG REPORT

Description

The SearchVue messages Tutorial-popup-text2 and Tutorial-popup-preferences are supposed to be combined into one messages. Currently, they are concatenated in run time:

<template v-else>
        <p>
                {{ $i18n('tutorial-popup-text1').text() }}
        </p>
        <p>
                {{ $i18n('tutorial-popup-text2').text() }} <a :href="url" target="_blank">
                        {{ $i18n('tutorial-popup-preferences').text() }}
                </a>.
        </p>
</template>

In the MediaWiki internationalization jargon, this is called "a lego message", and it must not be used. It cannot work correctly in Russian, Bengali, Hebrew and probably many other languages, where the word "preferences" is not in the end of the sentence. In addition, the grammatical form of both messages would be different when they are combined, and currently, it's impossible to know this because the relationship between them is not documented.

My recommendation:

  1. Change tutorial-popup-text2 to something like this: You can turn previews on and off in the search $1. (And note that in translations, $1 can be anywhere in the sentence: beginning, middle, or end.)
  2. Insert the <a> markup in run time.
  3. Document $1 in qqq for tutorial-popup-text2: "$1 is the message {{msg-mw|tutorial-popup-preferences}}".
  4. Document in the qqq for tutorial-popup-preferences how is this message used: "Inserted as a parameter into {{msg-mw|tutorial-popup-text2}}".

This was originally reported on translatewiki: https://translatewiki.net/wiki/Thread:Support/MediaWiki:Tutorial-popup-text2/en