Page MenuHomePhabricator
Create Task
Maniphest T328144

Drop PNG fallback for SVG icons / etc. across all Wikimedia products
Closed, ResolvedPublic
Actions

Assigned To
Volker_E
Authored By
Jdforrester-WMF
Jan 27 2023, 3:52 PM
Tags
Referenced Files
None
Subscribers
Aklapper
Jdforrester-WMF
jhsoby
Lucas_Werkmeister_WMDE
Michael
Nikerabbit
Nikki
View All 9 Subscribers
Tokens
"Orange Medal" token, awarded by Krinkle.

Description

Per https://www.mediawiki.org/wiki/Template:Compatibility_browser we no longer have any browsers in "Basic" / "Grade C" support that don't handle SVGs and in particular linear-gradient rules.

Let's confirm we're OK to make this change, locate all the places we're still doing this, and implement?
Update 2023: We are ok. Let's do it!

[Note: This does not apply to user-contributed SVGs e.g. from Commons, which are handled differently for security reasons.]

Acceptance criteria for done

Note, we're leaving skin CologneBlue untouched, as it's still supporting MW 1.36

Misc:

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
thiemowmde subscribed.Jan 27 2023, 8:37 PM
thiemowmde added a subscriber: Volker_E.Jan 27 2023, 8:40 PM

I just got a green light from @Volker_E. We can remove both the linear-gradient hack as well as the .png fallbacks. Many have been removed already, see the patches in T306486: Remove IE <= 10, Firefox <= 38, Android <= 4 CSS hacks and workarounds in core, extensions and skins.

thiemowmde added a parent task: T306486: Remove IE <= 10, Firefox <= 38, Android <= 4 CSS hacks and workarounds in core, extensions and skins.Jan 27 2023, 8:41 PM
Michael subscribed.Jan 30 2023, 9:35 AM
Lucas_Werkmeister_WMDE mentioned this in T329127: Remove remaining SVG fallback hacks in MediaWiki core.Feb 8 2023, 9:38 AM
Jdforrester-WMF added a subtask: T329127: Remove remaining SVG fallback hacks in MediaWiki core.Feb 8 2023, 12:56 PM
Jdforrester-WMF closed subtask T329127: Remove remaining SVG fallback hacks in MediaWiki core as Resolved.Feb 8 2023, 1:15 PM
Volker_E added projects: Technical-Debt, CSS.Feb 8 2023, 1:28 PM
Volker_E updated the task description. (Show Details)
Volker_E added projects: MediaWiki-extensions-Cargo, Maps (Kartographer), MediaWiki-extensions-TwnMainPage, ArticleFeedbackv5, MediaWiki-extensions-Translate.Feb 8 2023, 1:44 PM
Krinkle added a project: Performance-Team (Radar).Feb 19 2023, 9:28 PM
Krinkle awarded a token.
Krinkle moved this task from Limbo to Perf recommendation on the Performance-Team (Radar) board.
gerritbot added a comment.Apr 23 2023, 5:02 PM

Change 910541 had a related patch set uploaded (by Techwizzie; author: Techwizzie):

[mediawiki/extensions/Cargo@master] Drop fallback code for SVG handling

https://gerrit.wikimedia.org/r/910541

gerritbot added a project: Patch-For-Review.Apr 23 2023, 5:02 PM
gerritbot added a comment.Apr 23 2023, 9:56 PM

Change 910541 merged by jenkins-bot:

[mediawiki/extensions/Cargo@master] Drop fallback code for SVG handling

https://gerrit.wikimedia.org/r/910541

Maintenance_bot removed a project: Patch-For-Review.Apr 23 2023, 10:10 PM
Nikerabbit moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.May 22 2023, 11:22 AM
thiemowmde removed projects: Maps (Kartographer), MediaWiki-extensions-Cargo.May 24 2023, 10:53 AM

The remaining code in Maps (Kartographer) is in an external library.

gerritbot added a comment.May 24 2023, 11:21 AM

Change 922818 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/ArticleFeedbackv5@master] Drop .png fallbacks where an .svg file is present

https://gerrit.wikimedia.org/r/922818

gerritbot added a project: Patch-For-Review.May 24 2023, 11:21 AM
thiemowmde mentioned this in T337456: ArticleFeedback .svg icons contain 100 kb unused code each.May 25 2023, 8:33 AM
jhsoby subscribed.May 31 2023, 10:44 AM
Nikki subscribed.May 31 2023, 11:48 AM
gerritbot added a comment.Jun 1 2023, 3:00 PM

Change 922818 merged by jenkins-bot:

[mediawiki/extensions/ArticleFeedbackv5@master] Drop .png fallbacks where an .svg file is present

https://gerrit.wikimedia.org/r/922818

Maintenance_bot removed a project: Patch-For-Review.Jun 1 2023, 3:10 PM
Volker_E added projects: MonoBook, Nostalgia, MediaWiki-extensions-Cargo, UniversalLanguageSelector, Wikibase (3rd party installations), MediaWiki-extensions-CentralNotice, MediaWiki-extensions-ReadingList.Jun 4 2023, 11:40 AM
Volker_E updated the task description. (Show Details)
Restricted Application added a project: [DEPRECATED] wdwb-tech. · View Herald TranscriptJun 4 2023, 11:40 AM
gerritbot added a comment.Jun 4 2023, 11:41 AM

Change 926729 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/MonoBook@master] Drop fallback code for SVG handling

https://gerrit.wikimedia.org/r/926729

gerritbot added a project: Patch-For-Review.Jun 4 2023, 11:41 AM
gerritbot added a comment.Jun 4 2023, 11:44 AM

Change 926730 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/Nostalgia@master] Drop fallback code and images for SVG handling

https://gerrit.wikimedia.org/r/926730

Maintenance_bot added a project: Wikidata.Jun 4 2023, 11:45 AM
Volker_E updated the task description. (Show Details)Jun 4 2023, 11:46 AM
gerritbot added a comment.Jun 4 2023, 11:54 AM

Change 926731 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/Kartographer@master] Drop fallback code and images for SVG handling

https://gerrit.wikimedia.org/r/926731

gerritbot added a comment.Jun 4 2023, 6:23 PM

Change 926729 merged by jenkins-bot:

[mediawiki/skins/MonoBook@master] Drop fallback code for SVG handling

https://gerrit.wikimedia.org/r/926729

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).Jun 4 2023, 7:00 PM
Volker_E updated the task description. (Show Details)Jun 5 2023, 12:09 PM
Volker_E updated the task description. (Show Details)Jun 5 2023, 12:21 PM
gerritbot added a comment.Jun 5 2023, 12:31 PM

Change 926730 merged by jenkins-bot:

[mediawiki/skins/Nostalgia@master] Drop fallback code and images for SVG handling

https://gerrit.wikimedia.org/r/926730

Volker_E updated the task description. (Show Details)Jun 5 2023, 12:39 PM
gerritbot added a comment.Jun 5 2023, 12:45 PM

Change 927174 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/ReadingLists@master] Drop fallback code for SVG handling

https://gerrit.wikimedia.org/r/927174

Volker_E updated the task description. (Show Details)Jun 5 2023, 12:52 PM
gerritbot added a comment.Jun 5 2023, 2:13 PM

Change 926731 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Kartographer@master] Drop fallback code and images for SVG handling

Reason:

Whoops. leaflet.draw is an external library. Hence the lib/ folder. While we could we usually don't manually fiddle with these. I hope that's ok. Please let me know if there are other reasons.

https://gerrit.wikimedia.org/r/926731

gerritbot added a comment.Jun 5 2023, 2:16 PM

Change 927174 merged by jenkins-bot:

[mediawiki/extensions/ReadingLists@master] Drop fallback code for SVG handling

https://gerrit.wikimedia.org/r/927174

Nikerabbit subscribed.Jun 5 2023, 2:44 PM

Note, that extensions MediaWiki-extensions-Translate and UniversalLanguageSelector are supporting MW 1.38 as per their two stable version support approach. Until they are supporting 1.39, the browser support and with that transparent, transparent hack should remain.

Since this does not break compatibility with older versions of MediaWiki, it's technically in a gray area. It is a similar case with PHP version support. We increased the minimum supported PHP version to 7.4 recently even though we support MediaWiki versions that also support PHP 7.3.
Code search indicates that we have already removed the hack for some JavaScript-only features. I would be fine for removing it from the rest as well.

Volker_E updated the task description. (Show Details)Jun 5 2023, 4:17 PM
Krinkle removed a project: ArticleFeedbackv5.Jun 5 2023, 4:52 PM
Krinkle updated the task description. (Show Details)
Krinkle edited projects, added Wikimedia-Performance-recommendation; removed Performance-Team (Radar).Aug 18 2023, 8:41 PM
Volker_E updated the task description. (Show Details)Nov 3 2023, 2:25 AM
Nikerabbit mentioned this in T354613: Drop PNG fallback for SVG icons in Translate.Jan 9 2024, 11:32 AM
Nikerabbit mentioned this in T354614: Drop PNG fallback for SVG icons in UniversalLanguageSelector.
Nikerabbit mentioned this in T354615: Drop PNG fallback for SVG icons in TwnMainPage.
Nikerabbit added subtasks: T354615: Drop PNG fallback for SVG icons in TwnMainPage, T354614: Drop PNG fallback for SVG icons in UniversalLanguageSelector, T354613: Drop PNG fallback for SVG icons in Translate.
Nikerabbit removed projects: UniversalLanguageSelector, MediaWiki-extensions-Translate, MediaWiki-extensions-TwnMainPage.Jan 9 2024, 11:35 AM
Nikerabbit updated the task description. (Show Details)
Volker_E updated the task description. (Show Details)Jan 9 2024, 11:58 AM
gerritbot added a comment.Jan 9 2024, 12:37 PM

Change 989135 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/Wikibase@master] Drop fallback code and images for SVG handling

https://gerrit.wikimedia.org/r/989135

Volker_E removed projects: MediaWiki-extensions-CentralNotice, [DEPRECATED] wdwb-tech.Jan 9 2024, 12:43 PM
Volker_E updated the task description. (Show Details)
Restricted Application added a project: wmde-wikidata-tech. · View Herald TranscriptJan 9 2024, 12:43 PM
gerritbot added a comment.Jan 9 2024, 12:44 PM

Change 989137 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/WikibaseLexeme@master] Drop fallback code and images for SVG handling

https://gerrit.wikimedia.org/r/989137

Volker_E updated the task description. (Show Details)Jan 9 2024, 12:44 PM
Volker_E removed a subtask: T354614: Drop PNG fallback for SVG icons in UniversalLanguageSelector.
Volker_E removed a subtask: T354615: Drop PNG fallback for SVG icons in TwnMainPage.Jan 9 2024, 12:48 PM
gerritbot added a comment.Jan 9 2024, 1:01 PM

Change 989139 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/Wikidata.org@master] Drop fallback code and images for SVG handling

https://gerrit.wikimedia.org/r/989139

Volker_E updated the task description. (Show Details)Jan 9 2024, 1:12 PM
gerritbot added a comment.Jan 9 2024, 3:46 PM

Change 989139 merged by jenkins-bot:

[mediawiki/extensions/Wikidata.org@master] Drop fallback code and images for SVG handling

https://gerrit.wikimedia.org/r/989139

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.14; 2024-01-16).Jan 9 2024, 5:00 PM
Volker_E updated the task description. (Show Details)Jan 9 2024, 5:22 PM
gerritbot added a comment.Jan 11 2024, 2:56 PM

Change 989137 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Drop fallback code and images for SVG handling

https://gerrit.wikimedia.org/r/989137

Volker_E updated the task description. (Show Details)Jan 11 2024, 3:02 PM
gerritbot added a comment.Jan 11 2024, 3:38 PM

Change 989135 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Drop fallback code and images for SVG handling

https://gerrit.wikimedia.org/r/989135

Izno moved this task from Backlog to Change CSS on the CSS board.Feb 1 2024, 2:49 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Feb 9 2024, 2:56 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
Lucas_Werkmeister_WMDE added a comment.Feb 9 2024, 3:02 PM

@Volker_E: I just noticed that WikibaseDataValuesValueView is still open (it accidentally had a copy of the Wikidata.org Gerrit change; I don’t see a patch for this repo on Gerrit); do you want to upload a fix for that so I can +2 it? :)

Volker_E added a subscriber: LucasWerkmeister.Feb 9 2024, 3:33 PM

@LucasWerkmeister As far as I can see, the only usage in WikibaseDataValuesValueView is in the jquer.ui.inputextender external library, something that we're not caring about in this task.

Volker_E closed this task as Resolved.Feb 9 2024, 3:39 PM
Volker_E claimed this task.
Volker_E removed a project: Patch-For-Review.
Volker_E updated the task description. (Show Details)
Volker_E updated the task description. (Show Details)
Lucas_Werkmeister_WMDE removed a subscriber: LucasWerkmeister.EditedFeb 9 2024, 3:56 PM
In T328144#9529411, @Volker_E wrote:

@LucasWerkmeister As far as I can see, the only usage in WikibaseDataValuesValueView is in the jquer.ui.inputextender external library, something that we're not caring about in this task.

I don’t think that’s an external library, it’s just a confusingly named file. (@author H. Snater < mediawiki@snater.com > is a former WMDE employee on the Wikidata team.) We have plenty of files with these confusing names in Wikibase :/

Edit: all the Google results for "jquery.ui.inputextender" are related to Wikibase too.

Volker_E added a comment.Feb 9 2024, 4:56 PM

Ok, it's in the lib folder, so I assume from architecture logic elsewhere that it's an external library and it would have to be tackled in that library 'upstream'. If that's not the case, then the whole file should not live there IMO.
How would you suggest to resolve this?

gerritbot added a comment.Feb 9 2024, 5:02 PM

Change 999933 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[data-values/value-view@master] Drop fallback code and images for SVG handling

https://gerrit.wikimedia.org/r/999933

gerritbot added a project: Patch-For-Review.Feb 9 2024, 5:02 PM

Change 999934 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Bump wikibase-data-values-value-view to HEAD

https://gerrit.wikimedia.org/r/999934

Lucas_Werkmeister_WMDE added a comment.Feb 9 2024, 5:09 PM

I uploaded two changes for it now, if you can review them that would be great :)

gerritbot added a comment.Feb 9 2024, 6:03 PM

Change 999933 merged by jenkins-bot:

[data-values/value-view@master] Drop fallback code and images for SVG handling

https://gerrit.wikimedia.org/r/999933

gerritbot added a comment.Feb 9 2024, 6:34 PM

Change 999934 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Bump wikibase-data-values-value-view to HEAD

https://gerrit.wikimedia.org/r/999934

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.18; 2024-02-13); removed MW-1.42-notes (1.42.0-wmf.14; 2024-01-16).Feb 9 2024, 8:01 PM
Volker_E closed subtask T354613: Drop PNG fallback for SVG icons in Translate as Resolved.Mar 7 2024, 11:08 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL