Page MenuHomePhabricator
Create Task
Maniphest T328157

Sister project icons overlap text on frp.wikipedia.org
Closed, ResolvedPublicBUG REPORT
Actions

Description

URL: https://frp.wikipedia.org/wiki/Vouiquip%C3%A8dia:Re%C3%A7ua_princip%C3%A2la
Issue is in Wikibase extension (couldn't find write phabricator tag for that)

Broken out from T327717

In T327717#8564249, @Patafisik wrote:

Hi, FYI there is a similar issue on frp.wikipedia for sister projects icons
actually

Screenshot 2023-01-27 at 12-29-01 Vouiquipèdia Lo Câfè du Velâjo — Vouiquipèdia.png (244×890 px, 28 KB)

with ?vectorpagetools=1

Screenshot 2023-01-27 at 12-32-46 Vouiquipèdia Lo Câfè du Velâjo — Vouiquipèdia.png (575×914 px, 62 KB)

Seems related to https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/901de4188b3375b37646c4b09084b3a10a6a3105/client/includes/Hooks/OtherProjectsSidebarGenerator.php#159

Related Objects

Event Timeline

Jdlrobson created this task.Jan 27 2023, 5:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 27 2023, 5:54 PM
Jdlrobson mentioned this in T327717: Page tools: Support icon for Atom link.Jan 27 2023, 5:55 PM
Nikki edited projects, added: Vector (legacy skin); removed: Wikidata, Wikidata-Campsite.Feb 5 2023, 2:33 PM
Nikki subscribed.

But the line of code you linked hasn't been touched since 2014...

I looked at the Wayback Machine to find when it was last working and see how it looked then and it appears the sidebar on that wiki has been broken for a couple of years. It was working on 2020-10-13 and was broken on 2020-10-24.

It appears that this issue has nothing to do with Wikibase. Wikibase does not add those icons, they're added by on-wiki CSS in https://frp.wikipedia.org/wiki/MediaWiki:Vector.css. That CSS was broken by the removal of the "body" class in the Vector skin in this commit.

Jdlrobson edited projects, added: Local-Wiki-Template-And-Gadget-Issues; removed: Vector (legacy skin).Feb 6 2023, 4:41 PM

Thanks @Nikki for pointing us in the right direction!

Jdlrobson closed this task as Resolved.Feb 6 2023, 5:13 PM
Jdlrobson claimed this task.

Fixed in https://frp.wikipedia.org/w/index.php?title=MediaWiki%3AVector.css&diff=218578&oldid=176173

Aklapper renamed this task from Sister project icons overlap text to Sister project icons overlap text on frp.wikipedia.org.Feb 6 2023, 6:55 PM
Una_tantum added a comment.EditedMay 24 2023, 2:08 PM

Hi @Jdlrobson ,
when the Tool menu is open the layout looks fine, but when the menu is pinned the layout is broken.

Screenshot 2023-05-24 at 16-05-18 Vouiquipèdia Lo Câfè du Velâjo — Vouiquipèdia.png (2,543×1,287 px, 331 KB)

Screenshot 2023-05-24 at 16-05-08 Vouiquipèdia Lo Câfè du Velâjo — Vouiquipèdia.png (2,543×1,287 px, 340 KB)

Jdlrobson added a comment.May 26 2023, 6:39 AM

https://frp.wikipedia.org/w/index.php?title=MediaWiki%3AVector.css&diff=219880&oldid=218580

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits