Page MenuHomePhabricator

Replace MessageCache__get hook with a way to pre-register message keys
Closed, ResolvedPublic

Description

The MessageCache__get hook allows changing messages on the fly; it is invoked every time a new message is looked up, which happens several hundreds of times per request.

Typically a hook handler only cares about changing a small number of keys, but has to check every time a message is loaded whether it is one of those. It would make more sense to have a hook which is called at most once per request and allows handlers to register what keys they care about (and maybe map them to callbacks).

This would help with performance; it would also help with reducing false positives where MessageCache__get is called a lot so for requests that time out there will be a nontrivial chance that they happen to time out in this hook and create noise on unrelated dashboards.

Event Timeline

Change 884416 had a related patch set uploaded (by Mainframe98; author: Mainframe98):

[mediawiki/core@master] MessageCache: Add a new hook for more performant override fetching

https://gerrit.wikimedia.org/r/884416

Change 884418 had a related patch set uploaded (by Mainframe98; author: Mainframe98):

[mediawiki/extensions/WikimediaMessages@master] Use MessageCacheFetchOverrides hook

https://gerrit.wikimedia.org/r/884418

Change 884416 merged by jenkins-bot:

[mediawiki/core@master] MessageCache: Add a new hook for more performant override fetching

https://gerrit.wikimedia.org/r/884416

Change 900809 had a related patch set uploaded (by Mainframe98; author: Mainframe98):

[mediawiki/extensions/GrowthExperiments@master] Use MessageCacheFetchOverrides hook

https://gerrit.wikimedia.org/r/900809

Change 900809 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Use MessageCacheFetchOverrides hook

https://gerrit.wikimedia.org/r/900809

Change 884418 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] Use MessageCacheFetchOverrides hook

https://gerrit.wikimedia.org/r/884418

Change #1058243 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Hooks: Hard deprecate the MessageCache::get hook

https://gerrit.wikimedia.org/r/1058243

Change #1058243 merged by jenkins-bot:

[mediawiki/core@master] Hooks: Hard deprecate the MessageCache::get hook

https://gerrit.wikimedia.org/r/1058243