Page MenuHomePhabricator

Page tools: Certain pages with large elements and limited width disabled break the grid
Closed, DuplicatePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • Viewing the page requires horizontal scrolling

Screen Shot 2023-01-30 at 8.33.09 AM.png (1×2 px, 397 KB)

{F36556059}

Developer notes

The pre tag seems to be the culprit here. Setting max-width: 400px; on it fixes the page, but we need a more generic solution.

This also occurs with large tables and images.

Event Timeline

Xaosflux renamed this task from Vector-2022 the diff table overflows the width of the page when wide page elements are in the page to Vector-2022 diff table overflows the width of the page when wide page elements are in the page content.Jan 28 2023, 1:10 PM
Xaosflux renamed this task from Vector-2022 diff table overflows the width of the page when wide page elements are in the page content to Vector-2022 overflows the width of the page everywhere when wide page elements are in the page content.Jan 28 2023, 1:30 PM
Xaosflux updated the task description. (Show Details)
Xaosflux updated the task description. (Show Details)

This is happening in safe mode as well. See https://en.wikipedia.org/wiki/Wikipedia:Catalogue_of_CSS_classes?useskin=vector-2022&safemode=1

This started on 27 January 2023 (UTC time).

I believe that it happens only with "limited width mode" disabled, while logged in. Safe mode apparently does not use default preferences. I can replicate it in Firefox and Brave for Mac OS.

This is a somewhat urgent problem. I have found that it is affecting between 1 in 20 and 1 in 10 pages that I visit. The scroll width is up to 10x the width of my browser window.

Contrary to my earlier hypothesis, I am able to make this happen on a few pages with limited width mode enabled. It happens much less often, though, FWIW.

I have wondered for a while why it is a good idea to install software changes on Friday, right before all of the developers take two days off. Wikipedia is a 24/7 web site. It seems like there should at least be someone who looks at these bug reports seven days a week to see if anything major has been broken, especially when there are frequent updates to a new beta product that the developers presumably want to perform very well.

20230130.png (1×1 px, 193 KB)

Text overflowing on WP:VPT, on clicking full page source editor as seen today.

I concur with Jonesey95, Wikipedia is a 24/7 site. If you want to add updates, do it on Mon-Wed, or have at least one person capable of rolling back things on weekends if they are not working as intended. Alternatively, just roll back Vector 2022 entirely, and come back when you're done dealing with all these miserable bugs.

I can reproduce it in diff when logged in, using Firefox both with the toggle on and off.

Screenshot 2023-01-30 at 15-04-34 Brahmic scripts Difference between revisions - Wikipedia.png (1×2 px, 194 KB)

Screenshot 2023-01-30 at 15-04-42 Brahmic scripts Difference between revisions - Wikipedia.png (1×2 px, 188 KB)

Screenshot 2023-01-30 at 15-05-08 Brahmic scripts Difference between revisions - Wikipedia.png (1×2 px, 175 KB)

Using Chrome only with the limited width selected via the toggle.

Brahmic scripts_ Difference between revisions - Wikipedia - Google Chrome 30_01_2023 15_13_34.png (1×2 px, 185 KB)

Brahmic scripts_ Difference between revisions - Wikipedia - Google Chrome 30_01_2023 15_13_42.png (1×2 px, 202 KB)

This is another instance of https://www.mediawiki.org/wiki/Recommendations_for_mobile_friendly_articles_on_Wikimedia_wikis which has long been an issue for mobile users, and one of the main sources of friction for making Wikipedia truly a responsive design. With the fixed width it is now showing up on Vector 2022 skins.

To be clear there is no magic fix here - please notice the bug shows up on Minerva and Timeless (when JavaScript and Timeless workaround is disabled).The only difference with those is they adjust as you resize the window small.

Up until now we've advised https://www.mediawiki.org/wiki/Recommendations_for_mobile_friendly_articles_on_Wikimedia_wikis#Wrap_wide_images_and_tables which is an editorial fix, which I think is preferable (we have Wide image template why not Wide table?)

I think a more brute force way of doing this would be to update the parser so tables are wrapped in divs automatically but that would be pretty disruptive change (for example it doesn't seem compatible with sticky headers - those would no longer work).

I believe this is a duplicate of T66577 . (See also https://phabricator.wikimedia.org/T66577#8567450)

The above explanation does not account for https://en.wikipedia.org/wiki/Wikipedia:Catalogue_of_CSS_classes?useskin=vector-2022&safemode=1 working reasonably when I enable limited-width mode, but being very wide when I disable limited-width mode.

I get that there is a big picture here, but that bug is from 2014. This is a different bug. This bug started happening on Friday, and it is widespread. Please roll back whatever change caused this problem on Friday.

Jdlrobson renamed this task from Vector-2022 overflows the width of the page everywhere when wide page elements are in the page content to Certain pages with PRE tags and limited width disable break the grid.Jan 30 2023, 4:34 PM
Jdlrobson updated the task description. (Show Details)
ovasileva triaged this task as Medium priority.Jan 30 2023, 4:37 PM

Seems like we're mixing 2 issues here.

  • The diff issue is a table issue and is described in T66577

https://en.wikipedia.org/w/index.php?title=Brahmic_scripts&diff=1135922907&oldid=1132384454&diff=&diffmode=source&useskin=vector-2022

I can't replicate this locally on master or the current deployment branch (yet). It seems SyntaxHighlight_GeSHi and DiscussionTools do something to this page that might be interfering but I've not been able to replicate that yet.

It's not just pre. An image with the appropriate wide image template as explicitly recommended doesn't fix the issue. I left this on another task discussing an issue in V22 but since you think it's one cause, it's not. https://en.wikipedia.org/wiki/Sixth_Amendment_to_the_United_States_Constitution?useskin=vector-2022 with limited width turned off exhibits the same issue.

Jdlrobson renamed this task from Certain pages with PRE tags and limited width disable break the grid to Certain pages with large elements and limited width disabled break the grid.Jan 30 2023, 5:13 PM
Jdlrobson updated the task description. (Show Details)

@Izno right. Live debugging as we speak. I've managed to replicate it locally now. Good news is that it's an issue limited to logged in users right now. Seems to be an incompatibility between the page tools feature and the limited width toggle.

Jdlrobson renamed this task from Certain pages with large elements and limited width disabled break the grid to Page tools: Certain pages with large elements and limited width disabled break the grid.Jan 30 2023, 5:14 PM
Jdlrobson removed a project: SyntaxHighlight.
Jdlrobson updated the task description. (Show Details)

Seems like we're mixing 2 issues here.

  • The diff issue is a table issue and is described in T66577

https://en.wikipedia.org/w/index.php?title=Brahmic_scripts&diff=1135922907&oldid=1132384454&diff=&diffmode=source&useskin=vector-2022

I can't replicate this locally on master or the current deployment branch (yet). It seems SyntaxHighlight_GeSHi and DiscussionTools do something to this page that might be interfering but I've not been able to replicate that yet.

Thank you @Jdlrobson for the link to the task about the diff issue. Sorry for not reporting this in the right place.

Okay.. I found the source of all my confusion. We didn't backport the fix for T327423 to wmf20, which rolled out late Thursday.