Page MenuHomePhabricator

Add default value to cul_reason on WMF wikis
Closed, ResolvedPublic

Description

  1. ALTERs to run: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CheckUser/+/749b18df41fdbdefcc0256cf17eba791a2daa106/schema/mysql/patch-cu_log-change-reason_default.sql
  2. Where to run those changes: all.dblist
  3. When to run those changes: When DBA has time.
  4. If the schema change is backwards compatible: Yes.
  5. If the schema change has been tested already on some of the test/beta wikis: beta cluster doesn't have checkuser, but this change is active on https://checkuser-beta-wiki.wmcloud.org
  6. if the data should be made available on the labs replicas and/or dumps: No, data is private.

Progress

  • s1
  • s2
  • s3
  • s4
  • s5
  • s6
  • s7
  • s8
  • labtestwiki

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
ResolvedZabe
Resolved Marostegui

Event Timeline

Steps I followed to test on the wmcloud vagrant instance:

  • Pulled latest commits for CheckUser
  • Ran vagrant git-update
  • Checked the table by running describe cu_log.

Output of describe cu_log after running update.php:

(23:17) vagrant@localhost:[wiki]> describe cu_log;
+-------------------------+---------------------+------+-----+---------+----------------+
| Field                   | Type                | Null | Key | Default | Extra          |
+-------------------------+---------------------+------+-----+---------+----------------+
| cul_id                  | int(10) unsigned    | NO   | PRI | NULL    | auto_increment |
| cul_timestamp           | binary(14)          | NO   | MUL | NULL    |                |
| cul_actor               | bigint(20) unsigned | NO   | MUL | 0       |                |
| cul_reason              | varbinary(255)      | NO   |     |         |                |
| cul_reason_id           | bigint(20) unsigned | NO   |     | 0       |                |
| cul_reason_plaintext_id | bigint(20) unsigned | NO   |     | 0       |                |
| cul_type                | varbinary(30)       | NO   | MUL | NULL    |                |
| cul_target_id           | int(10) unsigned    | NO   |     | 0       |                |
| cul_target_text         | blob                | NO   |     | NULL    |                |
| cul_target_hex          | varbinary(255)      | NO   | MUL |         |                |
| cul_range_start         | varbinary(255)      | NO   | MUL |         |                |
| cul_range_end           | varbinary(255)      | NO   |     |         |                |
+-------------------------+---------------------+------+-----+---------+----------------+
12 rows in set (0.002 sec)
Dreamy_Jazz renamed this task from Add default value to cul_reason to Add default value to cul_reason on WMF wikis.Jan 30 2023, 12:25 AM

This can probably done with replication on all wikis except enwiki (even enwiki is not too far fetched)

Steps I followed to test on the wmcloud vagrant instance:

Awesome. Have you noticed any errors? Specially database errors?

Marostegui triaged this task as Medium priority.
Marostegui moved this task from Triage to Ready on the DBA board.

Mentioned in SAL (#wikimedia-operations) [2023-01-30T07:10:31Z] <marostegui> dbmaint Schema change on s8 eqiad T328236

Mentioned in SAL (#wikimedia-operations) [2023-01-30T07:11:28Z] <marostegui> dbmaint Schema change on s5 eqiad T328236

Mentioned in SAL (#wikimedia-operations) [2023-01-30T07:16:55Z] <marostegui> dbmaint Schema change on s6 eqiad T328236

Mentioned in SAL (#wikimedia-operations) [2023-01-30T07:17:57Z] <marostegui> dbmaint Schema change on s4 eqiad T328236

Mentioned in SAL (#wikimedia-operations) [2023-01-30T07:21:47Z] <marostegui> dbmaint Schema change on s1 eqiad T328236

Mentioned in SAL (#wikimedia-operations) [2023-01-30T07:25:26Z] <marostegui> dbmaint Schema change on s1 eqiad T328236

Mentioned in SAL (#wikimedia-operations) [2023-01-30T07:25:32Z] <marostegui> dbmaint Schema change on s2 eqiad T328236

Mentioned in SAL (#wikimedia-operations) [2023-01-30T07:26:29Z] <marostegui> dbmaint Schema change on s7 eqiad T328236

Deploying this on s3, it will take around 8h

Steps I followed to test on the wmcloud vagrant instance:

Awesome. Have you noticed any errors? Specially database errors?

Didn't see any. Checked the mediawiki-exception.log file with nothing there. Found the INSERT query associated with the check in the debug log and there were no errors or warnings shown there.