Page MenuHomePhabricator

Use new PageUndeleteComplete hook to emit mediawiki.page_change undelete event
Closed, ResolvedPublic

Description

After T321412: Create PageUndeleteComplete hook, analogous to PageDeleteComplete is merged, we should use the new hook to emit a more consistent mediawiki.page_change undelete event.

Done is

  • mediawiki.page_change undelete event is emitted using the PageUndeleteComplete hook.

Event Timeline

Change 897943 had a related patch set uploaded (by OwenR; author: OwenR):

[mediawiki/extensions/EventBus@master] Convert PageChange event to use new PageUndeleteComplete hook

https://gerrit.wikimedia.org/r/897943

@Ottomata I thought I'd take a look at this as a related follow on from the previous change. Can you let me know if the above change does this work/if anything else needs doing in the EventBus extension?

Thank you @OwenRB this is amazing! Code looks great.

Have you run it locally and verified that both events 'mediawiki.page-undelete' and 'mediawiki.page_change' (with page_change_kind == 'undelete') still work? If so, I feel good about merging this as is.

@OwenRB I'm curious! Are you using EventBus in your own MediaWiki installs (at Mirahaze?)

Have you run it locally and verified that both events 'mediawiki.page-undelete' and 'mediawiki.page_change' (with page_change_kind == 'undelete') still work? If so, I feel good about merging this as is.

I have not verified it locally as I've not got something set up using EventBus locally unfortunately.

Change 897943 merged by jenkins-bot:

[mediawiki/extensions/EventBus@master] Convert PageChange event to use new PageUndeleteComplete hook

https://gerrit.wikimedia.org/r/897943

OwenRB claimed this task.
OwenRB moved this task from In Review to Done on the Event-Platform (Sprint 12) board.

I think the above patch makes this resolved now?

This change should be deployed with the deployment train this week.

Thank you so much OwenRB!!!

As far as I can tell, everything is working! Thank you so much!