AbuseFilter records IP address on a user's first edit
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Jan 31 2023, 8:14 AM

Description

What is the problem?

The first time I am editing (without a temporary account), if I trip an abuse filter it records my IP address in Special:AbuseLog.

See some examples in https://de.wikipedia.beta.wmflabs.org/wiki/Spezial:Missbrauchsfilter-Logbuch.

Subsequent edits will record my temporary account name.

Steps to reproduce problem

Clear the cookies on your browser
Go to https://de.wikipedia.beta.wmflabs.org
Perform an edit
1. This will trip AbuseFilter 147
Go to https://de.wikipedia.beta.wmflabs.org/wiki/Spezial:Missbrauchsfilter-Logbuch

Expected behavior: The log entry for your edit has a temporary user (e.g. *Unregistered 123)
Observed behavior: The log entry will show your IP address

Environment

Wiki(s):

https://de.wikipedia.beta.wmflabs.org MediaWiki 1.40.0-alpha (2789b80) 03:24, 31 January 2023. Abuse Filter – (f0f5d6d) 08:28, 30 January 2023.
local docker wiki MediaWiki 1.40.0-alpha (2789b80) 02:24, 31 January 2023. Abuse Filter – (f0f5d6d) 07:28, 30 January 2023.

Details

	Subject	Repo	Branch	Lines +/-
	edit: Always use pstUser for EditFilterMergedContentHookConstraint	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T336746: AbuseFilter tagging will not work for the first edit of an anonymous user with IP Masking
T307060: [Epic] Temporary account AbuseFilter support
T331653: Investigate: Update AbuseFilter for IP Masking
T334623: How do we log unsuccessful first edits for temporary users?
T328311: Special:AbuseLog is missing the `mw-tempuserlink` class from temporary account user links
Mentioned Here: rEABFf0f5d6dcae58: Localisation updates from https://translatewiki.net.
rMW2789b80dc570: Merge "SpecialRevisionDelete: Set default of '' for wpReason"

Event Timeline

dom_walden created this task.Jan 31 2023, 8:14 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 31 2023, 8:14 AM

dom_walden mentioned this in T328311: Special:AbuseLog is missing the `mw-tempuserlink` class from temporary account user links.Jan 31 2023, 3:59 PM

Umherirrender mentioned this in T334623: How do we log unsuccessful first edits for temporary users?.Apr 12 2023, 9:21 PM

• AGueyte mentioned this in T331653: Investigate: Update AbuseFilter for IP Masking.Apr 19 2023, 6:43 PM

dom_walden mentioned this in T307060: [Epic] Temporary account AbuseFilter support.Apr 28 2023, 3:19 PM

Change 916618 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] edit: Always use pstUser for EditFilterMergedContentHookConstraint

https://gerrit.wikimedia.org/r/916618

gerritbot added a project: Patch-For-Review.May 5 2023, 9:47 PM

Works on page creations but fails on edit for existing pages.

The EditFilterMergedContentHookConstraint gets different users in the cases

Umherirrender mentioned this in T336746: AbuseFilter tagging will not work for the first edit of an anonymous user with IP Masking.May 16 2023, 4:51 PM

Change 916618 merged by jenkins-bot: