Maniphest T328469

📜 Validate request in use case
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Silvan_WMDE
	Jan 31 2023, 5:09 PM

Tags

Referenced Files

None

Subscribers

Ollie.Shotton_WMDE

Description

Use the existing ItemIdValidator but create a dedicated use case validator
Create UseCaseErrorException (in the UseCases dir )
Throw UseCaseErrorException if item id is invalid
- We decided it was okay to use the ErrorResponse error code constants in the UseCaseException for now as it doesn't cause an onion violation

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	REST: Validate GetItemDescriptions request	mediawiki/extensions/Wikibase	master	+138 -4

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• Muhammad_Yasser_Jazirahly_WMDE	T327527 Should our use cases throw exceptions instead of returning different response objects?
		Resolved		Ifrahkhanyaree_WMDE	T344228 Functionality for REST API v1
		Resolved		WMDE-leszek	T327881 📜 Provide data of all item's descriptions
		Resolved		Silvan_WMDE	T328469 📜 Validate request in use case

Event Timeline

Silvan_WMDE created this task.Jan 31 2023, 5:09 PM

Ollie.Shotton_WMDE updated the task description. (Show Details)Jan 31 2023, 5:39 PM

Ollie.Shotton_WMDE mentioned this in T327881: 📜 Provide data of all item's descriptions.

Silvan_WMDE claimed this task.Feb 2 2023, 10:08 AM

Silvan_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 22) board.

Change 886112 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] REST: Validate GetItemDescriptions request

https://gerrit.wikimedia.org/r/886112

gerritbot added a project: Patch-For-Review.Feb 2 2023, 5:10 PM

Silvan_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 22) board.Feb 3 2023, 9:53 AM

Change 886112 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Validate GetItemDescriptions request

https://gerrit.wikimedia.org/r/886112

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.23; 2023-02-13).Feb 10 2023, 11:00 AM

Maintenance_bot removed a project: Patch-For-Review.Feb 10 2023, 11:30 AM

• Muhammad_Yasser_Jazirahly_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 22) board.Feb 10 2023, 1:02 PM

WMDE-leszek closed this task as Resolved.Mar 1 2023, 8:47 AM