Page MenuHomePhabricator
Create Task
Maniphest T328544

GrowthExperiments: Remove unnecessary target definitions
Closed, ResolvedPublic
Actions

Description

We can remove the "targets" entry for any resource loader module defined for "desktop" and "mobile".

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Drop unnecessary targets definitionsmediawiki/extensions/Translatemaster+9 -149
Drop unnecessary targets definitionsmediawiki/extensions/GrowthExperimentsmaster+2 -82
Remove targets from Flowmediawiki/extensions/Flowmaster+2 -39
Customize query in gerrit

Related Objects
Search...

Event Timeline

kostajh created this task.Feb 1 2023, 11:07 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 1 2023, 11:07 AM
kostajh renamed this task from GrowthExperiments; Remove unnecessary target definitions to GrowthExperiments: Remove unnecessary target definitions.Feb 1 2023, 11:08 AM
kostajh added a parent task: T323132: [Epic] Q3 FY 2022-23 Growth Maintenance Work.
kostajh added a project: GrowthExperiments.
Sgs moved this task from Inbox to Triaged on the Growth-Team board.Feb 16 2023, 4:05 PM
Jdlrobson added projects: Notifications (Echo), Thanks, StructuredDiscussions.Feb 27 2023, 5:57 PM
gerritbot added a comment.Mar 24 2023, 5:46 PM

Change 902761 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Flow@master] Remove targets from Flow

https://gerrit.wikimedia.org/r/902761

gerritbot added a project: Patch-For-Review.Mar 24 2023, 5:46 PM
gerritbot added a comment.Mar 24 2023, 8:13 PM

Change 902761 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Remove targets from Flow

https://gerrit.wikimedia.org/r/902761

Maintenance_bot removed a project: Patch-For-Review.Mar 24 2023, 8:30 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.2; 2023-03-27).Mar 24 2023, 9:00 PM
kostajh closed this task as Resolved.Mar 28 2023, 2:34 PM
kostajh claimed this task.
Jdlrobson reopened this task as Open.Mar 28 2023, 5:12 PM
gerritbot added a comment.Mar 28 2023, 5:13 PM

Change 903726 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/GrowthExperiments@master] Drop unnecessary targets definitions

https://gerrit.wikimedia.org/r/903726

gerritbot added a project: Patch-For-Review.Mar 28 2023, 5:13 PM
gerritbot added a comment.Mar 28 2023, 5:54 PM

Change 903735 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Translate@master] Drop unnecessary targets definitions

https://gerrit.wikimedia.org/r/903735

gerritbot added a comment.Mar 29 2023, 3:17 PM

Change 903726 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Drop unnecessary targets definitions

https://gerrit.wikimedia.org/r/903726

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.3; 2023-04-03); removed MW-1.41-notes (1.41.0-wmf.2; 2023-03-27).Mar 29 2023, 4:00 PM
DMburugu edited parent tasks, added: T333335: [Epic] Q4 FY 2022-23 Growth Maintenance Work; removed: T323132: [Epic] Q3 FY 2022-23 Growth Maintenance Work.Mar 30 2023, 12:27 PM
DMburugu added subscribers: Jdlrobson, DMburugu.

@Jdlrobson Can this task be marked as resolved now? I noticed that you re-opened it?

Jdlrobson added a comment.Mar 30 2023, 10:40 PM

Hi @DMburugu this task is not complete. Echo and Thanks (and maybe others) still need updating.
It can be resolved when https://codesearch.wmcloud.org/deployed/?q=%22mobile%22&files=%28extension%7Cskin%29.json&excludeFiles=&repos= returns no search results relating to Growth team maintained code.

Kennethcblai subscribed.Mar 31 2023, 7:36 PM

DMburugu edited parent tasks, added: T333335: [Epic] Q4 FY 2022-23 Growth Maintenance Work; removed: T323132: [Epic] Q3 FY 2022-23 Growth Maintenance Work.
Thu, Mar 30, 1:27 PM

gerritbot added a comment.Apr 28 2023, 7:37 PM

Change 903735 abandoned by Jdlrobson:

[mediawiki/extensions/Translate@master] Drop unnecessary targets definitions

Reason:

Not important. Can be handled in later MediaWiki release. Not blocking anything on my side.

https://gerrit.wikimedia.org/r/903735

Maintenance_bot removed a project: Patch-For-Review.Apr 28 2023, 8:10 PM
Jdlrobson closed this task as Resolved.May 3 2023, 10:31 PM

This looks done now, thank you!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits