Page MenuHomePhabricator

Enable page tools everywhere for logged in users
Closed, ResolvedPublic2 Estimated Story Points

Description

Currently page tools is only enabled on Czech, English, and Vietnamese Wikipedia for logged in users.

We should enable it for all projects

TODO

  • Enable for logged in users everywhere
  • Disabled for anonymous users
  • Update the value in master to match the Wikimedia default

Sign off steps

  • Create ticket for enabling page tools for anonymous users and removing the feature flag.

QA Results - Beta

ACStatusDetails
1T328692#8639538
2T328692#8639538

QA Results - Prod

ACStatusDetails
1T328692#8655335
2T328692#8655335

Event Timeline

Jdlrobson renamed this task from Enable page tools everywhere to Enable page tools everywhere for logged in users.Feb 2 2023, 6:48 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)

@Jdlrobson Looking at the sign off steps, how can we remove the flag if its still disabled for anon users?

Change 888764 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[operations/mediawiki-config@master] Enable Page Tools for logged in users across all wikis

https://gerrit.wikimedia.org/r/888764

Change 888758 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Enable Page Tools for all logged in users

https://gerrit.wikimedia.org/r/888758

bwang removed bwang as the assignee of this task.Feb 13 2023, 6:53 PM

@bwang are you looking for code reviewer here or a deployer? If the former LGTM.

Change 888764 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable Page Tools for logged in users across all wikis

https://gerrit.wikimedia.org/r/888764

Mentioned in SAL (#wikimedia-operations) [2023-02-14T21:21:29Z] <dancy@deploy1002> Started scap: Backport for [[gerrit:888764|Enable Page Tools for logged in users across all wikis (T328692)]]

Mentioned in SAL (#wikimedia-operations) [2023-02-14T21:23:20Z] <dancy@deploy1002> dancy and bwang: Backport for [[gerrit:888764|Enable Page Tools for logged in users across all wikis (T328692)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-02-14T21:34:20Z] <dancy@deploy1002> Finished scap: Backport for [[gerrit:888764|Enable Page Tools for logged in users across all wikis (T328692)]] (duration: 12m 50s)

nray added a subscriber: nray.

@bwang The mediawiki-config change has been backported. Handing this back to you

Change 888758 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Enable Page Tools for all logged in users

https://gerrit.wikimedia.org/r/888758

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

This should mainly be tested in production, but here are some examples in beta

✅ AC1: Pagetools should be enabled for logged-in users.

Screenshot 2023-02-22 at 6.02.06 PM.png (819×1 px, 188 KB)

Screenshot 2023-02-22 at 6.01.40 PM.png (820×1 px, 258 KB)

✅ AC2: Pagetools should not be enabled for logged-out users.

Screenshot 2023-02-22 at 6.03.06 PM.png (813×1 px, 236 KB)

Screenshot 2023-02-22 at 6.02.29 PM.png (763×1 px, 167 KB)

Edtadros added a subscriber: Edtadros.

Test Result - Prod

Status: ✅ PASS
Environment: frwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

This should mainly be tested in production, but here are some examples in beta

✅ AC1: Pagetools should be enabled for logged-in users.

Screenshot 2023-02-28 at 8.48.35 PM.png (718×1 px, 603 KB)

✅ AC2: Pagetools should not be enabled for logged-out users.

Screenshot 2023-02-28 at 8.48.07 PM.png (715×1 px, 572 KB)