Page MenuHomePhabricator
Create Task
Maniphest T328694

PHP Notice: Undefined index: parse
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Notice: Undefined index: parse
exception.trace
from /srv/mediawiki/php-1.40.0-wmf.21/extensions/GlobalUserPage/includes/GlobalUserPage.php(396)
#0 /srv/mediawiki/php-1.40.0-wmf.21/extensions/GlobalUserPage/includes/GlobalUserPage.php(396): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.40.0-wmf.21/extensions/GlobalUserPage/includes/GlobalUserPage.php(318): MediaWiki\GlobalUserPage\GlobalUserPage->parseWikiText(Title, string, string)
#2 /srv/mediawiki/php-1.40.0-wmf.21/includes/libs/objectcache/wancache/WANObjectCache.php(1759): MediaWiki\GlobalUserPage\GlobalUserPage->MediaWiki\GlobalUserPage\{closure}(boolean, integer, array, NULL, array)
#3 /srv/mediawiki/php-1.40.0-wmf.21/includes/libs/objectcache/wancache/WANObjectCache.php(1589): WANObjectCache->fetchOrRegenerate(string, integer, Closure, array, array)
#4 /srv/mediawiki/php-1.40.0-wmf.21/extensions/GlobalUserPage/includes/GlobalUserPage.php(326): WANObjectCache->getWithSetCallback(string, integer, Closure, array)
#5 /srv/mediawiki/php-1.40.0-wmf.21/extensions/GlobalUserPage/includes/GlobalUserPage.php(83): MediaWiki\GlobalUserPage\GlobalUserPage->getRemoteParsedText(string)
#6 /srv/mediawiki/php-1.40.0-wmf.21/includes/page/Article.php(622): MediaWiki\GlobalUserPage\GlobalUserPage->showMissingArticle()
#7 /srv/mediawiki/php-1.40.0-wmf.21/includes/page/Article.php(541): Article->generateContentOutput(User, ParserOptions, integer, OutputPage, array)
#8 /srv/mediawiki/php-1.40.0-wmf.21/includes/actions/ViewAction.php(78): Article->view()
#9 /srv/mediawiki/php-1.40.0-wmf.21/includes/MediaWiki.php(551): ViewAction->show()
#10 /srv/mediawiki/php-1.40.0-wmf.21/includes/MediaWiki.php(328): MediaWiki->performAction(MediaWiki\GlobalUserPage\GlobalUserPage, Title)
#11 /srv/mediawiki/php-1.40.0-wmf.21/includes/MediaWiki.php(915): MediaWiki->performRequest()
#12 /srv/mediawiki/php-1.40.0-wmf.21/includes/MediaWiki.php(571): MediaWiki->main()
#13 /srv/mediawiki/php-1.40.0-wmf.21/index.php(50): MediaWiki->run()
#14 /srv/mediawiki/php-1.40.0-wmf.21/index.php(46): wfIndexMain()
#15 /srv/mediawiki/w/index.php(3): require(string)
#16 {main}
Impact
Notes

Details

MediaWiki Version
1.40.0-wmf.21
Request URL
https://api.wikimedia.org/wiki/User:APaskulin_(WMF)
SubjectRepoBranchLines +/-
Don't read 'parse' key blindly, it might not be setmediawiki/extensions/GlobalUserPagemaster+2 -1
Customize query in gerrit

Event Timeline

Zabe created this task.Feb 2 2023, 7:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 2 2023, 7:04 PM
thcipriani added projects: API-Portal, Platform Engineering.Feb 9 2023, 4:23 PM
thcipriani subscribed.

Tagging with API-portal as it seems almost all of these over the past 7 days (roughly 10 per day) have happened on api.wikimedia.org

thcipriani moved this task from Untriaged to Feb 2023 on the Wikimedia-production-error board.Feb 9 2023, 4:47 PM
apaskulin triaged this task as Low priority.Feb 9 2023, 5:47 PM
apaskulin added a project: API Platform.
apaskulin subscribed.

It looks like the API Portal isn't pulling in global user pages like it used to. For example, https://api.wikimedia.org/wiki/User:APaskulin_(WMF) should reflect content from https://meta.wikimedia.org/wiki/User:APaskulin_(WMF). Although I'm not 100% sure that this is what's causing the error. Triaging this as a low priority since the API Portal hasn't been officially announced, and tagging the API Platform team.

daniel subscribed.Feb 9 2023, 10:05 PM

Wild guess: the code in question is calling the "parse" action API to get the HTML of the user page. The response is expected to contain the "parse" key. But something goes wrong, so it receives an error instead. Since it doesn't check before trying to access the field, it fails with "undefined index", instead of reporting the original error.

Jdforrester-WMF subscribed.Feb 10 2023, 2:54 AM
In T328694#8603088, @daniel wrote:

Wild guess: the code in question is calling the "parse" action API to get the HTML of the user page. The response is expected to contain the "parse" key. But something goes wrong, so it receives an error instead. Since it doesn't check before trying to access the field, it fails with "undefined index", instead of reporting the original error.

Yup: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/GlobalUserPage/+/refs/heads/master/includes/GlobalUserPage.php#396

We could just ?: false or we could properly handle?

hnowlan subscribed.Feb 10 2023, 10:39 AM
daniel added a comment.Feb 10 2023, 12:58 PM

I suppose we want to identify and fix the original error :=

apaskulin moved this task from Backlog to Tech debt on the API-Portal board.Feb 10 2023, 6:03 PM
VirginiaPoundstone moved this task from Incoming to Radar on the API Platform board.Feb 16 2023, 11:18 PM
VirginiaPoundstone moved this task from Radar to Needs Grooming on the API Platform board.
JArguello-WMF moved this task from Needs Grooming to Incoming on the API Platform board.Feb 21 2023, 7:06 PM
VirginiaPoundstone moved this task from Incoming to Needs Grooming on the API Platform board.Mar 8 2023, 7:57 PM
VirginiaPoundstone moved this task from Needs Grooming to Incoming on the API Platform board.Mar 14 2023, 2:00 PM
brennen added a project: User-brennen.Mar 15 2023, 6:22 PM
brennen moved this task from Backlog to Logs/Train on the User-brennen board.
dancy subscribed.Mar 22 2023, 8:05 PM

Friendly ping! I'm on train duty this week which means I watch error logs. This one draws my attention from time to time.

gerritbot added a comment.Apr 7 2023, 2:30 PM

Change 906734 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/GlobalUserPage@master] Don't read 'parse' key blindly, it might not be set

https://gerrit.wikimedia.org/r/906734

gerritbot added a project: Patch-For-Review.Apr 7 2023, 2:30 PM
gerritbot added a comment.Apr 11 2023, 4:21 PM

Change 906734 merged by jenkins-bot:

[mediawiki/extensions/GlobalUserPage@master] Don't read 'parse' key blindly, it might not be set

https://gerrit.wikimedia.org/r/906734

Umherirrender closed this task as Resolved.Apr 11 2023, 4:28 PM
Umherirrender assigned this task to Jdforrester-WMF.
Umherirrender removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.5; 2023-04-17).Apr 11 2023, 5:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL