Page MenuHomePhabricator

[IP Masking] Do not show logged-in version of Special:CreateAccount page to temp accounts
Closed, ResolvedPublic3 Estimated Story Points

Description

User story

As an unregistered editor who has decided to create an account understanding it will not be tied to my unregistered edits,
I want assurance that my new account identity is separate,
So that I can be assured about my anonymity.

Problem(s)

Currently the temp account is being shown the version of Special:CreateAccount page for logged in users.

01. Navigate to Special:CreateAccount in temp user state with unexpected fields (send temp password to email, rationale)google translated de betalabs version
image.png (1,658×1,860 px, 466 KB)
02. Filled in with new account
image.png (1,640×1,774 px, 425 KB)
03. Person is now logged in as new account in Newcomer homepage welcome survey
image.png (1,654×1,124 px, 386 KB)
04. Going to Special:Log?type=newusers and it is shown publicly that *Unregistered_2828 created the account
image.png (2,326×1,164 px, 410 KB)
(T364716: Do not show link between named account and temporary account in RecentChanges and Special:Log)
Acceptance Criteria:
  • Show a specific version of Special:CreateAccount for temp accounts which does not ask for a rationale, and doesn't have the send a temp password to an email field.

Note: T364716: Do not show link between named account and temporary account in RecentChanges and Special:Log can be handled separately.

Event Timeline

Going to Special:Log?type=newusers and it is shown publicly that *Unregistered_2828 created the account

One danger here is that the IP addresses of temporary accounts are available more widely than the IP addresses of registered accounts. (Admins and patrollers will be able to access them.) By linking a temporary and a registered account, we are exposing the IP addresses of that registered account more widely.

Umherirrender renamed this task from [IP Masking] Do not show logged-in version of Create:SpecialAccount page to temp accounts to [IP Masking] Do not show logged-in version of Special:CreateAccount page to temp accounts.Mar 29 2023, 7:43 PM

There is message "createacct-temp-warning" (The edits you made with your temporary account will not be carried over to your permanent one.), so only the temp password and the reason field should be removed and the auth process must not use the temp user to log

KStoller-WMF subscribed.

Moving this into the Growth team backlog, as I imagine this is a MVP release requirement.

KStoller-WMF raised the priority of this task from Medium to High.May 23 2024, 4:45 PM
Sgs set the point value for this task to 3.May 28 2024, 4:22 PM

@KColeman-WMF @Niharika this task needs design and product specification for what the Special:CreateAccount page should look like if you are logged-in as a temporary account user and want to create a full, named account. There is already a suggestion on what is to be done for this task:

There is message "createacct-temp-warning" (The edits you made with your temporary account will not be carried over to your permanent one.), so only the temp password and the reason field should be removed and the auth process must not use the temp user to log

There is message "createacct-temp-warning" (The edits you made with your temporary account will not be carried over to your permanent one.), so only the temp password and the reason field should be removed and the auth process must not use the temp user to log

@KColeman-WMF and I talked about this. We think this suggestion makes sense. I'll update the spec in the task.

mszabo changed the task status from Open to In Progress.Aug 30 2024, 11:35 AM
mszabo claimed this task.

Change #1069270 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/core@master] auth: Split TemporaryPasswordPrimaryAuthenticationProviderTest cases

https://gerrit.wikimedia.org/r/1069270

Change #1070002 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/core@master] auth: Disable irrelevant account creation fields for temp users

https://gerrit.wikimedia.org/r/1070002

Change #1069270 merged by jenkins-bot:

[mediawiki/core@master] auth: Split TemporaryPasswordPrimaryAuthenticationProviderTest cases

https://gerrit.wikimedia.org/r/1069270

Change #1070002 merged by jenkins-bot:

[mediawiki/core@master] auth: Disable irrelevant account creation fields for temp users

https://gerrit.wikimedia.org/r/1070002

Djackson-ctr subscribed.

QA has been completed and the new code is functioning and displaying as expected (Per the Acceptance Criteria: Show a specific version of Special:CreateAccount for temp accounts which does not ask for a rationale, and doesn't have the send a temp password to an email field).

Special:CreateAccount page (Before implementation of new code changes):

image.png (1,906×989 px, 133 KB)


Special:CreateAccount page (After implementation of new code changes):

image.png (1,907×847 px, 122 KB)


Translated from German to English screenshot:

image.png (1,901×818 px, 111 KB)