Page MenuHomePhabricator

Leveling up: Define feature flag for gating the functionality
Closed, ResolvedPublic

Description

  • tasks on the leveling up board should go behind a "GELevelingUpEnabled" feature flag, to be created as part of completing this task
  • Features on the leveling up board should be available for users in the control (new impact) experiment group, and not for the oldimpact experiment group. In code, would probably make sense to invert the condition: if user is not in oldimpact, then show the feature.
  • We'll need to think about translations; if a task calls for updating an existing UI string, we most likely need to create a new, separate string using DRAFT prefix in en.json and {{notranslate}} in qqq.json, and use that string when the feature flag is enabled and the user is not in oldimpact

Event Timeline

Change 886341 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] Leveling up: Define feature flag for gating functionality

https://gerrit.wikimedia.org/r/886341

Change 886342 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[operations/mediawiki-config@master] GrowthExperiments: Enable leveling up features on beta labs

https://gerrit.wikimedia.org/r/886342

Change 886343 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[operations/mediawiki-config@master] GrowthExperiments: Disable leveling up features in production

https://gerrit.wikimedia.org/r/886343

Change 886341 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Leveling up: Define feature flag for gating functionality

https://gerrit.wikimedia.org/r/886341

Change 886342 merged by jenkins-bot:

[operations/mediawiki-config@master] GrowthExperiments: Enable leveling up features on beta labs

https://gerrit.wikimedia.org/r/886342

Change 886343 merged by jenkins-bot:

[operations/mediawiki-config@master] GrowthExperiments: Disable leveling up features in production

https://gerrit.wikimedia.org/r/886343

Mentioned in SAL (#wikimedia-operations) [2023-02-07T08:16:39Z] <kharlan@deploy1002> Started scap: Backport for [[gerrit:886343|GrowthExperiments: Disable leveling up features in production (T328757)]]

Mentioned in SAL (#wikimedia-operations) [2023-02-07T08:18:30Z] <kharlan@deploy1002> kharlan: Backport for [[gerrit:886343|GrowthExperiments: Disable leveling up features in production (T328757)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-02-07T08:28:50Z] <kharlan@deploy1002> Finished scap: Backport for [[gerrit:886343|GrowthExperiments: Disable leveling up features in production (T328757)]] (duration: 12m 11s)

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh added a subscriber: Etonkovidova.

This is all done. (cc @Etonkovidova)

Change 894594 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[operations/mediawiki-config@master] GrowthExperiments: Make new impact module default on betalabs

https://gerrit.wikimedia.org/r/894594

Change 894594 merged by jenkins-bot:

[operations/mediawiki-config@master] GrowthExperiments: Make new impact module default on betalabs

https://gerrit.wikimedia.org/r/894594