Page MenuHomePhabricator
Create Task
Maniphest T328759

Cleanup references to unique_devices
Closed, ResolvedPublic
Actions

Description

There’s still a bunch of references to unique-devices that need to be cleaned up in the repo, both in the codebase and config, but also the docs. We even still build a binary called unique-devices

Details

SubjectRepoBranchLines +/-
Cleanup references to unique_devicesgenerated-data-platform/aqs/device_analyticsmain+25 -24
Customize query in gerrit

Related Objects
Search...

Event Timeline

Atieno created this task.Feb 3 2023, 12:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 3 2023, 12:08 PM
gerritbot added a comment.Feb 3 2023, 12:11 PM

Change 886345 had a related patch set uploaded (by Atieno; author: Atieno):

[generated-data-platform/aqs/device_analytics@main] Cleanup references to unique_devices

https://gerrit.wikimedia.org/r/886345

gerritbot added a project: Patch-For-Review.Feb 3 2023, 12:11 PM
Atieno moved this task from Next Up to In Progress on the API Platform (Sprint 05) board.Feb 3 2023, 12:11 PM
Atieno moved this task from In Progress to Ready for Code Review/ Ready for Tech input on the API Platform (Sprint 05) board.
Atieno added a subtask: T328761: Rename https://wikitech.wikimedia.org/wiki/Analytics/AQS/Unique_Devices to https://wikitech.wikimedia.org/wiki/Analytics/AQS/Devices_Analytics.Feb 3 2023, 12:23 PM
hnowlan subscribed.Feb 3 2023, 4:32 PM
JArguello-WMF moved this task from Ready for Code Review/ Ready for Tech input to In code Review/ Tech Input on the API Platform (Sprint 05) board.Feb 10 2023, 4:06 PM
gerritbot added a comment.Feb 22 2023, 3:52 PM

Change 886345 merged by BPirkle:

[generated-data-platform/aqs/device_analytics@main] Cleanup references to unique_devices

https://gerrit.wikimedia.org/r/886345

Atieno mentioned this in rGADA986f3f2fabe9: Cleanup references to unique_devices.Feb 22 2023, 3:52 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 22 2023, 4:10 PM
JArguello-WMF triaged this task as High priority.Feb 22 2023, 5:08 PM
JArguello-WMF moved this task from In code Review/ Tech Input to Ready for Testing on the API Platform (Sprint 05) board.
EChukwukere-WMF added a subscriber: BPirkle.Feb 22 2023, 6:52 PM
EChukwukere-WMF subscribed.

@Atieno can you pls provide more clarity, I believe there isn't a specific endpoint to be tested ? this is a case of making sure nothing breaks for the unique devices endpoint

cc: @BPirkle correct me if the above is wrong

EChukwukere-WMF moved this task from Ready for Testing to In Testing on the API Platform (Sprint 05) board.Feb 22 2023, 7:03 PM
BPirkle added a comment.Feb 22 2023, 8:21 PM

That's correct. The name of the binary itself, and some bits of documentation in the swagger spec and readme will be different. But nothing should change for the endpoint itself.

EChukwukere-WMF added a comment.Feb 22 2023, 8:25 PM

Thanks for clarifying that. Pretty straightforward to me

EChukwukere-WMF added a comment.Feb 23 2023, 1:28 AM

Test status: QA PASS

No breaking changes to unique devices functional for the data set tested

EChukwukere-WMF moved this task from In Testing to Done on the API Platform (Sprint 05) board.Feb 23 2023, 1:28 AM
JArguello-WMF closed this task as Resolved.Feb 24 2023, 12:39 AM
Aklapper closed subtask T328761: Rename https://wikitech.wikimedia.org/wiki/Analytics/AQS/Unique_Devices to https://wikitech.wikimedia.org/wiki/Analytics/AQS/Devices_Analytics as Resolved.Mar 15 2023, 10:37 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL