Page MenuHomePhabricator
Create Task
Maniphest T328807

Drop cul_reason from cu_log on wmf wikis
Closed, ResolvedPublic
Actions

Description

  1. ALTERs to run: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CheckUser/+/a0e7ad09d8927129499999f021d1878b35d9e49f/schema/mysql/patch-cu_log-drop-cul_reason.sql
  2. Where to run those changes: all
  3. When to run those changes: At any time
  4. If the schema change is backwards compatible: no, as this drops data
  5. If the schema change has been tested already on some of the test/beta wikis: beta cluster doesn't have checkuser - tested locally and on checkuser-beta-wiki.wmcloud.org
  6. If the data should be made available on the labs replicas and/or dumps: Everything is private

The comment table migration for the cu_log has completed. WMF wikis are stably on SCHEMA_COMPAT_NEW, so the cul_reason column can be removed at any time.

Progress

  • s1
  • s2
  • s3
  • s4
  • s5
  • s6
  • s7
  • s8
  • labtestwiki

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedZabeT233004 Update CheckUser for actor and comment table
ResolvedMarosteguiT328807 Drop cul_reason from cu_log on wmf wikis
· · ·

Event Timeline

Dreamy_Jazz created this task.Feb 3 2023, 8:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 3 2023, 8:27 PM
Dreamy_Jazz added a parent task: T233004: Update CheckUser for actor and comment table.Feb 3 2023, 8:27 PM
Dreamy_Jazz updated the task description. (Show Details)Feb 3 2023, 8:31 PM
Marostegui claimed this task.Feb 3 2023, 8:49 PM
Marostegui triaged this task as Medium priority.
Marostegui moved this task from Triage to Ready on the DBA board.
Dreamy_Jazz updated the task description. (Show Details)Feb 3 2023, 9:56 PM
Dreamy_Jazz added a comment.EditedFeb 3 2023, 10:00 PM

Test steps for https://checkuser-beta-wiki.wmcloud.org:

  • describe cu_log
  • pull latest origin
  • vagrant git-update
  • describe cu_log (as expected with no cul_reason)
  • Ran a check and then opened Special:CheckUserLog
    • No errors seen when loading pages
    • Check reasons unchanged (and still exist for checks that had reasons specified) - See image below for that.
    • Debug log looked fine at a skim read

Figure 1: Special:CheckUserLog on the beta wiki after removing cul_reason

image.png (364×1 px, 163 KB)

Dreamy_Jazz attached a referenced file: F36706444: image.png. (Show Details)Feb 4 2023, 12:04 AM
Dreamy_Jazz mentioned this in T328828: Remove default on cul_reason_id and cul_reason_plaintext_id in the cu_log table on wmf wikis.Feb 4 2023, 2:19 AM
Marostegui updated the task description. (Show Details)Feb 6 2023, 8:04 AM

I have ran this on s6 db1187 (for frwiki) and I am going to leave this running for 24h to make sure there are no errors in production.

Marostegui moved this task from Ready to In progress on the DBA board.Feb 6 2023, 8:04 AM
Stashbot added a comment.Feb 7 2023, 3:01 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-07T15:01:05Z] <marostegui> dbmaint deploy schema change on s6 T328807

Marostegui updated the task description. (Show Details)Feb 7 2023, 3:01 PM
Stashbot added a comment.Feb 7 2023, 3:05 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-07T15:05:26Z] <marostegui> dbmaint deploy schema change on s8 T328807 T328828

Marostegui updated the task description. (Show Details)Feb 7 2023, 3:05 PM
Stashbot added a comment.Feb 8 2023, 7:18 AM

Mentioned in SAL (#wikimedia-operations) [2023-02-08T07:18:24Z] <marostegui> dbmaint deploy schema change on s8 eqiad (with replication) T328807 T328828

Stashbot added a comment.Feb 8 2023, 7:18 AM

Mentioned in SAL (#wikimedia-operations) [2023-02-08T07:18:46Z] <marostegui> dbmaint deploy schema change on s4 eqiad (with replication) T328807 T328828

Marostegui updated the task description. (Show Details)Feb 8 2023, 7:18 AM
Stashbot added a comment.Feb 8 2023, 7:19 AM

Mentioned in SAL (#wikimedia-operations) [2023-02-08T07:19:15Z] <marostegui> dbmaint deploy schema change on s5 eqiad (with replication) T328807 T328828

Marostegui updated the task description. (Show Details)Feb 8 2023, 7:34 AM
Stashbot added a comment.Feb 8 2023, 7:38 AM

Mentioned in SAL (#wikimedia-operations) [2023-02-08T07:38:01Z] <marostegui> dbmaint deploy schema change on s2 eqiad (with replication) T328807 T328828

Marostegui updated the task description. (Show Details)Feb 8 2023, 7:46 AM
Stashbot added a comment.Feb 8 2023, 7:56 AM

Mentioned in SAL (#wikimedia-operations) [2023-02-08T07:56:31Z] <marostegui> dbmaint deploy schema change on s7 eqiad (with replication) T328807 T328828

Marostegui updated the task description. (Show Details)Feb 8 2023, 7:56 AM
Stashbot added a comment.Feb 8 2023, 7:59 AM

Mentioned in SAL (#wikimedia-operations) [2023-02-08T07:59:36Z] <marostegui> dbmaint deploy schema change on s1 eqiad (with replication) T328807 T328828

Marostegui updated the task description. (Show Details)Feb 8 2023, 7:59 AM
Stashbot added a comment.Feb 8 2023, 8:02 AM

Mentioned in SAL (#wikimedia-operations) [2023-02-08T08:01:58Z] <marostegui> dbmaint deploy schema change on s3 eqiad (with replication) T328807 T328828

Marostegui added a comment.Feb 8 2023, 8:02 AM

Started on s3, will take around 6h

Marostegui closed this task as Resolved.Feb 8 2023, 1:03 PM
Marostegui updated the task description. (Show Details)

This is done

Maintenance_bot moved this task from In progress to Done on the DBA board.Feb 8 2023, 1:15 PM
Dreamy_Jazz added a comment.Feb 8 2023, 1:36 PM

Thanks!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits