Page MenuHomePhabricator

Drop cul_reason from cu_log on wmf wikis
Closed, ResolvedPublic

Description

  1. ALTERs to run: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CheckUser/+/a0e7ad09d8927129499999f021d1878b35d9e49f/schema/mysql/patch-cu_log-drop-cul_reason.sql
  2. Where to run those changes: all
  3. When to run those changes: At any time
  4. If the schema change is backwards compatible: no, as this drops data
  5. If the schema change has been tested already on some of the test/beta wikis: beta cluster doesn't have checkuser - tested locally and on checkuser-beta-wiki.wmcloud.org
  6. If the data should be made available on the labs replicas and/or dumps: Everything is private

The comment table migration for the cu_log has completed. WMF wikis are stably on SCHEMA_COMPAT_NEW, so the cul_reason column can be removed at any time.

Progress

  • s1
  • s2
  • s3
  • s4
  • s5
  • s6
  • s7
  • s8
  • labtestwiki

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
ResolvedZabe
ResolvedMarostegui

Event Timeline

Marostegui triaged this task as Medium priority.
Marostegui moved this task from Triage to Ready on the DBA board.

Test steps for https://checkuser-beta-wiki.wmcloud.org:

  • describe cu_log
  • pull latest origin
  • vagrant git-update
  • describe cu_log (as expected with no cul_reason)
  • Ran a check and then opened Special:CheckUserLog
    • No errors seen when loading pages
    • Check reasons unchanged (and still exist for checks that had reasons specified) - See image below for that.
    • Debug log looked fine at a skim read

Figure 1: Special:CheckUserLog on the beta wiki after removing cul_reason

image.png (364×1 px, 163 KB)

I have ran this on s6 db1187 (for frwiki) and I am going to leave this running for 24h to make sure there are no errors in production.

Mentioned in SAL (#wikimedia-operations) [2023-02-07T15:01:05Z] <marostegui> dbmaint deploy schema change on s6 T328807

Mentioned in SAL (#wikimedia-operations) [2023-02-07T15:05:26Z] <marostegui> dbmaint deploy schema change on s8 T328807 T328828

Mentioned in SAL (#wikimedia-operations) [2023-02-08T07:18:24Z] <marostegui> dbmaint deploy schema change on s8 eqiad (with replication) T328807 T328828

Mentioned in SAL (#wikimedia-operations) [2023-02-08T07:18:46Z] <marostegui> dbmaint deploy schema change on s4 eqiad (with replication) T328807 T328828

Mentioned in SAL (#wikimedia-operations) [2023-02-08T07:19:15Z] <marostegui> dbmaint deploy schema change on s5 eqiad (with replication) T328807 T328828

Mentioned in SAL (#wikimedia-operations) [2023-02-08T07:38:01Z] <marostegui> dbmaint deploy schema change on s2 eqiad (with replication) T328807 T328828

Mentioned in SAL (#wikimedia-operations) [2023-02-08T07:56:31Z] <marostegui> dbmaint deploy schema change on s7 eqiad (with replication) T328807 T328828

Mentioned in SAL (#wikimedia-operations) [2023-02-08T07:59:36Z] <marostegui> dbmaint deploy schema change on s1 eqiad (with replication) T328807 T328828

Mentioned in SAL (#wikimedia-operations) [2023-02-08T08:01:58Z] <marostegui> dbmaint deploy schema change on s3 eqiad (with replication) T328807 T328828

Started on s3, will take around 6h

Marostegui updated the task description. (Show Details)

This is done