Page MenuHomePhabricator

Wikipedia Library user is continually prompted to enter a new email address
Closed, ResolvedPublic

Description

The user The Eternal Wayfarer keeps being asked to update their email address because we don't have one on file for them. Indeed, I see that in /admin the user has no registered email address in our database. The odd thing is that they keep entering their email address when prompted, which we are then losing somewhere down the line.

They raised this issue on 1st Feb, but had updated it the same day when I checked and saw their email address in our system. By 4th Feb the issue had returned and we no longer had an email address stored for them.

Event Timeline

I did some testing on this, and the only way I could reproduce it was to log in with an account which has no email attached in Wikipedia. Then update my email address in the library while keeping the "Use my Wikipedia email address" checkbox ticked. Upon logging out of the library and back in, the entered email is blanked. If the checkbox isn't selected, this doesn't happen.

So there's definitely one thing we could improve here: If Wikipedia returns no email address for a user, don't blank their email.

I've emailed The Eternal Wayfarer to ask if they had an email set on their Wikipedia account.

Filed a PR with a fix for the 'overwrite with blank email' bug I noted above: https://github.com/WikipediaLibrary/TWLight/pull/1200

Samwalton9-WMF changed the task status from Open to In Progress.Sep 25 2023, 2:41 PM

I asked for confirmation that the issue is resolved for this user, but haven't heard anything back yet. Marking resolved unless I hear otherwise>