DiscussionTools marker comments still appear in the output sometimes in weird places
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Feb 6 2023, 11:38 PM

Description

DiscussionTools marker comments still appear in the output sometimes in weird places:

In Parsoid HTML after transclusions: https://en.wikipedia.beta.wmflabs.org/api/rest_v1/page/html/Talk%3AT313097

<p about="#mwt2" typeof="mw:Transclusion" data-mw="{&quot;parts&quot;:[{&quot;template&quot;:{&quot;target&quot;:{&quot;wt&quot;:&quot;Tracked&quot;,&quot;href&quot;:&quot;./Template:Tracked&quot;},&quot;params&quot;:{&quot;1&quot;:{&quot;wt&quot;:&quot;T238025&quot;}},&quot;i&quot;:0}}]}" id="mwCg"><style data-mw-deduplicate="TemplateStyles:r555781" typeof="mw:Extension/templatestyles" about="#mwt4" data-mw="{&quot;name&quot;:&quot;templatestyles&quot;,&quot;attrs&quot;:{&quot;src&quot;:&quot;Tracked/styles.css&quot;}}">.mw-parser-output .tracked{float:right;clear:right;margin:0 0 1em 1em;width:12em;border:1px solid #72777d;border-radius:2px;background-color:#eaecf0;font-size:85%;text-align:center;padding:0.5em}.mw-parser-output .tracked-url{font-weight:bold}.mw-parser-output .tracked-closure{color:black;font-weight:bold;text-transform:uppercase}.mw-parser-output .tracked-resolved{color:green}</style><span about="#mwt4"><!--__DTHASLEDECONTENT__--><!--__DTEMPTYTALKPAGE__--></span></p>

In action API error messages: https://en.wikipedia.beta.wmflabs.org/wiki/Special:ApiSandbox#action=discussiontoolsedit&format=json&errorformat=html&paction=addcomment&page=Talk%3AT313097%2B%5C&formatversion=2

{
    "errors": [
        {
            "code": "missingparam",
            "html": "<p>One of the parameters <var>wikitext</var> and <var>html</var> is required.\n</p><!--__DTHASLEDECONTENT__--><!--__DTEMPTYTALKPAGE__-->",
            "module": "discussiontoolsedit"
        }
    ],
    "docref": "See https://en.wikipedia.beta.wmflabs.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at &lt;https://lists.wikimedia.org/postorius/lists/mediawiki-api-announce.lists.wikimedia.org/&gt; for notice of API deprecations and breaking changes.",
    "servedby": "deployment-mediawiki11"
}

This is just more stuff like T291833. Maybe we should try to not output these.

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Use setExtensionData() instead of marker comments where possible (3/3)	mediawiki/extensions/DiscussionTools	master	+501 -41
Use setExtensionData() instead of marker comments where possible (2/3)	mediawiki/extensions/DiscussionTools	master	+140 -108
Use setExtensionData() instead of marker comments where possible (2/3)	mediawiki/extensions/DiscussionTools	master	+140 -108
Use setExtensionData() instead of marker comments where possible (3/3)	mediawiki/extensions/DiscussionTools	master	+501 -41
Use setExtensionData() instead of marker comments where possible (1/3)	mediawiki/extensions/DiscussionTools	master	+13 -7

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open	Release	None	T84936 Release VisualEditor-MediaWiki as "1.0"
Open		None	T50429 [Epic] Support editing parts of a page in VisualEditor-MediaWiki
Open		None	T54365 Explore performance gains from progressive (JIT?) de-alienation in VisualEditor
Open		None	T396539 Introduce a way to edit a span of text from within read mode
Open		None	T385558 Improve copy and paste from read mode to VE
Open		None	T174303 Copy-pasting linked ISBN numbers from view mode HTML into VisualEditor inserts wikitext links to Special:BookSources (it should turn them into magic links?)
Open	Feature	None	T54091 The read HTML should have hinting to allow full DOM copying (as opposed to just rich copying) from read mode into VE surfaces
Open		None	T55784 [EPIC] Use Parsoid HTML for all page views
Open		None	T258838 [EPIC] Ensure all extensions on the Wikimedia cluster that use Parser hooks or implement tag hooks are retargeted for Parsoid
Open		None	T272987 [EPIC] Parsoid read views for DiscussionTools
Resolved		ssastry	T110909 Parsoid tripped up by extensions that process wikitext
Stalled		None	T131393 Page indicators aren't visible in articles
Resolved		ssastry	T107332 Parsoid-native implementation for <indicator> (page status indicators)
Resolved		matmarex	T317489 <!--__DTEMPTYTALKPAGE__--> turning indicator HTML from <link> to <span>
Resolved	BUG REPORT	matmarex	T313097 Replying to comment with {{tracked}} template edge case (places reply in wrong location)
Resolved		matmarex	T318725 <!--__DTEMPTYTALKPAGE__--> appears in API messages
Resolved		matmarex	T328980 DiscussionTools marker comments still appear in the output sometimes in weird places

Event Timeline

matmarex created this task.Feb 6 2023, 11:38 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 6 2023, 11:38 PM

matmarex added a parent task: T313097: Replying to comment with {{tracked}} template edge case (places reply in wrong location).Feb 7 2023, 12:49 AM

Change 886989 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Use setExtensionData() instead of marker comments where possible (1/3)

https://gerrit.wikimedia.org/r/886989

Change 886990 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Use setExtensionData() instead of marker comments where possible (2/3)

https://gerrit.wikimedia.org/r/886990

Change 886991 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Use setExtensionData() instead of marker comments where possible (3/3)

https://gerrit.wikimedia.org/r/886991

matmarex claimed this task.Feb 7 2023, 1:35 AM

matmarex added a project: Editing-team (Kanban Board).

matmarex moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.

Change 886989 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Use setExtensionData() instead of marker comments where possible (1/3)

https://gerrit.wikimedia.org/r/886989

Change 886990 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Use setExtensionData() instead of marker comments where possible (2/3)

https://gerrit.wikimedia.org/r/886990

Change 886991 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Use setExtensionData() instead of marker comments where possible (3/3)

https://gerrit.wikimedia.org/r/886991

This needs general regression-testing of DT behaviors that (used to) depend on tracking comments added to parser output.

This includes:

Mobile hidden-lede behavior
Mobile hidden-lede not being hidden if there's comments in the lede
Empty talk page special-case
Showing the newest comment

Maintenance_bot removed a project: Patch-For-Review.Feb 12 2023, 1:30 AM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.23; 2023-02-13).Feb 12 2023, 2:00 AM

Change 888308 had a related patch set uploaded (by DLynch; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Use setExtensionData() instead of marker comments where possible (2/3)

https://gerrit.wikimedia.org/r/888308

Change 888309 had a related patch set uploaded (by DLynch; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Use setExtensionData() instead of marker comments where possible (3/3)

https://gerrit.wikimedia.org/r/888309

ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Feb 13 2023, 7:09 PM

(We should QA after the 2nd patch, currently waiting for 1st patch to roll out)

ppelberg moved this task from Blocked / Needs More Work to Code Review on the Editing-team (Kanban Board) board.Mar 13 2023, 5:20 PM

matmarex mentioned this in T313097: Replying to comment with {{tracked}} template edge case (places reply in wrong location).Mar 15 2023, 3:37 PM

Change 888308 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Use setExtensionData() instead of marker comments where possible (2/3)

https://gerrit.wikimedia.org/r/888308

matmarex moved this task from Code Review to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Mar 15 2023, 3:51 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.1; 2023-03-20).Mar 15 2023, 4:01 PM

Change 888309 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Use setExtensionData() instead of marker comments where possible (3/3)

https://gerrit.wikimedia.org/r/888309

matmarex moved this task from Blocked / Needs More Work to QA on the Editing-team (Kanban Board) board.Mar 22 2023, 11:27 PM

matmarex added a project: Editing QA.

Verifying that they no longer appear in the output:

In Parsoid HTML after transclusions: https://en.wikipedia.beta.wmflabs.org/api/rest_v1/page/html/Talk%3AT313097

<style data-mw-deduplicate="TemplateStyles:r555781" typeof="mw:Extension/templatestyles mw:Transclusion" about="#mwt2" data-mw='{"parts":[{"template":{"target":{"wt":"Tracked","href":"./Template:Tracked"},"params":{"1":{"wt":"T238025"}},"i":0}}]}' id="mwCg">.mw-parser-output .tracked{float:right;clear:right;margin:0 0 1em 1em;width:12em;border:1px solid #72777d;border-radius:2px;background-color:#eaecf0;font-size:85%;text-align:center;padding:0.5em}.mw-parser-output .tracked-url{font-weight:bold}.mw-parser-output .tracked-closure{color:black;font-weight:bold;text-transform:uppercase}.mw-parser-output .tracked-resolved{color:green}</style>

In action API error messages: https://en.wikipedia.beta.wmflabs.org/wiki/Special:ApiSandbox#action=discussiontoolsedit&format=json&errorformat=html&paction=addcomment&page=Talk%3AT313097%2B%5C&formatversion=2

{
    "errors": [
        {
            "code": "missingparam",
            "html": "One of the parameters <var>wikitext</var> and <var>html</var> is required.",
            "module": "discussiontoolsedit"
        }
    ],
    "docref": "See https://en.wikipedia.beta.wmflabs.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at &lt;https://lists.wikimedia.org/postorius/lists/mediawiki-api-announce.lists.wikimedia.org/&gt; for notice of API deprecations and breaking changes.",
    "servedby": "deployment-mediawiki11"
}

matmarex closed this task as Resolved.Apr 3 2023, 7:08 PM

matmarex added parent tasks: T318725:  appears in API messages, T317489:  turning indicator HTML from <link> to <span>.May 1 2023, 12:20 PM

DiscussionTools marker comments still appear in the output sometimes in weird placesClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

DiscussionTools marker comments still appear in the output sometimes in weird places
Closed, ResolvedPublic
Actions

Related Objects
Search...