Page MenuHomePhabricator

codfw1dev: evaluate if extra floating IPs are required today
Open, LowPublic

Description

In parent task T313977: More public IPs for codfw1dev some new floating IPs were added to codfw1dev along with the notion of them being extra (in the puppet code).
Example:

modules/profile/manifests/openstack/base/cloudgw.pp
if $virt_floating_additional != undef {
    $keepalived_routes = [
        # route floating IPs to neutron
        "${virt_floating} table ${rt_table} nexthop via ${virt_peer} dev ${nic_virt} onlink",
        "${virt_floating_additional} table ${rt_table} nexthop via ${virt_peer} dev ${nic_virt} onlink",
        # route internal VM network to neutron
        "${virt_cidr} table ${rt_table} nexthop via ${virt_peer} dev ${nic_virt} onlink",
    ]
} else {
    $keepalived_routes = [
        # route floating IPs to neutron
        "${virt_floating} table ${rt_table} nexthop via ${virt_peer} dev ${nic_virt} onlink",
        # route internal VM network to neutron
        "${virt_cidr} table ${rt_table} nexthop via ${virt_peer} dev ${nic_virt} onlink",
    ]
}

I suspect, however, that this is no longer in use.

  • If not in use, consider cleaning up all the unused resources
  • If in use, consider consolidating the puppet code to don't have the special-case branches and parameters

Event Timeline

aborrero created this task.

I believe I'm using one for paws-dev, though I'm working on it not being needed in T328842 so hopefully I won't have any application for a floating IP soonish.

Change 887372 had a related patch set uploaded (by Arturo Borrero Gonzalez; author: Arturo Borrero Gonzalez):

[operations/puppet@production] cloudgw: consolidate extra floating IP routes

https://gerrit.wikimedia.org/r/887372

Change 887372 merged by Arturo Borrero Gonzalez:

[operations/puppet@production] cloudgw: consolidate extra floating IP routes

https://gerrit.wikimedia.org/r/887372