Page MenuHomePhabricator

Remove chromedriver dependency
Open, Needs TriagePublic

Description

chromedriver is no longer needed. Codesearch finds it in several repositories. At least Wikibase needs it for running it's test suite.

Wikibase without chromedriver (P43792):

~/Documents/gerrit/mediawiki/core/extensions/Wikibase$ npm run selenium-test                 

> Wikibase@0.1.0 selenium-test
> npm-run-all --continue-on-error selenium-test:*

> Wikibase@0.1.0 selenium-test:repo
> wdio repo/tests/selenium/wdio.conf.js

(...)

Spec Files:      9 passed, 9 total (100% completed) in 00:02:44 

> Wikibase@0.1.0 selenium-test:bridge
> npm --prefix client/data-bridge run selenium-test

> data-bridge@0.1.0 selenium-test
> wdio tests/selenium/wdio.conf.js

(...)

Spec Files:      0 passed, 7 failed, 7 total (100% completed) in 00:00:06 

ERROR: "selenium-test:bridge" exited with 1.

Wikibase with chromedriver (P43794):

~/Documents/gerrit/mediawiki/core/extensions/Wikibase$ npm run selenium-test                       

> Wikibase@0.1.0 selenium-test
> npm-run-all --continue-on-error selenium-test:*

> Wikibase@0.1.0 selenium-test:repo
> wdio repo/tests/selenium/wdio.conf.js

(...)

Spec Files:      9 passed, 9 total (100% completed) in 00:02:25 

> Wikibase@0.1.0 selenium-test:bridge
> npm --prefix client/data-bridge run selenium-test

> data-bridge@0.1.0 selenium-test
> wdio tests/selenium/wdio.conf.js

(...)

Spec Files:      7 passed, 7 total (100% completed) in 00:03:36 

ERROR: "selenium-test:repo" exited with 1.

Event Timeline

Change 887773 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/extensions/Wikibase@master] WIP selenium: Remove chromedriver dependency

https://gerrit.wikimedia.org/r/887773

Change 887773 abandoned by Zfilipin:

[mediawiki/extensions/Wikibase@master] WIP selenium: Remove chromedriver dependency

Reason:

https://gerrit.wikimedia.org/r/887773