Page MenuHomePhabricator
Create Task
Maniphest T329167

Wikibase Repository: The collapse button in sitelinks view become invisible, overlapped by the sitelinks heading
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To
Winston_Sung
Authored By
Winston_Sung
Feb 8 2023, 11:59 AM
Tags
Referenced Files
F36803040: image.png
Feb 8 2023, 11:59 AM
F36803049: image.png
Feb 8 2023, 11:59 AM
F36803047: image.png
Feb 8 2023, 11:59 AM
F36803043: image.png
Feb 8 2023, 11:59 AM
F36803038: image.png
Feb 8 2023, 11:59 AM
Subscribers
Aklapper
hubaishan
ItamarWMDE
JayanthMKV
karapayneWMDE
Lucas_Werkmeister_WMDE
Lydia_Pintscher
Winston_Sung

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • The collapse button in sitelinks view being overlapped by the sitelinks heading, caused the button become invisible and unusable.
    • Non-safemode:
      image.png (131×1 px, 8 KB)
    • Safemode:
      image.png (136×1 px, 11 KB)
    • Inspect elements:
      image.png (141×877 px, 17 KB)
      image.png (111×773 px, 14 KB)

What should have happened instead?:

  • The collapse button in sitelinks view should be visible.
    image.png (132×1 px, 8 KB)

Software version (skip for WMF-hosted wikis like Wikipedia):

  • Site: Wikidata
  • MediaWiki 1.40.0-wmf.21 ( 2789b80 )
  • WikibaseRepository – ( 1702cb9 )

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Move sitelinks collapse toggle into heading using placeholdermediawiki/extensions/Wikibasemaster+5 -12
Move sitelinks collapse toggle into headingmediawiki/extensions/Wikibasemaster+11 -4
jquery.makeCollapsible: support toggle placeholdermediawiki/coremaster+57 -5
Wikibase Repository: Fix collapse button in sitelinks viewmediawiki/extensions/Wikibasemaster+8 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Winston_Sung created this task.Feb 8 2023, 11:59 AM
Lydia_Pintscher subscribed.Feb 9 2023, 9:57 AM

Uhmmmm did we lose the collapse button and didn't notice until now? -.- Thanks for filing the report. I can reproduce it.

Lydia_Pintscher added a project: patch-welcome.Feb 9 2023, 9:58 AM
Lydia_Pintscher added a subscriber: ItamarWMDE.

@ItamarWMDE does this qualify as a good starter task?

Restricted Application added a project: User-ItamarWMDE. · View Herald TranscriptFeb 9 2023, 9:58 AM
Winston_Sung updated the task description. (Show Details)Feb 9 2023, 11:11 AM
Winston_Sung updated the task description. (Show Details)
ItamarWMDE added a comment.Feb 9 2023, 2:46 PM

Yeah I'd say so, seems like z-index / element ordering issue

Lydia_Pintscher added a project: good first task.Feb 9 2023, 3:13 PM
Winston_Sung added a comment.Feb 9 2023, 7:08 PM

I have no knowledge about how to change the toggle's place as that depends on the makeCollapsible / mw-collapsible in MediaWiki core.

The solution that I can currently do would be adding z-index , but I think that's a bad practice.

gerritbot added a comment.Feb 9 2023, 7:14 PM

Change 887855 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/extensions/Wikibase@master] Wikibase Repository: Fix collapse button in sitelinks view

https://gerrit.wikimedia.org/r/887855

gerritbot added a project: Patch-For-Review.Feb 9 2023, 7:15 PM
Lydia_Pintscher added a project: [Archived]Wikidata Dev Team.Feb 10 2023, 1:13 PM

Thank you for the patch!

Lydia_Pintscher moved this task from Incoming to Product Backlog on the [Archived]Wikidata Dev Team board.Feb 10 2023, 1:13 PM
Lydia_Pintscher moved this task from Product Backlog to SEND TO OMEGA BOARD. Will land in the 'incoming' column and need to be moved to the correct location (former Unified DOT Backlog) on the [Archived]Wikidata Dev Team board.Feb 15 2023, 10:54 AM
gerritbot added a comment.Feb 17 2023, 12:22 PM

Change 889973 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Move sitelinks collapse toggle into heading

https://gerrit.wikimedia.org/r/889973

gerritbot added a comment.Feb 17 2023, 12:30 PM

Change 887855 abandoned by Winston Sung:

[mediawiki/extensions/Wikibase@master] Wikibase Repository: Fix collapse button in sitelinks view

Reason:

Replaced-by: I86854ac3c8d1b3ca14d126de9a4bfa215bdee902

https://gerrit.wikimedia.org/r/887855

karapayneWMDE set the point value for this task to 2.Feb 21 2023, 9:55 AM
karapayneWMDE subscribed.

Sprint 4 Planning: Review both patches and agree on with which to move forward

gerritbot added a comment.Feb 22 2023, 8:42 AM

Change 887855 restored by Winston Sung:

[mediawiki/extensions/Wikibase@master] Wikibase Repository: Fix collapse button in sitelinks view

https://gerrit.wikimedia.org/r/887855

ItamarWMDE moved this task from Radar to Radar on the User-ItamarWMDE board.Feb 22 2023, 10:40 AM
JayanthMKV claimed this task.Feb 23 2023, 12:08 PM
JayanthMKV subscribed.

Assign me this issue, I would like lo solve this

ItamarWMDE added a comment.EditedFeb 27 2023, 11:25 AM

@JayanthMKV Thank you for your interest in resolving this issue, we currently already have a few patches and are awaiting team review on them. I'm confident however, that there are plenty of other 'good-first-tasks' to be picked up. Have a look at: https://phabricator.wikimedia.org/maniphest/query/jsySdXllltwv/#R

gerritbot added a comment.Mar 10 2023, 9:09 AM

Change 887855 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Wikibase Repository: Fix collapse button in sitelinks view

https://gerrit.wikimedia.org/r/887855

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.27; 2023-03-13).Mar 10 2023, 10:00 AM
Lydia_Pintscher closed this task as Resolved.Mar 10 2023, 4:32 PM

This works not on beta and will go to Wikidata in the next days \o/
Thank you for the patch, @Winston_Sung!

Winston_Sung mentioned this in T331774: Wikibase Repository: Collapse button have different height of site link group header in sitelinks view.Mar 11 2023, 8:09 AM
gerritbot added a comment.Mar 13 2023, 3:02 PM

Change 897905 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/core@master] jquery.makeCollapsible: support toggle placeholder

https://gerrit.wikimedia.org/r/897905

gerritbot added a comment.Mar 13 2023, 3:02 PM

Change 897906 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Move sitelinks collapse toggle into heading using placeholder

https://gerrit.wikimedia.org/r/897906

Legoktm reassigned this task from JayanthMKV to Winston_Sung.Mar 19 2023, 10:50 PM
gerritbot added a comment.Mar 22 2023, 6:11 PM

Change 897905 merged by jenkins-bot:

[mediawiki/core@master] jquery.makeCollapsible: support toggle placeholder

https://gerrit.wikimedia.org/r/897905

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.2; 2023-03-27).Mar 22 2023, 7:00 PM
gerritbot added a comment.Mar 23 2023, 11:06 AM

Change 889973 abandoned by Lucas Werkmeister (WMDE):

[mediawiki/extensions/Wikibase@master] Move sitelinks collapse toggle into heading

Reason:

https://gerrit.wikimedia.org/r/889973

Lucas_Werkmeister_WMDE added a comment.Mar 23 2023, 11:12 AM
In T329167#8687793, @gerritbot wrote:

Change 897906 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Move sitelinks collapse toggle into heading using placeholder

https://gerrit.wikimedia.org/r/897906

This alternative implementation should now be ready, if we want to go with it. (It’s less code in Wikibase, and the MediaWiki core side was already merged.)

gerritbot added a comment.Mar 28 2023, 8:34 AM

Change 897906 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Move sitelinks collapse toggle into heading using placeholder

https://gerrit.wikimedia.org/r/897906

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.3; 2023-04-03); removed MW-1.41-notes (1.41.0-wmf.2; 2023-03-27).Mar 28 2023, 9:00 AM
Winston_Sung closed subtask T331774: Wikibase Repository: Collapse button have different height of site link group header in sitelinks view as Resolved.Fri, Nov 14, 3:31 PM
Restricted Application added a subscriber: hubaishan. · View Herald TranscriptFri, Nov 14, 3:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits