Page MenuHomePhabricator

DumpHTML "Latest revision" link oddities with protocol-relative URLs
Closed, ResolvedPublic

Description

When using protocol-relative links in $wgServer along with DumpHTML extension, the 'Latest revision' tab can end up breaking when viewing the pages on the local filesystem:

<a href="//stormcloud.local/trunk/index.php/Main_Page">Latest revision</a>

ends up resolving the URL in the browser to something like:

file:///trunk/index.php/Main_Page

which doesn't work too well.

Should probably use $title->getCanonicalURL here.


Version: unspecified
Severity: normal

Details

Reference
bz30922

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 21 2014, 11:58 PM
bzimport set Reference to bz30922.
bzimport added a subscriber: Unknown Object (MLST).

r97226 clears this up; uses wfExpandURL(x, PROT_CANONICAL) when slurping in the old article path (later used to generate the links).