Page MenuHomePhabricator

CI should ensure that wmf-config/logos.php matches logos/config.yaml
Closed, ResolvedPublic

Description

Ocasionally, wmf-config/logos.php is manually changed in a way that introduces drifts between the configuration file (logos/config.yaml) and the PHP. In other words, the generated PHP file on master branch is different from the actually committed one. A recent example of this is fixed by r887825.

logos/manage.py seems to have support for validation included, so this should be reasonably easy to accomplish.

Tagging Continuous-Integration-Config, as this will require adding a Python-based CI job. I think we should first add it as an experimental check, ensure that the newly added validation works well, and then eventually making it voting.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 887829 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[integration/config@master] [Zuul] Add tox-docker as an experimental job for operations/mediawiki-config

https://gerrit.wikimedia.org/r/887829

Change 887830 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] [tox] Use py39 jobs only

https://gerrit.wikimedia.org/r/887830

Change 887829 merged by jenkins-bot:

[integration/config@master] [Zuul] Add tox-docker as an experimental job for operations/mediawiki-config

https://gerrit.wikimedia.org/r/887829

Change 891317 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[integration/config@master] [Zuul] Make tox-docker a voting job for operations/mediawiki-config

https://gerrit.wikimedia.org/r/891317

Change 887830 merged by jenkins-bot:

[operations/mediawiki-config@master] [tox] Make running `tox` work

https://gerrit.wikimedia.org/r/887830

Mentioned in SAL (#wikimedia-operations) [2023-02-22T15:50:21Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:887830|[tox] Make running tox work (T329231)]]

Mentioned in SAL (#wikimedia-operations) [2023-02-22T15:52:08Z] <urbanecm@deploy1002> urbanecm: Backport for [[gerrit:887830|[tox] Make running tox work (T329231)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-02-22T15:58:16Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:887830|[tox] Make running tox work (T329231)]] (duration: 07m 54s)

Last step here should be deploying r891317 and making the newly-added job a voting one.

Change 891317 merged by jenkins-bot:

[integration/config@master] [Zuul] Make tox-docker a voting job for operations/mediawiki-config

https://gerrit.wikimedia.org/r/891317

Change 891505 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] [DNM] Testing CI

https://gerrit.wikimedia.org/r/891505

Change 891505 abandoned by Urbanecm:

[operations/mediawiki-config@master] [DNM] Testing CI

Reason:

CI works as expected

https://gerrit.wikimedia.org/r/891505

Did a final test with r891505, it works. Resolving!

Did a final test with r891505, it works. Resolving!

Well done! Thank you for all the work on that front.

antoine-approve

Hi @Urbanecm, could you explain why only python 3.9 is supported in tox.ini? I'm on a newly installed Debian 12 system, and there's only python 3.11 on it. I would like to know if it's possible to support it as well. Thanks!