Page MenuHomePhabricator
Create Task
Maniphest T329320

Update new component task template and update links in our DS documentation
Closed, ResolvedPublic
Actions

Description

Background/Goal

We have decided to rethink the way we create task hierarchy, and one result is that we would like to get rid of the epic task template for new components, replacing them with something similar but with the acceptance criteria of just the MVP of that component. Then, we'll need to update links to the epic and MVP task template throughout our docs.

New template

Link to the new template

Acceptance criteria (or Done)

Details

SubjectRepoBranchLines +/-
Update Codex from v0.6.0 to v0.6.2mediawiki/coremaster+198 -204
docs: Update new component task template linksdesign/codexmain+24 -32
Customize query in gerrit

Related Objects

Event Timeline

bmartinezcalvo created this task.Feb 9 2023, 6:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 9 2023, 6:13 PM
bmartinezcalvo triaged this task as High priority.Feb 9 2023, 6:13 PM
bmartinezcalvo moved this task from Inbox to Needs Refinement on the Design-System-Team board.
Volker_E renamed this task from Update the info about Epic tasks in our DS documnetation to Update the info about Epic tasks in our DS documentation.Feb 14 2023, 11:03 PM
Volker_E added a project: Documentation.
AnneT renamed this task from Update the info about Epic tasks in our DS documentation to Update new component task template and update links in our DS documentation.Feb 16 2023, 4:14 PM
AnneT changed the task status from Open to In Progress.
AnneT claimed this task.
AnneT edited projects, added Design-System-Team (Design-System-Sprint); removed Design-System-Team.
AnneT updated the task description. (Show Details)
AnneT added a subscriber: CCiufo-WMF.

@ldelench_wmf @CCiufo-WMF I've created this new task template for new components; please let me know if you have any suggestions for improvement! Once we agree that this is good enough, I can start updating the links in our docs.

AnneT moved this task from Committed to In Development on the Design-System-Team (Design-System-Sprint) board.Feb 16 2023, 4:16 PM
ldelench_wmf added a comment.Feb 16 2023, 5:25 PM

Looks great to me, thanks @AnneT ! For this bit, under Existing Implementations:

Should we link to https://www.mediawiki.org/wiki/Vue.js#Projects_using_Vue.js instead of T272885? Linking to a resolved task might lead folks to think the inventory is outdated.

AnneT added a comment.Feb 16 2023, 5:48 PM

@ldelench_wmf oh yeah, absolutely! Thanks for thinking of that. I've updated the template link here.

ldelench_wmf added a comment.Feb 16 2023, 7:21 PM

Nice, thanks @AnneT! No other feedback from me.

CCiufo-WMF added a comment.Feb 16 2023, 7:55 PM

Looks good to me as well!

bmartinezcalvo added a comment.Feb 17 2023, 8:57 AM
In T329320#8622128, @AnneT wrote:

@ldelench_wmf @CCiufo-WMF I've created this new task template for new components; please let me know if you have any suggestions for improvement! Once we agree that this is good enough, I can start updating the links in our docs.

@AnneT it LGTM too. Just a couple of things to improve:

  1. Could we include in the Acceptance criteria the check to link the Figma spec sheet in the task? Also we could separate the Design and Code sections as we have now in this other task template:

    Design
    • Design the Figma spec sheet and add it in this task
    • Update the component in the Figma library. This step will be done by a DST member.

      Code
    • Implement the component in Codex
  1. The User stories section is missing.
ldelench_wmf mentioned this in T325351: Add TreeView component to Codex (MVP).Feb 17 2023, 11:35 PM
ldelench_wmf mentioned this in T311874: Skeleton: Add Skeleton loader component to Codex.Feb 18 2023, 12:16 AM
ldelench_wmf mentioned this in T303320: Table: Add Table component to Codex.Feb 18 2023, 12:21 AM
AnneT added a comment.Feb 21 2023, 4:17 PM

Thanks for the feedback, @bmartinezcalvo! I've incorporated it into the most recent version of the template.

AnneT updated the task description. (Show Details)Feb 21 2023, 4:17 PM
gerritbot added a comment.Feb 21 2023, 7:19 PM

Change 890897 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[design/codex@main] docs: Update new component task template links

https://gerrit.wikimedia.org/r/890897

gerritbot added a project: Patch-For-Review.Feb 21 2023, 7:19 PM
AnneT updated the task description. (Show Details)Feb 21 2023, 7:46 PM

@bmartinezcalvo FYI I have opened a patch to update all of the links on the Codex docs site, and have updated the links we have on our mediawiki.org pages. Could you please take care of the governance model links?

gerritbot added a comment.Feb 21 2023, 9:56 PM

Change 890897 merged by jenkins-bot:

[design/codex@main] docs: Update new component task template links

https://gerrit.wikimedia.org/r/890897

Maintenance_bot removed a project: Patch-For-Review.Feb 21 2023, 10:11 PM
bmartinezcalvo added a comment.Feb 24 2023, 1:08 PM
In T329320#8634643, @AnneT wrote:

@bmartinezcalvo FYI I have opened a patch to update all of the links on the Codex docs site, and have updated the links we have on our mediawiki.org pages. Could you please take care of the governance model links?

@AnneT updated both the Governance model flowchart and documentation.

bmartinezcalvo updated the task description. (Show Details)Feb 24 2023, 1:09 PM
AnneT closed this task as Resolved.Feb 27 2023, 1:53 PM

@bmartinezcalvo awesome, thanks!

gerritbot added a comment.Feb 28 2023, 8:01 PM

Change 893051 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update Codex from v0.6.0 to v0.6.2

https://gerrit.wikimedia.org/r/893051

gerritbot added a project: Patch-For-Review.Feb 28 2023, 8:01 PM
gerritbot added a comment.Feb 28 2023, 8:39 PM

Change 893051 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.6.0 to v0.6.2

https://gerrit.wikimedia.org/r/893051

Maintenance_bot removed a project: Patch-For-Review.Feb 28 2023, 9:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits